====================================================== WARNING: possible circular locking dependency detected 5.15.148-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor372/4394 is trying to acquire lock: ffff0000d74cb708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 but task is already holding lock: ffff0000d8e5e0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x6d4/0x9cc fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x508 fs/namei.c:4286 do_unlinkat+0x4cc/0x830 fs/namei.c:4354 __do_sys_unlinkat fs/namei.c:4397 [inline] __se_sys_unlinkat fs/namei.c:4390 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4390 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 block_read_full_page+0x2a0/0xc4c fs/buffer.c:2290 hfsplus_readpage+0x28/0x38 fs/hfsplus/inode.c:28 do_read_cache_page+0x60c/0x950 read_cache_page+0x68/0x84 mm/filemap.c:3574 read_mapping_page include/linux/pagemap.h:515 [inline] __hfs_bnode_create+0x3f0/0x864 fs/hfsplus/bnode.c:447 hfsplus_bnode_create+0x128/0x4ec fs/hfsplus/bnode.c:587 hfsplus_bmap_alloc+0x5a4/0x698 fs/hfsplus/btree.c:414 hfs_bnode_split+0xcc/0xd88 fs/hfsplus/brec.c:245 hfsplus_brec_insert+0x2d4/0xaa0 fs/hfsplus/brec.c:100 hfsplus_create_cat+0x3ac/0x1330 fs/hfsplus/catalog.c:292 hfsplus_fill_super+0xf64/0x167c fs/hfsplus/super.c:560 mount_bdev+0x274/0x370 fs/super.c:1387 hfsplus_mount+0x44/0x58 fs/hfsplus/super.c:641 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1517 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 3 locks held by syz-executor372/4394: #0: ffff0000c2dc40e0 (&type->s_umount_key#40/1){+.+.}-{3:3}, at: alloc_super+0x1b8/0x844 fs/super.c:229 #1: ffff0000d9238998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_fill_super+0xf0c/0x167c fs/hfsplus/super.c:553 #2: ffff0000d8e5e0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc stack backtrace: CPU: 1 PID: 4394 Comm: syz-executor372 Not tainted 5.15.148-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 block_read_full_page+0x2a0/0xc4c fs/buffer.c:2290 hfsplus_readpage+0x28/0x38 fs/hfsplus/inode.c:28 do_read_cache_page+0x60c/0x950 read_cache_page+0x68/0x84 mm/filemap.c:3574 read_mapping_page include/linux/pagemap.h:515 [inline] __hfs_bnode_create+0x3f0/0x864 fs/hfsplus/bnode.c:447 hfsplus_bnode_create+0x128/0x4ec fs/hfsplus/bnode.c:587 hfsplus_bmap_alloc+0x5a4/0x698 fs/hfsplus/btree.c:414 hfs_bnode_split+0xcc/0xd88 fs/hfsplus/brec.c:245 hfsplus_brec_insert+0x2d4/0xaa0 fs/hfsplus/brec.c:100 hfsplus_create_cat+0x3ac/0x1330 fs/hfsplus/catalog.c:292 hfsplus_fill_super+0xf64/0x167c fs/hfsplus/super.c:560 mount_bdev+0x274/0x370 fs/super.c:1387 hfsplus_mount+0x44/0x58 fs/hfsplus/super.c:641 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1517 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584