======================================================
WARNING: possible circular locking dependency detected
6.8.0-rc5-syzkaller-01592-g25d434257464 #0 Not tainted
------------------------------------------------------
syz-executor.2/8794 is trying to acquire lock:
ffff88805aff1c58 (k-sk_lock-AF_INET6){+.+.}-{0:0}, at: tcp_diag_put_ulp net/ipv4/tcp_diag.c:100 [inline]
ffff88805aff1c58 (k-sk_lock-AF_INET6){+.+.}-{0:0}, at: tcp_diag_get_aux+0x738/0x830 net/ipv4/tcp_diag.c:137

but task is already holding lock:
ffffc90001326790 (&h->lhash2[i].lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:351 [inline]
ffffc90001326790 (&h->lhash2[i].lock){+.+.}-{2:2}, at: inet_diag_dump_icsk+0x3d8/0x2050 net/ipv4/inet_diag.c:1052

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&h->lhash2[i].lock){+.+.}-{2:2}:
       lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754
       __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
       _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
       spin_lock include/linux/spinlock.h:351 [inline]
       __inet_hash+0x335/0xbe0 net/ipv4/inet_hashtables.c:743
       inet_csk_listen_start+0x23a/0x320 net/ipv4/inet_connection_sock.c:1261
       __inet_listen_sk+0x2a2/0x770 net/ipv4/af_inet.c:217
       inet_listen+0xa3/0x110 net/ipv4/af_inet.c:239
       rds_tcp_listen_init+0x3fd/0x5a0 net/rds/tcp_listen.c:316
       rds_tcp_init_net+0x141/0x320 net/rds/tcp.c:577
       ops_init+0x352/0x610 net/core/net_namespace.c:136
       __register_pernet_operations net/core/net_namespace.c:1243 [inline]
       register_pernet_operations+0x2cb/0x660 net/core/net_namespace.c:1312
       register_pernet_device+0x33/0x80 net/core/net_namespace.c:1399
       rds_tcp_init+0x62/0xd0 net/rds/tcp.c:735
       do_one_initcall+0x238/0x830 init/main.c:1236
       do_initcall_level+0x157/0x210 init/main.c:1298
       do_initcalls+0x3f/0x80 init/main.c:1314
       kernel_init_freeable+0x42f/0x5d0 init/main.c:1551
       kernel_init+0x1d/0x2a0 init/main.c:1441
       ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1b/0x30 arch/x86/entry/entry_64.S:242

-> #0 (k-sk_lock-AF_INET6){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain+0x18ca/0x58e0 kernel/locking/lockdep.c:3869
       __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137
       lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754
       lock_sock_fast include/net/sock.h:1737 [inline]
       subflow_get_info+0x166/0xd20 net/mptcp/diag.c:28
       tcp_diag_put_ulp net/ipv4/tcp_diag.c:100 [inline]
       tcp_diag_get_aux+0x738/0x830 net/ipv4/tcp_diag.c:137
       inet_sk_diag_fill+0x10f3/0x1e10 net/ipv4/inet_diag.c:354
       inet_diag_dump_icsk+0x587/0x2050 net/ipv4/inet_diag.c:1075
       __inet_diag_dump net/ipv4/inet_diag.c:1281 [inline]
       inet_diag_dump+0x168/0x2f0 net/ipv4/inet_diag.c:1300
       netlink_dump+0x730/0xda0 net/netlink/af_netlink.c:2268
       __netlink_dump_start+0x59d/0x780 net/netlink/af_netlink.c:2376
       netlink_dump_start include/linux/netlink.h:340 [inline]
       inet_diag_handler_cmd+0x1de/0x2b0 net/ipv4/inet_diag.c:1444
       sock_diag_rcv_msg+0x3dd/0x5f0
       netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2549
       netlink_unicast_kernel net/netlink/af_netlink.c:1337 [inline]
       netlink_unicast+0x7ea/0x980 net/netlink/af_netlink.c:1363
       netlink_sendmsg+0xa3b/0xd70 net/netlink/af_netlink.c:1904
       sock_sendmsg_nosec net/socket.c:730 [inline]
       __sock_sendmsg+0x221/0x270 net/socket.c:745
       sock_write_iter+0x2dd/0x400 net/socket.c:1160
       do_iter_readv_writev+0x46c/0x640
       vfs_writev+0x395/0xbb0 fs/read_write.c:971
       do_writev+0x1b1/0x350 fs/read_write.c:1018
       do_syscall_64+0xf9/0x240
       entry_SYSCALL_64_after_hwframe+0x6f/0x77

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&h->lhash2[i].lock);
                               lock(k-sk_lock-AF_INET6);
                               lock(&h->lhash2[i].lock);
  lock(k-sk_lock-AF_INET6);

 *** DEADLOCK ***

2 locks held by syz-executor.2/8794:
 #0: ffff88805a4bd678 (nlk_cb_mutex-SOCK_DIAG){+.+.}-{3:3}, at: __netlink_dump_start+0x119/0x780 net/netlink/af_netlink.c:2340
 #1: ffffc90001326790 (&h->lhash2[i].lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:351 [inline]
 #1: ffffc90001326790 (&h->lhash2[i].lock){+.+.}-{2:2}, at: inet_diag_dump_icsk+0x3d8/0x2050 net/ipv4/inet_diag.c:1052

stack backtrace:
CPU: 1 PID: 8794 Comm: syz-executor.2 Not tainted 6.8.0-rc5-syzkaller-01592-g25d434257464 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2e0 lib/dump_stack.c:106
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain+0x18ca/0x58e0 kernel/locking/lockdep.c:3869
 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137
 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754
 lock_sock_fast include/net/sock.h:1737 [inline]
 subflow_get_info+0x166/0xd20 net/mptcp/diag.c:28
 tcp_diag_put_ulp net/ipv4/tcp_diag.c:100 [inline]
 tcp_diag_get_aux+0x738/0x830 net/ipv4/tcp_diag.c:137
 inet_sk_diag_fill+0x10f3/0x1e10 net/ipv4/inet_diag.c:354
 inet_diag_dump_icsk+0x587/0x2050 net/ipv4/inet_diag.c:1075
 __inet_diag_dump net/ipv4/inet_diag.c:1281 [inline]
 inet_diag_dump+0x168/0x2f0 net/ipv4/inet_diag.c:1300
 netlink_dump+0x730/0xda0 net/netlink/af_netlink.c:2268
 __netlink_dump_start+0x59d/0x780 net/netlink/af_netlink.c:2376
 netlink_dump_start include/linux/netlink.h:340 [inline]
 inet_diag_handler_cmd+0x1de/0x2b0 net/ipv4/inet_diag.c:1444
 sock_diag_rcv_msg+0x3dd/0x5f0
 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2549
 netlink_unicast_kernel net/netlink/af_netlink.c:1337 [inline]
 netlink_unicast+0x7ea/0x980 net/netlink/af_netlink.c:1363
 netlink_sendmsg+0xa3b/0xd70 net/netlink/af_netlink.c:1904
 sock_sendmsg_nosec net/socket.c:730 [inline]
 __sock_sendmsg+0x221/0x270 net/socket.c:745
 sock_write_iter+0x2dd/0x400 net/socket.c:1160
 do_iter_readv_writev+0x46c/0x640
 vfs_writev+0x395/0xbb0 fs/read_write.c:971
 do_writev+0x1b1/0x350 fs/read_write.c:1018
 do_syscall_64+0xf9/0x240
 entry_SYSCALL_64_after_hwframe+0x6f/0x77
RIP: 0033:0x7f3efbc7dda9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3efca270c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000014
RAX: ffffffffffffffda RBX: 00007f3efbdabf80 RCX: 00007f3efbc7dda9
RDX: 0000000000000001 RSI: 0000000020000140 RDI: 0000000000000003
RBP: 00007f3efbcca47a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f3efbdabf80 R15: 00007ffce8822468
 </TASK>
BUG: sleeping function called from invalid context at net/core/sock.c:3563
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 8794, name: syz-executor.2
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
Preemption disabled at:
[<0000000000000000>] 0x0
CPU: 1 PID: 8794 Comm: syz-executor.2 Not tainted 6.8.0-rc5-syzkaller-01592-g25d434257464 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2e0 lib/dump_stack.c:106
 __might_resched+0x5d3/0x780 kernel/sched/core.c:10176
 __lock_sock_fast+0x31/0xe0 net/core/sock.c:3563
 lock_sock_fast include/net/sock.h:1739 [inline]
 subflow_get_info+0x172/0xd20 net/mptcp/diag.c:28
 tcp_diag_put_ulp net/ipv4/tcp_diag.c:100 [inline]
 tcp_diag_get_aux+0x738/0x830 net/ipv4/tcp_diag.c:137
 inet_sk_diag_fill+0x10f3/0x1e10 net/ipv4/inet_diag.c:354
 inet_diag_dump_icsk+0x587/0x2050 net/ipv4/inet_diag.c:1075
 __inet_diag_dump net/ipv4/inet_diag.c:1281 [inline]
 inet_diag_dump+0x168/0x2f0 net/ipv4/inet_diag.c:1300
 netlink_dump+0x730/0xda0 net/netlink/af_netlink.c:2268
 __netlink_dump_start+0x59d/0x780 net/netlink/af_netlink.c:2376
 netlink_dump_start include/linux/netlink.h:340 [inline]
 inet_diag_handler_cmd+0x1de/0x2b0 net/ipv4/inet_diag.c:1444
 sock_diag_rcv_msg+0x3dd/0x5f0
 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2549
 netlink_unicast_kernel net/netlink/af_netlink.c:1337 [inline]
 netlink_unicast+0x7ea/0x980 net/netlink/af_netlink.c:1363
 netlink_sendmsg+0xa3b/0xd70 net/netlink/af_netlink.c:1904
 sock_sendmsg_nosec net/socket.c:730 [inline]
 __sock_sendmsg+0x221/0x270 net/socket.c:745
 sock_write_iter+0x2dd/0x400 net/socket.c:1160
 do_iter_readv_writev+0x46c/0x640
 vfs_writev+0x395/0xbb0 fs/read_write.c:971
 do_writev+0x1b1/0x350 fs/read_write.c:1018
 do_syscall_64+0xf9/0x240
 entry_SYSCALL_64_after_hwframe+0x6f/0x77
RIP: 0033:0x7f3efbc7dda9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3efca270c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000014
RAX: ffffffffffffffda RBX: 00007f3efbdabf80 RCX: 00007f3efbc7dda9
RDX: 0000000000000001 RSI: 0000000020000140 RDI: 0000000000000003
RBP: 00007f3efbcca47a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f3efbdabf80 R15: 00007ffce8822468
 </TASK>