hfsplus: xattr searching failed hfsplus: inconsistency in B*Tree (128,1,255,1,0) hfsplus: xattr searching failed ====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc7-syzkaller-gc912bf709078 #0 Not tainted ------------------------------------------------------ syz.1.522/8202 is trying to acquire lock: ffff0000dc121c08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 but task is already holding lock: ffff0000c25bc0b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&tree->tree_lock/2){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_find_init+0x144/0x1bc hfsplus_attr_exists+0xf8/0x1c8 fs/hfsplus/attributes.c:178 __hfsplus_setxattr+0x380/0x1cf4 fs/hfsplus/xattr.c:336 hfsplus_initxattrs+0x150/0x20c fs/hfsplus/xattr_security.c:59 security_inode_init_security+0x210/0x3fc security/security.c:1744 hfsplus_init_security+0x40/0x54 fs/hfsplus/xattr_security.c:71 hfsplus_fill_super+0x1010/0x166c fs/hfsplus/super.c:573 mount_bdev+0x1d4/0x2a0 fs/super.c:1668 hfsplus_mount+0x44/0x58 fs/hfsplus/super.c:647 legacy_get_tree+0xd4/0x16c fs/fs_context.c:662 vfs_get_tree+0x90/0x288 fs/super.c:1789 do_new_mount+0x278/0x900 fs/namespace.c:3352 path_mount+0x590/0xe04 fs/namespace.c:3679 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount fs/namespace.c:3875 [inline] __arm64_sys_mount+0x3c4/0x488 fs/namespace.c:3875 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x42c/0x690 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x534 fs/namei.c:4396 do_unlinkat+0x4d0/0x700 fs/namei.c:4460 __do_sys_unlinkat fs/namei.c:4503 [inline] __se_sys_unlinkat fs/namei.c:4496 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4496 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_delete_attr+0x14c/0x41c fs/hfsplus/attributes.c:326 hfsplus_removexattr fs/hfsplus/xattr.c:792 [inline] __hfsplus_setxattr+0xa50/0x1cf4 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:432 hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30 __vfs_removexattr+0x3bc/0x3e4 fs/xattr.c:518 __vfs_removexattr_locked+0x1d8/0x3a8 fs/xattr.c:553 vfs_removexattr+0xe0/0x23c fs/xattr.c:575 removexattr+0x148/0x1c4 fs/xattr.c:917 path_removexattr+0x160/0x23c fs/xattr.c:931 __do_sys_removexattr fs/xattr.c:945 [inline] __se_sys_removexattr fs/xattr.c:942 [inline] __arm64_sys_removexattr+0x60/0x78 fs/xattr.c:942 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 other info that might help us debug this: Chain exists of: &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock --> &tree->tree_lock/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/2); lock(&tree->tree_lock); lock(&tree->tree_lock/2); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz.1.522/8202: #0: ffff0000c1d04420 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:409 #1: ffff0000d92189c0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #1: ffff0000d92189c0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: vfs_removexattr+0xcc/0x23c fs/xattr.c:574 #2: ffff0000c25be0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc #3: ffff0000c25bc0b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc stack backtrace: CPU: 1 PID: 8202 Comm: syz.1.522 Not tainted 6.10.0-rc7-syzkaller-gc912bf709078 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:317 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:324 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:114 dump_stack+0x1c/0x28 lib/dump_stack.c:123 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2060 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_delete_attr+0x14c/0x41c fs/hfsplus/attributes.c:326 hfsplus_removexattr fs/hfsplus/xattr.c:792 [inline] __hfsplus_setxattr+0xa50/0x1cf4 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:432 hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30 __vfs_removexattr+0x3bc/0x3e4 fs/xattr.c:518 __vfs_removexattr_locked+0x1d8/0x3a8 fs/xattr.c:553 vfs_removexattr+0xe0/0x23c fs/xattr.c:575 removexattr+0x148/0x1c4 fs/xattr.c:917 path_removexattr+0x160/0x23c fs/xattr.c:931 __do_sys_removexattr fs/xattr.c:945 [inline] __se_sys_removexattr fs/xattr.c:942 [inline] __arm64_sys_removexattr+0x60/0x78 fs/xattr.c:942 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 9pnet_fd: Insufficient options for proto=fd