====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.98/4748 is trying to acquire lock: ffff0000d91ee650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263 but task is already holding lock: ffff0000e6933f60 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0x940/0x191c fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:931 ocfs2_xattr_set+0x7b8/0x1478 fs/ocfs2/xattr.c:3665 ocfs2_set_acl+0x410/0x4b4 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x214/0x358 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x2cc/0x378 fs/posix_acl.c:966 __vfs_removexattr+0x370/0x38c fs/xattr.c:470 __vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505 vfs_removexattr+0xe0/0x23c fs/xattr.c:527 ovl_workdir_create+0x360/0x624 fs/overlayfs/super.c:818 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x344/0x1110 fs/overlayfs/super.c:1524 ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080 mount_nodev+0x68/0x104 fs/super.c:1444 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1528 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #3 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_init_acl+0x2d0/0x778 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1558/0x24f8 fs/ocfs2/namei.c:408 ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655 vfs_mkdir+0x334/0x4e4 fs/namei.c:4065 do_mkdirat+0x20c/0x610 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464 jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560 ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354 ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882 ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610 generic_shutdown_super+0x130/0x29c fs/super.c:475 kill_block_super+0x70/0xdc fs/super.c:1425 deactivate_locked_super+0xb8/0x13c fs/super.c:335 deactivate_super+0x108/0x128 fs/super.c:366 cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143 __cleanup_mnt+0x20/0x30 fs/namespace.c:1150 task_work_run+0x130/0x1e4 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline] el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882 ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610 generic_shutdown_super+0x130/0x29c fs/super.c:475 kill_block_super+0x70/0xdc fs/super.c:1425 deactivate_locked_super+0xb8/0x13c fs/super.c:335 deactivate_super+0x108/0x128 fs/super.c:366 cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143 __cleanup_mnt+0x20/0x30 fs/namespace.c:1150 task_work_run+0x130/0x1e4 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline] el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1928 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263 notify_change+0xa34/0xcf8 fs/attr.c:505 ovl_workdir_create+0x498/0x624 fs/overlayfs/super.c:830 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x344/0x1110 fs/overlayfs/super.c:1524 ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080 mount_nodev+0x68/0x104 fs/super.c:1444 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1528 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: sb_internal#3 --> &oi->ip_xattr_sem --> &ocfs2_file_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(&oi->ip_xattr_sem); lock(&ocfs2_file_ip_alloc_sem_key); lock(sb_internal#3); *** DEADLOCK *** 5 locks held by syz.2.98/4748: #0: ffff0000ce22e0e0 (&type->s_umount_key#70/1){+.+.}-{3:3}, at: alloc_super+0x1b8/0x844 fs/super.c:229 #1: ffff0000d91ee460 (sb_writers#22){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #2: ffff0000ddea42c8 (&sb->s_type->i_mutex_key#27/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #2: ffff0000ddea42c8 (&sb->s_type->i_mutex_key#27/1){+.+.}-{3:3}, at: ovl_workdir_create+0x130/0x624 fs/overlayfs/super.c:768 #3: ffff0000e69342c8 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #3: ffff0000e69342c8 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: ovl_workdir_create+0x46c/0x624 fs/overlayfs/super.c:829 #4: ffff0000e6933f60 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0x940/0x191c fs/ocfs2/file.c:1262 stack backtrace: CPU: 0 PID: 4748 Comm: syz.2.98 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1928 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263 notify_change+0xa34/0xcf8 fs/attr.c:505 ovl_workdir_create+0x498/0x624 fs/overlayfs/super.c:830 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x344/0x1110 fs/overlayfs/super.c:1524 ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080 mount_nodev+0x68/0x104 fs/super.c:1444 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1528 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features. (syz.2.98,4748,0):ocfs2_double_lock:1186 ERROR: status = -2 (syz.2.98,4748,0):ocfs2_rename:1295 ERROR: status = -2 (syz.2.98,4748,0):ocfs2_rename:1685 ERROR: status = -2 netlink: 'syz.2.98': attribute type 62 has an invalid length.