====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc5-syzkaller-00387-g4c75bf7e4a0e #0 Not tainted ------------------------------------------------------ syz-executor.5/32323 is trying to acquire lock: ffff88808a4ab600 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline] ffff88808a4ab600 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}, at: ext4_xattr_inode_iget+0x425/0x5e0 fs/ext4/xattr.c:461 but task is already holding lock: ffff8880858d8288 (&ei->i_data_sem/3){++++}-{3:3}, at: ext4_setattr+0x14d4/0x1bc0 fs/ext4/inode.c:5397 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ei->i_data_sem/3){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 ext4_update_i_disksize fs/ext4/ext4.h:3363 [inline] ext4_xattr_inode_write fs/ext4/xattr.c:1446 [inline] ext4_xattr_inode_lookup_create fs/ext4/xattr.c:1594 [inline] ext4_xattr_set_entry+0x3459/0x3fb0 fs/ext4/xattr.c:1719 ext4_xattr_block_set+0xb12/0x3630 fs/ext4/xattr.c:2039 ext4_xattr_set_handle+0xcd4/0x15c0 fs/ext4/xattr.c:2456 ext4_xattr_set+0x241/0x3d0 fs/ext4/xattr.c:2558 __vfs_setxattr+0x460/0x4a0 fs/xattr.c:201 __vfs_setxattr_noperm+0x12e/0x5e0 fs/xattr.c:235 vfs_setxattr+0x221/0x420 fs/xattr.c:322 do_setxattr fs/xattr.c:630 [inline] setxattr+0x25d/0x2f0 fs/xattr.c:653 path_setxattr+0x1c0/0x2a0 fs/xattr.c:672 __do_sys_setxattr fs/xattr.c:688 [inline] __se_sys_setxattr fs/xattr.c:684 [inline] __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:684 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:771 [inline] ext4_xattr_inode_iget+0x425/0x5e0 fs/ext4/xattr.c:461 ext4_xattr_inode_get+0x164/0x430 fs/ext4/xattr.c:535 ext4_xattr_move_to_block fs/ext4/xattr.c:2640 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2742 [inline] ext4_expand_extra_isize_ea+0xf21/0x1ce0 fs/ext4/xattr.c:2834 __ext4_expand_extra_isize+0x2f7/0x3d0 fs/ext4/inode.c:5769 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5812 [inline] __ext4_mark_inode_dirty+0x53e/0x870 fs/ext4/inode.c:5890 ext4_setattr+0x1567/0x1bc0 fs/ext4/inode.c:5400 notify_change+0xc8b/0xf40 fs/attr.c:483 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3295 [inline] do_open fs/namei.c:3640 [inline] path_openat+0x2959/0x3180 fs/namei.c:3793 do_filp_open+0x234/0x490 fs/namei.c:3820 do_sys_openat2+0x13e/0x1d0 fs/open.c:1407 do_sys_open fs/open.c:1422 [inline] __do_sys_creat fs/open.c:1498 [inline] __se_sys_creat fs/open.c:1492 [inline] __x64_sys_creat+0x123/0x160 fs/open.c:1492 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/3); lock(&ea_inode->i_rwsem#7/1); lock(&ei->i_data_sem/3); lock(&ea_inode->i_rwsem#7/1); *** DEADLOCK *** 5 locks held by syz-executor.5/32323: #0: ffff88803bf88410 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:403 #1: ffff8880858d8400 (&sb->s_type->i_mutex_key#7){++++}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline] #1: ffff8880858d8400 (&sb->s_type->i_mutex_key#7){++++}-{3:3}, at: do_truncate+0x20c/0x300 fs/open.c:64 #2: ffff8880858d85a0 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:816 [inline] #2: ffff8880858d85a0 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_setattr+0xf31/0x1bc0 fs/ext4/inode.c:5357 #3: ffff8880858d8288 (&ei->i_data_sem/3){++++}-{3:3}, at: ext4_setattr+0x14d4/0x1bc0 fs/ext4/inode.c:5397 #4: ffff8880858d80c8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:162 [inline] #4: ffff8880858d80c8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:5809 [inline] #4: ffff8880858d80c8 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x4a5/0x870 fs/ext4/inode.c:5890 stack backtrace: CPU: 0 PID: 32323 Comm: syz-executor.5 Not tainted 6.5.0-rc5-syzkaller-00387-g4c75bf7e4a0e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:771 [inline] ext4_xattr_inode_iget+0x425/0x5e0 fs/ext4/xattr.c:461 ext4_xattr_inode_get+0x164/0x430 fs/ext4/xattr.c:535 ext4_xattr_move_to_block fs/ext4/xattr.c:2640 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2742 [inline] ext4_expand_extra_isize_ea+0xf21/0x1ce0 fs/ext4/xattr.c:2834 __ext4_expand_extra_isize+0x2f7/0x3d0 fs/ext4/inode.c:5769 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5812 [inline] __ext4_mark_inode_dirty+0x53e/0x870 fs/ext4/inode.c:5890 ext4_setattr+0x1567/0x1bc0 fs/ext4/inode.c:5400 notify_change+0xc8b/0xf40 fs/attr.c:483 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3295 [inline] do_open fs/namei.c:3640 [inline] path_openat+0x2959/0x3180 fs/namei.c:3793 do_filp_open+0x234/0x490 fs/namei.c:3820 do_sys_openat2+0x13e/0x1d0 fs/open.c:1407 do_sys_open fs/open.c:1422 [inline] __do_sys_creat fs/open.c:1498 [inline] __se_sys_creat fs/open.c:1492 [inline] __x64_sys_creat+0x123/0x160 fs/open.c:1492 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f8aa3c7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f8aa49270c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 00007f8aa3d9c050 RCX: 00007f8aa3c7cae9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000100 RBP: 00007f8aa3cc847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f8aa3d9c050 R15: 00007ffe62882468