====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc7-syzkaller-gc912bf709078 #0 Not tainted ------------------------------------------------------ syz.0.68/6940 is trying to acquire lock: ffff0000d8e40ae8 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xac/0x5c8 fs/gfs2/quota.c:720 but task is already holding lock: ffff0000efb94fd0 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1529 [inline] ffff0000efb94fd0 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1f58/0x2f6c fs/gfs2/bmap.c:1853 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1526 __gfs2_iomap_get+0x124/0x102c fs/gfs2/bmap.c:859 gfs2_iomap_get+0xd8/0x154 fs/gfs2/bmap.c:1413 bh_get+0x1ec/0x688 fs/gfs2/quota.c:417 qdsb_get+0x1c8/0x30c fs/gfs2/quota.c:566 gfs2_quota_hold+0x16c/0x560 fs/gfs2/quota.c:646 punch_hole+0xc10/0x2f6c fs/gfs2/bmap.c:1814 __gfs2_punch_hole+0x6d4/0x918 fs/gfs2/bmap.c:2460 gfs2_fallocate+0x354/0x458 fs/gfs2/file.c:1399 vfs_fallocate+0x480/0x5bc fs/open.c:330 ioctl_preallocate+0x21c/0x2a0 fs/ioctl.c:291 do_vfs_ioctl+0x1b88/0x2404 fs/ioctl.c:886 __do_sys_ioctl fs/ioctl.c:905 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:893 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 do_qc+0xac/0x5c8 fs/gfs2/quota.c:720 gfs2_quota_change+0x238/0x728 fs/gfs2/quota.c:1315 punch_hole+0x2a28/0x2f6c fs/gfs2/bmap.c:1954 __gfs2_punch_hole+0x6d4/0x918 fs/gfs2/bmap.c:2460 gfs2_fallocate+0x354/0x458 fs/gfs2/file.c:1399 vfs_fallocate+0x480/0x5bc fs/open.c:330 ioctl_preallocate+0x21c/0x2a0 fs/ioctl.c:291 do_vfs_ioctl+0x1b88/0x2404 fs/ioctl.c:886 __do_sys_ioctl fs/ioctl.c:905 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:893 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 5 locks held by syz.0.68/6940: #0: ffff0000cd310420 (sb_writers#15){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2854 [inline] #0: ffff0000cd310420 (sb_writers#15){.+.+}-{0:0}, at: vfs_fallocate+0x40c/0x5bc fs/open.c:329 #1: ffff0000efb94b38 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #1: ffff0000efb94b38 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: gfs2_fallocate+0x188/0x458 fs/gfs2/file.c:1380 #2: ffff0000cd310610 (sb_internal#4){.+.+}-{0:0}, at: gfs2_trans_begin+0x8c/0x100 fs/gfs2/trans.c:118 #3: ffff0000d8e41060 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x510/0x908 fs/gfs2/trans.c:87 #4: ffff0000efb94fd0 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1529 [inline] #4: ffff0000efb94fd0 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1f58/0x2f6c fs/gfs2/bmap.c:1853 stack backtrace: CPU: 0 PID: 6940 Comm: syz.0.68 Not tainted 6.10.0-rc7-syzkaller-gc912bf709078 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:317 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:324 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:114 dump_stack+0x1c/0x28 lib/dump_stack.c:123 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2060 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 do_qc+0xac/0x5c8 fs/gfs2/quota.c:720 gfs2_quota_change+0x238/0x728 fs/gfs2/quota.c:1315 punch_hole+0x2a28/0x2f6c fs/gfs2/bmap.c:1954 __gfs2_punch_hole+0x6d4/0x918 fs/gfs2/bmap.c:2460 gfs2_fallocate+0x354/0x458 fs/gfs2/file.c:1399 vfs_fallocate+0x480/0x5bc fs/open.c:330 ioctl_preallocate+0x21c/0x2a0 fs/ioctl.c:291 do_vfs_ioctl+0x1b88/0x2404 fs/ioctl.c:886 __do_sys_ioctl fs/ioctl.c:905 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:893 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598