====================================================== WARNING: possible circular locking dependency detected 6.1.65-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor328/4245 is trying to acquire lock: ffff0000dc9d00b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 but task is already holding lock: ffff0000dc0a1548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_create_cat+0x18c/0x1330 fs/hfsplus/catalog.c:272 hfsplus_symlink+0x118/0x224 fs/hfsplus/dir.c:453 vfs_symlink+0x244/0x3a8 fs/namei.c:4402 do_symlinkat+0x1bc/0x45c fs/namei.c:4431 __do_sys_symlinkat fs/namei.c:4448 [inline] __se_sys_symlinkat fs/namei.c:4445 [inline] __arm64_sys_symlinkat+0xa4/0xbc fs/namei.c:4445 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&tree->tree_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x508 fs/namei.c:4253 do_unlinkat+0x4c8/0x708 fs/namei.c:4321 __do_sys_unlinkat fs/namei.c:4364 [inline] __se_sys_unlinkat fs/namei.c:4357 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4357 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); *** DEADLOCK *** 5 locks held by syz-executor328/4245: #0: ffff0000dcb64460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000dc0a1080 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #1: ffff0000dc0a1080 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_unlinkat+0x2cc/0x708 fs/namei.c:4304 #2: ffff0000dc0a1740 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #2: ffff0000dc0a1740 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: vfs_unlink+0xd8/0x508 fs/namei.c:4242 #3: ffff0000c4f19198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x144/0x6a0 fs/hfsplus/dir.c:370 #4: ffff0000dc0a1548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 4245 Comm: syz-executor328 Not tainted 6.1.65-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x508 fs/namei.c:4253 do_unlinkat+0x4c8/0x708 fs/namei.c:4321 __do_sys_unlinkat fs/namei.c:4364 [inline] __se_sys_unlinkat fs/namei.c:4357 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4357 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585