====================================================== WARNING: possible circular locking dependency detected 6.1.42-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/15120 is trying to acquire lock: ffff0001282de0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc but task is already holding lock: ffff0000dbefcb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x1e8/0x4ac fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x84/0xa84 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x390/0x14cc fs/hfsplus/extents.c:461 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245 __block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991 __block_write_begin fs/buffer.c:2041 [inline] block_write_begin fs/buffer.c:2102 [inline] cont_write_begin+0x5c0/0x7d8 fs/buffer.c:2456 hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52 generic_perform_write+0x278/0x55c mm/filemap.c:3754 __generic_file_write_iter+0x168/0x388 mm/filemap.c:3882 generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:3914 call_write_iter include/linux/fs.h:2205 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x914 fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #0 (&tree->tree_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_find_init+0x144/0x1bc hfsplus_file_truncate+0x348/0x9b8 fs/hfsplus/extents.c:582 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x508 fs/namei.c:4252 do_unlinkat+0x4c8/0x82c fs/namei.c:4320 __do_sys_unlinkat fs/namei.c:4363 [inline] __se_sys_unlinkat fs/namei.c:4356 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4356 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock/1); *** DEADLOCK *** 5 locks held by syz-executor.5/15120: #0: ffff0001282da460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000dbefc680 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #1: ffff0000dbefc680 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: do_unlinkat+0x2cc/0x82c fs/namei.c:4303 #2: ffff0000dbefcd40 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #2: ffff0000dbefcd40 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: vfs_unlink+0xd8/0x508 fs/namei.c:4241 #3: ffff0000d552d198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x144/0x6a0 fs/hfsplus/dir.c:370 #4: ffff0000dbefcb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 15120 Comm: syz-executor.5 Not tainted 6.1.42-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_find_init+0x144/0x1bc hfsplus_file_truncate+0x348/0x9b8 fs/hfsplus/extents.c:582 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x508 fs/namei.c:4252 do_unlinkat+0x4c8/0x82c fs/namei.c:4320 __do_sys_unlinkat fs/namei.c:4363 [inline] __se_sys_unlinkat fs/namei.c:4356 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4356 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581