====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/4809 is trying to acquire lock: 00000000b67cce58 (&mm->mmap_sem){++++}, at: __might_fault+0xef/0x1d0 mm/memory.c:4771 but task is already holding lock: 0000000045830e0e (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #7 (&tree->tree_lock){+.+.}: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #6 (&HFSPLUS_I(inode)->extents_lock){+.+.}: hfsplus_ext_write_extent+0x7e/0x1f0 fs/hfsplus/extents.c:149 hfsplus_write_inode+0x1e/0x4b0 fs/hfsplus/super.c:153 write_inode fs/fs-writeback.c:1244 [inline] __writeback_single_inode+0x733/0x11d0 fs/fs-writeback.c:1442 writeback_sb_inodes+0x537/0xef0 fs/fs-writeback.c:1647 wb_writeback+0x28d/0xcc0 fs/fs-writeback.c:1820 wb_do_writeback fs/fs-writeback.c:1965 [inline] wb_workfn+0x29b/0x1250 fs/fs-writeback.c:2006 process_one_work+0x864/0x1570 kernel/workqueue.c:2153 worker_thread+0x64c/0x1130 kernel/workqueue.c:2296 kthread+0x33f/0x460 kernel/kthread.c:259 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415 -> #5 ((work_completion)(&(&wb->dwork)->work)){+.+.}: wb_shutdown+0x172/0x210 mm/backing-dev.c:374 bdi_unregister+0x169/0x610 mm/backing-dev.c:946 del_gendisk+0x7f6/0xa80 block/genhd.c:788 loop_remove drivers/block/loop.c:2066 [inline] loop_control_ioctl drivers/block/loop.c:2165 [inline] loop_control_ioctl+0x3b1/0x480 drivers/block/loop.c:2131 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:501 [inline] do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705 __do_sys_ioctl fs/ioctl.c:712 [inline] __se_sys_ioctl fs/ioctl.c:710 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #4 (loop_ctl_mutex){+.+.}: lo_open+0x19/0xd0 drivers/block/loop.c:1771 __blkdev_get+0x372/0x1480 fs/block_dev.c:1494 blkdev_get+0xb0/0x940 fs/block_dev.c:1627 blkdev_open+0x202/0x290 fs/block_dev.c:1788 do_dentry_open+0x4aa/0x1160 fs/open.c:796 do_last fs/namei.c:3421 [inline] path_openat+0x793/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #3 (&bdev->bd_mutex){+.+.}: blkdev_put+0x30/0x520 fs/block_dev.c:1839 btrfs_close_bdev fs/btrfs/volumes.c:1033 [inline] btrfs_close_one_device fs/btrfs/volumes.c:1057 [inline] close_fs_devices.part.0+0x24d/0x8e0 fs/btrfs/volumes.c:1085 close_fs_devices fs/btrfs/volumes.c:1117 [inline] btrfs_close_devices+0x95/0x1f0 fs/btrfs/volumes.c:1103 open_ctree+0x26b/0x61e0 fs/btrfs/disk-io.c:3326 btrfs_fill_super fs/btrfs/super.c:1209 [inline] btrfs_mount_root+0x12e5/0x1830 fs/btrfs/super.c:1613 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount+0x3c/0x60 fs/namespace.c:951 btrfs_mount+0x23a/0xaa0 fs/btrfs/super.c:1681 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount fs/namespace.c:951 [inline] do_new_mount fs/namespace.c:2492 [inline] do_mount+0x115c/0x2f50 fs/namespace.c:2822 ksys_mount+0xcf/0x130 fs/namespace.c:3038 __do_sys_mount fs/namespace.c:3052 [inline] __se_sys_mount fs/namespace.c:3049 [inline] __x64_sys_mount+0xba/0x150 fs/namespace.c:3049 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #2 (&fs_devs->device_list_mutex){+.+.}: btrfs_finish_chunk_alloc+0x27b/0xf90 fs/btrfs/volumes.c:4938 btrfs_create_pending_block_groups+0x242/0x590 fs/btrfs/extent-tree.c:10134 __btrfs_end_transaction+0x21a/0xb00 fs/btrfs/transaction.c:855 flush_space+0xa41/0xee0 fs/btrfs/extent-tree.c:4861 btrfs_async_reclaim_metadata_space+0x466/0x1050 fs/btrfs/extent-tree.c:4977 process_one_work+0x864/0x1570 kernel/workqueue.c:2153 worker_thread+0x64c/0x1130 kernel/workqueue.c:2296 kthread+0x33f/0x460 kernel/kthread.c:259 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415 -> #1 (sb_internal#3){.+.+}: sb_start_intwrite include/linux/fs.h:1626 [inline] start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528 btrfs_dirty_inode+0xe3/0x210 fs/btrfs/inode.c:6165 btrfs_update_time+0x33b/0x3d0 fs/btrfs/inode.c:6207 update_time fs/inode.c:1675 [inline] touch_atime+0x23c/0x2a0 fs/inode.c:1746 file_accessed include/linux/fs.h:2123 [inline] btrfs_file_mmap+0x11b/0x160 fs/btrfs/file.c:2274 call_mmap include/linux/fs.h:1826 [inline] mmap_region+0xc94/0x16b0 mm/mmap.c:1757 do_mmap+0x8e8/0x1080 mm/mmap.c:1530 do_mmap_pgoff include/linux/mm.h:2329 [inline] vm_mmap_pgoff+0x197/0x200 mm/util.c:357 ksys_mmap_pgoff+0x298/0x5a0 mm/mmap.c:1580 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&mm->mmap_sem){++++}: __might_fault mm/memory.c:4772 [inline] __might_fault+0x152/0x1d0 mm/memory.c:4757 _copy_to_user+0x29/0x100 lib/usercopy.c:25 copy_to_user include/linux/uaccess.h:155 [inline] filldir64+0x26e/0x430 fs/readdir.c:324 dir_emit_dot include/linux/fs.h:3432 [inline] hfsplus_readdir+0x3c2/0xf20 fs/hfsplus/dir.c:159 iterate_dir+0x473/0x5c0 fs/readdir.c:51 ksys_getdents64+0x175/0x2b0 fs/readdir.c:357 __do_sys_getdents64 fs/readdir.c:376 [inline] __se_sys_getdents64 fs/readdir.c:373 [inline] __x64_sys_getdents64+0x6f/0xb0 fs/readdir.c:373 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: &mm->mmap_sem --> &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&mm->mmap_sem); *** DEADLOCK *** 3 locks held by syz-executor.0/4809: #0: 000000001b9e7fac (&f->f_pos_lock){+.+.}, at: __fdget_pos+0x26f/0x310 fs/file.c:767 #1: 000000009303f0db (&type->i_mutex_dir_key#9){++++}, at: iterate_dir+0xd2/0x5c0 fs/readdir.c:41 #2: 0000000045830e0e (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 1 PID: 4809 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __might_fault mm/memory.c:4772 [inline] __might_fault+0x152/0x1d0 mm/memory.c:4757 _copy_to_user+0x29/0x100 lib/usercopy.c:25 copy_to_user include/linux/uaccess.h:155 [inline] filldir64+0x26e/0x430 fs/readdir.c:324 dir_emit_dot include/linux/fs.h:3432 [inline] hfsplus_readdir+0x3c2/0xf20 fs/hfsplus/dir.c:159 iterate_dir+0x473/0x5c0 fs/readdir.c:51 ksys_getdents64+0x175/0x2b0 fs/readdir.c:357 __do_sys_getdents64 fs/readdir.c:376 [inline] __se_sys_getdents64 fs/readdir.c:373 [inline] __x64_sys_getdents64+0x6f/0xb0 fs/readdir.c:373 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f8d4bc2c0c9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f8d4a19e168 EFLAGS: 00000246 ORIG_RAX: 00000000000000d9 RAX: ffffffffffffffda RBX: 00007f8d4bd4bf80 RCX: 00007f8d4bc2c0c9 RDX: 0000000000000074 RSI: 0000000020000000 RDI: 0000000000000004 RBP: 00007f8d4bc87ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffec5cbeaaf R14: 00007f8d4a19e300 R15: 0000000000022000 BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents EXT4-fs (loop1): mounted filesystem without journal. Opts: ,errors=continue overlayfs: failed to resolve './file0': -2 BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents 9pnet: Insufficient options for proto=fd BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd BTRFS info (device loop4): using free space tree 9pnet: Insufficient options for proto=fd BTRFS info (device loop4): has skinny extents XFS (loop1): Superblock has unknown read-only compatible features (0x8) enabled. XFS (loop1): Attempted to mount read-only compatible filesystem read-write. XFS (loop1): Filesystem can only be safely mounted read only. XFS (loop1): SB validate failed with error -22. x_tables: duplicate underflow at hook 3 BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents XFS (loop1): Superblock has unknown read-only compatible features (0x8) enabled. XFS (loop1): Attempted to mount read-only compatible filesystem read-write. XFS (loop1): Filesystem can only be safely mounted read only. XFS (loop1): SB validate failed with error -22. BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents XFS (loop1): Superblock has unknown read-only compatible features (0x8) enabled. XFS (loop1): Attempted to mount read-only compatible filesystem read-write. XFS (loop1): Filesystem can only be safely mounted read only. XFS (loop1): SB validate failed with error -22. BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents XFS (loop1): Superblock has unknown read-only compatible features (0x8) enabled. XFS (loop1): Attempted to mount read-only compatible filesystem read-write. XFS (loop1): Filesystem can only be safely mounted read only. XFS (loop1): SB validate failed with error -22. BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents