====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc1-syzkaller-00104-gd8ec19857b09 #0 Not tainted ------------------------------------------------------ syz-executor.4/14685 is trying to acquire lock: ffff888052976098 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:153 but task is already holding lock: ffff8880247c80b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&tree->tree_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_file_truncate+0x811/0xb50 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1ce/0x280 fs/hfsplus/inode.c:265 notify_change+0xb9f/0xe70 fs/attr.c:497 do_truncate fs/open.c:65 [inline] do_ftruncate+0x46b/0x590 fs/open.c:181 do_sys_ftruncate fs/open.c:199 [inline] __do_sys_ftruncate fs/open.c:207 [inline] __se_sys_ftruncate fs/open.c:205 [inline] __x64_sys_ftruncate+0x95/0xf0 fs/open.c:205 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&hip->extents_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14f0 fs/hfsplus/extents.c:260 block_read_full_folio+0x430/0xe10 fs/buffer.c:2407 read_pages+0x5fb/0x840 mm/readahead.c:180 page_cache_ra_unbounded+0x6ce/0x7f0 mm/readahead.c:273 do_sync_mmap_readahead+0x49c/0x970 filemap_fault+0x828/0x1760 mm/filemap.c:3313 __do_fault+0x137/0x460 mm/memory.c:4562 do_read_fault mm/memory.c:4926 [inline] do_fault mm/memory.c:5056 [inline] do_pte_missing mm/memory.c:3903 [inline] handle_pte_fault+0x3d8d/0x7130 mm/memory.c:5380 __handle_mm_fault mm/memory.c:5523 [inline] handle_mm_fault+0x10df/0x1ba0 mm/memory.c:5688 do_user_addr_fault arch/x86/mm/fault.c:1338 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x459/0x8c0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 -> #1 (mapping.invalidate_lock#11){.+.+}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:846 [inline] filemap_fault+0x658/0x1760 mm/filemap.c:3301 __do_fault+0x137/0x460 mm/memory.c:4562 do_read_fault mm/memory.c:4926 [inline] do_fault mm/memory.c:5056 [inline] do_pte_missing mm/memory.c:3903 [inline] handle_pte_fault+0x3d8d/0x7130 mm/memory.c:5380 __handle_mm_fault mm/memory.c:5523 [inline] handle_mm_fault+0x10df/0x1ba0 mm/memory.c:5688 do_user_addr_fault arch/x86/mm/fault.c:1389 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x2b9/0x8c0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 strncpy_from_user+0x110/0x2f0 lib/strncpy_from_user.c:139 getname_flags+0xfa/0x4f0 fs/namei.c:150 do_sys_openat2+0xd2/0x1d0 fs/open.c:1399 do_sys_open fs/open.c:1420 [inline] __do_sys_creat fs/open.c:1496 [inline] __se_sys_creat fs/open.c:1490 [inline] __x64_sys_creat+0x123/0x170 fs/open.c:1490 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read_killable+0xca/0xd30 kernel/locking/rwsem.c:1549 mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:153 get_mmap_lock_carefully mm/memory.c:5724 [inline] lock_mm_and_find_vma+0x29c/0x2f0 mm/memory.c:5775 do_user_addr_fault arch/x86/mm/fault.c:1361 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x1bf/0x8c0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 filldir+0x2c0/0x6a0 fs/readdir.c:294 dir_emit include/linux/fs.h:3567 [inline] hfsplus_readdir+0xcd7/0x1320 fs/hfsplus/dir.c:248 iterate_dir+0x660/0x820 fs/readdir.c:110 __do_sys_getdents fs/readdir.c:326 [inline] __se_sys_getdents+0x1ef/0x4d0 fs/readdir.c:311 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &hip->extents_lock --> &tree->tree_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&hip->extents_lock); lock(&tree->tree_lock); rlock(&mm->mmap_lock); *** DEADLOCK *** 3 locks held by syz-executor.4/14685: #0: ffff88807cc18fc8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x24e/0x310 fs/file.c:1191 #1: ffff88805aa19080 (&type->i_mutex_dir_key#14){++++}-{3:3}, at: iterate_dir+0x55b/0x820 fs/readdir.c:103 #2: ffff8880247c80b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 stack backtrace: CPU: 0 PID: 14685 Comm: syz-executor.4 Not tainted 6.10.0-rc1-syzkaller-00104-gd8ec19857b09 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read_killable+0xca/0xd30 kernel/locking/rwsem.c:1549 mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:153 get_mmap_lock_carefully mm/memory.c:5724 [inline] lock_mm_and_find_vma+0x29c/0x2f0 mm/memory.c:5775 do_user_addr_fault arch/x86/mm/fault.c:1361 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x1bf/0x8c0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 RIP: 0010:filldir+0x2c0/0x6a0 fs/readdir.c:295 Code: 82 55 02 00 00 0f 01 cb 0f ae e8 48 8b 44 24 30 48 89 43 08 48 8b 4c 24 10 48 8b 44 24 60 48 89 01 48 8b 44 24 18 8b 6c 24 3c <66> 89 41 10 48 98 40 88 6c 01 ff 48 89 44 24 30 4d 63 f5 42 c6 44 RSP: 0018:ffffc9000bb37880 EFLAGS: 00050212 RAX: 0000000000000020 RBX: 0000000020001fd8 RCX: 0000000020001ff0 RDX: ffffc90009c0a000 RSI: 0000000020001fd8 RDI: 0000000020002010 RBP: 0000000000000008 R08: ffffffff82125c79 R09: 1ffff11005316000 R10: dffffc0000000000 R11: ffffed1005316001 R12: ffff88802c54d000 R13: 0000000000000009 R14: 0000000020002010 R15: 0000000020002010 dir_emit include/linux/fs.h:3567 [inline] hfsplus_readdir+0xcd7/0x1320 fs/hfsplus/dir.c:248 iterate_dir+0x660/0x820 fs/readdir.c:110 __do_sys_getdents fs/readdir.c:326 [inline] __se_sys_getdents+0x1ef/0x4d0 fs/readdir.c:311 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f363ea7cee9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f363e5ff0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000004e RAX: ffffffffffffffda RBX: 00007f363ebb3fa0 RCX: 00007f363ea7cee9 RDX: 00000000000000b8 RSI: 0000000020001fc0 RDI: 0000000000000004 RBP: 00007f363eac947f R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f363ebb3fa0 R15: 00007ffc1fd603a8 ---------------- Code disassembly (best guess), 1 bytes skipped: 0: 55 push %rbp 1: 02 00 add (%rax),%al 3: 00 0f add %cl,(%rdi) 5: 01 cb add %ecx,%ebx 7: 0f ae e8 lfence a: 48 8b 44 24 30 mov 0x30(%rsp),%rax f: 48 89 43 08 mov %rax,0x8(%rbx) 13: 48 8b 4c 24 10 mov 0x10(%rsp),%rcx 18: 48 8b 44 24 60 mov 0x60(%rsp),%rax 1d: 48 89 01 mov %rax,(%rcx) 20: 48 8b 44 24 18 mov 0x18(%rsp),%rax 25: 8b 6c 24 3c mov 0x3c(%rsp),%ebp * 29: 66 89 41 10 mov %ax,0x10(%rcx) <-- trapping instruction 2d: 48 98 cltq 2f: 40 88 6c 01 ff mov %bpl,-0x1(%rcx,%rax,1) 34: 48 89 44 24 30 mov %rax,0x30(%rsp) 39: 4d 63 f5 movslq %r13d,%r14 3c: 42 rex.X 3d: c6 .byte 0xc6 3e: 44 rex.R