====================================================== WARNING: possible circular locking dependency detected 5.15.157-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/6087 is trying to acquire lock: ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline] ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338 but task is already holding lock: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}: down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] open_xa_root fs/reiserfs/xattr.c:127 [inline] open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152 lookup_and_delete_xattr fs/reiserfs/xattr.c:489 [inline] reiserfs_xattr_set_handle+0x108/0xc10 fs/reiserfs/xattr.c:536 reiserfs_xattr_set+0x398/0x4b0 fs/reiserfs/xattr.c:640 trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31 __vfs_removexattr+0x370/0x38c fs/xattr.c:470 __vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505 vfs_removexattr+0xe0/0x23c fs/xattr.c:527 removexattr fs/xattr.c:857 [inline] path_removexattr+0x1ec/0x2ec fs/xattr.c:871 __do_sys_lremovexattr fs/xattr.c:891 [inline] __se_sys_lremovexattr fs/xattr.c:888 [inline] __arm64_sys_lremovexattr+0x60/0x78 fs/xattr.c:888 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&type->i_mutex_dir_key#17){+.+.}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] vfs_rename+0x68c/0xe04 fs/namei.c:4797 do_renameat2+0xa00/0x10c0 fs/namei.c:4985 __do_sys_renameat2 fs/namei.c:5018 [inline] __se_sys_renameat2 fs/namei.c:5015 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] xattr_rmdir fs/reiserfs/xattr.c:106 [inline] delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338 reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311 reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53 evict+0x260/0x68c fs/inode.c:587 iput_final fs/inode.c:1705 [inline] iput+0x744/0x824 fs/inode.c:1731 dentry_unlink_inode+0x370/0x4b0 fs/dcache.c:376 __dentry_kill+0x324/0x5e4 fs/dcache.c:582 dentry_kill+0xc8/0x250 dput+0x21c/0x458 fs/dcache.c:889 path_put+0x3c/0x68 fs/namei.c:559 path_setxattr+0x1a0/0x258 fs/xattr.c:634 __do_sys_lsetxattr fs/xattr.c:653 [inline] __se_sys_lsetxattr fs/xattr.c:649 [inline] __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &type->i_mutex_dir_key#17/2 --> &type->i_mutex_dir_key#17 --> &type->i_mutex_dir_key#17/3 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#17/3); lock(&type->i_mutex_dir_key#17); lock(&type->i_mutex_dir_key#17/3); lock(&type->i_mutex_dir_key#17/2); *** DEADLOCK *** 1 lock held by syz-executor.1/6087: #0: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #0: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309 stack backtrace: CPU: 1 PID: 6087 Comm: syz-executor.1 Not tainted 5.15.157-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] xattr_rmdir fs/reiserfs/xattr.c:106 [inline] delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338 reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311 reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53 evict+0x260/0x68c fs/inode.c:587 iput_final fs/inode.c:1705 [inline] iput+0x744/0x824 fs/inode.c:1731 dentry_unlink_inode+0x370/0x4b0 fs/dcache.c:376 __dentry_kill+0x324/0x5e4 fs/dcache.c:582 dentry_kill+0xc8/0x250 dput+0x21c/0x458 fs/dcache.c:889 path_put+0x3c/0x68 fs/namei.c:559 path_setxattr+0x1a0/0x258 fs/xattr.c:634 __do_sys_lsetxattr fs/xattr.c:653 [inline] __se_sys_lsetxattr fs/xattr.c:649 [inline] __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584