===================================================== WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected 5.6.0-syzkaller #0 Not tainted ----------------------------------------------------- syz-executor.3/8556 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: ffff888087fa26b8 (&info->lock){....}-{2:2}, at: shmem_uncharge+0x1f/0x230 mm/shmem.c:341 and this task is already holding: ffff888087fa2a08 (&xa->xa_lock#4){..-.}-{2:2}, at: spin_lock include/linux/spinlock.h:353 [inline] ffff888087fa2a08 (&xa->xa_lock#4){..-.}-{2:2}, at: split_huge_page_to_list+0x6ff/0x2690 mm/huge_memory.c:2864 which would create a new lock dependency: (&xa->xa_lock#4){..-.}-{2:2} -> (&info->lock){....}-{2:2} but this new dependency connects a SOFTIRQ-irq-safe lock: (&xa->xa_lock#4){..-.}-{2:2} ... which became SOFTIRQ-irq-safe at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x95/0xc0 kernel/locking/spinlock.c:159 test_clear_page_writeback+0x18f/0xd50 mm/page-writeback.c:2728 end_page_writeback+0x17d/0x350 mm/filemap.c:1317 end_bio_bh_io_sync+0xb4/0x100 fs/buffer.c:3012 req_bio_endio block/blk-core.c:245 [inline] blk_update_request+0x294/0xa60 block/blk-core.c:1472 scsi_end_request+0x77/0x5e0 drivers/scsi/scsi_lib.c:575 scsi_io_completion+0x1a0/0xfc0 drivers/scsi/scsi_lib.c:959 blk_done_softirq+0x2b1/0x400 block/blk-softirq.c:37 __do_softirq+0x26e/0xa0c kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x191/0x1d0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:546 [inline] do_IRQ+0xd9/0x260 arch/x86/kernel/irq.c:263 ret_from_intr+0x0/0x2b tomoyo_path_matches_pattern+0x60/0x260 security/tomoyo/util.c:923 tomoyo_compare_name_union+0x58/0xa0 security/tomoyo/file.c:87 tomoyo_check_path_acl+0x94/0x100 security/tomoyo/file.c:260 tomoyo_check_acl+0xf7/0x330 security/tomoyo/domain.c:175 tomoyo_path_permission+0x1e1/0x340 security/tomoyo/file.c:586 tomoyo_path_perm+0x2a2/0x370 security/tomoyo/file.c:838 security_inode_getattr+0xab/0x100 security/security.c:1273 vfs_getattr+0x17/0x40 fs/stat.c:117 vfs_statx_fd+0x3f/0x80 fs/stat.c:147 vfs_fstat include/linux/fs.h:3295 [inline] __do_sys_newfstat+0x6b/0xc0 fs/stat.c:388 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 to a SOFTIRQ-irq-unsafe lock: (shmlock_user_lock){+.+.}-{2:2} ... which became SOFTIRQ-irq-unsafe at: ... lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] user_shm_lock+0x94/0x180 mm/mlock.c:855 hugetlb_file_setup+0x431/0x59d fs/hugetlbfs/inode.c:1416 newseg+0x383/0xc30 ipc/shm.c:652 ipcget_new ipc/util.c:344 [inline] ipcget+0xed/0xb40 ipc/util.c:643 ksys_shmget ipc/shm.c:742 [inline] __do_sys_shmget ipc/shm.c:747 [inline] __se_sys_shmget ipc/shm.c:745 [inline] __x64_sys_shmget+0x133/0x1a0 ipc/shm.c:745 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 other info that might help us debug this: Chain exists of: &xa->xa_lock#4 --> &info->lock --> shmlock_user_lock Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(shmlock_user_lock); local_irq_disable(); lock(&xa->xa_lock#4); lock(&info->lock); lock(&xa->xa_lock#4); *** DEADLOCK *** 5 locks held by syz-executor.3/8556: #0: ffff88809044e450 (sb_writers#7){.+.+}-{0:0}, at: sb_start_write include/linux/fs.h:1655 [inline] #0: ffff88809044e450 (sb_writers#7){.+.+}-{0:0}, at: do_sys_ftruncate+0x1e6/0x430 fs/open.c:190 #1: ffff888087fa2910 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:797 [inline] #1: ffff888087fa2910 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: do_truncate+0xcb/0x180 fs/open.c:62 #2: ffff888087fa2ad0 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: i_mmap_lock_read include/linux/fs.h:541 [inline] #2: ffff888087fa2ad0 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: split_huge_page_to_list+0x389/0x2690 mm/huge_memory.c:2825 #3: ffff88812ffffcd8 (&pgdat->lru_lock){....}-{2:2}, at: split_huge_page_to_list+0x59a/0x2690 mm/huge_memory.c:2855 #4: ffff888087fa2a08 (&xa->xa_lock#4){..-.}-{2:2}, at: spin_lock include/linux/spinlock.h:353 [inline] #4: ffff888087fa2a08 (&xa->xa_lock#4){..-.}-{2:2}, at: split_huge_page_to_list+0x6ff/0x2690 mm/huge_memory.c:2864 the dependencies between SOFTIRQ-irq-safe lock and the holding lock: -> (&xa->xa_lock#4){..-.}-{2:2} { IN-SOFTIRQ-W at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x95/0xc0 kernel/locking/spinlock.c:159 test_clear_page_writeback+0x18f/0xd50 mm/page-writeback.c:2728 end_page_writeback+0x17d/0x350 mm/filemap.c:1317 end_bio_bh_io_sync+0xb4/0x100 fs/buffer.c:3012 req_bio_endio block/blk-core.c:245 [inline] blk_update_request+0x294/0xa60 block/blk-core.c:1472 scsi_end_request+0x77/0x5e0 drivers/scsi/scsi_lib.c:575 scsi_io_completion+0x1a0/0xfc0 drivers/scsi/scsi_lib.c:959 blk_done_softirq+0x2b1/0x400 block/blk-softirq.c:37 __do_softirq+0x26e/0xa0c kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x191/0x1d0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:546 [inline] do_IRQ+0xd9/0x260 arch/x86/kernel/irq.c:263 ret_from_intr+0x0/0x2b tomoyo_path_matches_pattern+0x60/0x260 security/tomoyo/util.c:923 tomoyo_compare_name_union+0x58/0xa0 security/tomoyo/file.c:87 tomoyo_check_path_acl+0x94/0x100 security/tomoyo/file.c:260 tomoyo_check_acl+0xf7/0x330 security/tomoyo/domain.c:175 tomoyo_path_permission+0x1e1/0x340 security/tomoyo/file.c:586 tomoyo_path_perm+0x2a2/0x370 security/tomoyo/file.c:838 security_inode_getattr+0xab/0x100 security/security.c:1273 vfs_getattr+0x17/0x40 fs/stat.c:117 vfs_statx_fd+0x3f/0x80 fs/stat.c:147 vfs_fstat include/linux/fs.h:3295 [inline] __do_sys_newfstat+0x6b/0xc0 fs/stat.c:388 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 INITIAL USE at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0x5e/0x80 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:378 [inline] __add_to_page_cache_locked+0x4f0/0x9f0 mm/filemap.c:855 add_to_page_cache_lru+0x136/0x490 mm/filemap.c:921 do_read_cache_page+0x2f9/0xaa0 mm/filemap.c:2755 read_mapping_page include/linux/pagemap.h:397 [inline] read_part_sector+0xd8/0x486 block/partitions/core.c:643 adfspart_check_ICS+0x92/0xb30 block/partitions/acorn.c:360 check_partition block/partitions/core.c:140 [inline] blk_add_partitions+0x396/0xc80 block/partitions/core.c:571 bdev_disk_changed+0x175/0x290 fs/block_dev.c:1544 __blkdev_get+0x8dd/0x1180 fs/block_dev.c:1647 register_disk block/genhd.c:763 [inline] __device_add_disk+0xc49/0xf60 block/genhd.c:853 add_disk include/linux/genhd.h:294 [inline] brd_init+0x206/0x392 drivers/block/brd.c:533 do_one_initcall+0xc3/0x580 init/main.c:1158 do_initcall_level init/main.c:1231 [inline] do_initcalls init/main.c:1247 [inline] do_basic_setup init/main.c:1267 [inline] kernel_init_freeable+0x48b/0x4ff init/main.c:1451 kernel_init+0x7/0x102 init/main.c:1358 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 } ... key at: [] __key.18058+0x0/0x40 ... acquired at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x95/0xc0 kernel/locking/spinlock.c:159 shmem_uncharge+0x1f/0x230 mm/shmem.c:341 __split_huge_page mm/huge_memory.c:2613 [inline] split_huge_page_to_list+0x1b95/0x2690 mm/huge_memory.c:2886 split_huge_page include/linux/huge_mm.h:204 [inline] shmem_punch_compound+0xcf/0x130 mm/shmem.c:814 shmem_undo_range+0x597/0x1370 mm/shmem.c:870 shmem_truncate_range+0xf/0x80 mm/shmem.c:980 shmem_setattr+0x70e/0xc20 mm/shmem.c:1039 notify_change+0x72f/0xd00 fs/attr.c:336 do_truncate+0xda/0x180 fs/open.c:64 do_sys_ftruncate+0x325/0x430 fs/open.c:195 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 the dependencies between the lock to be acquired and SOFTIRQ-irq-unsafe lock: -> (shmlock_user_lock){+.+.}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] user_shm_lock+0x94/0x180 mm/mlock.c:855 hugetlb_file_setup+0x431/0x59d fs/hugetlbfs/inode.c:1416 newseg+0x383/0xc30 ipc/shm.c:652 ipcget_new ipc/util.c:344 [inline] ipcget+0xed/0xb40 ipc/util.c:643 ksys_shmget ipc/shm.c:742 [inline] __do_sys_shmget ipc/shm.c:747 [inline] __se_sys_shmget ipc/shm.c:745 [inline] __x64_sys_shmget+0x133/0x1a0 ipc/shm.c:745 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 SOFTIRQ-ON-W at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] user_shm_lock+0x94/0x180 mm/mlock.c:855 hugetlb_file_setup+0x431/0x59d fs/hugetlbfs/inode.c:1416 newseg+0x383/0xc30 ipc/shm.c:652 ipcget_new ipc/util.c:344 [inline] ipcget+0xed/0xb40 ipc/util.c:643 ksys_shmget ipc/shm.c:742 [inline] __do_sys_shmget ipc/shm.c:747 [inline] __se_sys_shmget ipc/shm.c:745 [inline] __x64_sys_shmget+0x133/0x1a0 ipc/shm.c:745 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 INITIAL USE at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] user_shm_lock+0x94/0x180 mm/mlock.c:855 shmem_lock+0x177/0x260 mm/shmem.c:2184 shmctl_do_lock+0x682/0x830 ipc/shm.c:1111 ksys_shmctl.constprop.18+0x1dc/0x260 ipc/shm.c:1188 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 } ... key at: [] shmlock_user_lock+0x18/0x5c0 ... acquired at: __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] user_shm_lock+0x94/0x180 mm/mlock.c:855 shmem_lock+0x177/0x260 mm/shmem.c:2184 shmctl_do_lock+0x682/0x830 ipc/shm.c:1111 ksys_shmctl.constprop.18+0x1dc/0x260 ipc/shm.c:1188 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 -> (&info->lock){....}-{2:2} { INITIAL USE at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0x5e/0x80 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:378 [inline] shmem_getpage_gfp+0x946/0x1cb0 mm/shmem.c:1882 shmem_getpage mm/shmem.c:154 [inline] shmem_write_begin+0xcf/0x1b0 mm/shmem.c:2483 generic_perform_write+0x253/0x410 mm/filemap.c:3302 __generic_file_write_iter+0x1ff/0x520 mm/filemap.c:3431 generic_file_write_iter+0x328/0x616 mm/filemap.c:3463 call_write_iter include/linux/fs.h:1907 [inline] new_sync_write+0x417/0x6c0 fs/read_write.c:483 vfs_write+0x18b/0x490 fs/read_write.c:558 ksys_write+0xec/0x1c0 fs/read_write.c:611 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 } ... key at: [] __key.56465+0x0/0x40 ... acquired at: lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x95/0xc0 kernel/locking/spinlock.c:159 shmem_uncharge+0x1f/0x230 mm/shmem.c:341 __split_huge_page mm/huge_memory.c:2613 [inline] split_huge_page_to_list+0x1b95/0x2690 mm/huge_memory.c:2886 split_huge_page include/linux/huge_mm.h:204 [inline] shmem_punch_compound+0xcf/0x130 mm/shmem.c:814 shmem_undo_range+0x597/0x1370 mm/shmem.c:870 shmem_truncate_range+0xf/0x80 mm/shmem.c:980 shmem_setattr+0x70e/0xc20 mm/shmem.c:1039 notify_change+0x72f/0xd00 fs/attr.c:336 do_truncate+0xda/0x180 fs/open.c:64 do_sys_ftruncate+0x325/0x430 fs/open.c:195 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 stack backtrace: CPU: 1 PID: 8556 Comm: syz-executor.3 Not tainted 5.6.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x128/0x182 lib/dump_stack.c:118 print_bad_irq_dependency kernel/locking/lockdep.c:2132 [inline] check_irq_usage.cold.63+0x57e/0x6d8 kernel/locking/lockdep.c:2330 check_prev_add kernel/locking/lockdep.c:2519 [inline] check_prevs_add kernel/locking/lockdep.c:2620 [inline] validate_chain kernel/locking/lockdep.c:3237 [inline] __lock_acquire+0x256f/0x3740 kernel/locking/lockdep.c:4344 lock_acquire+0x1e3/0x970 kernel/locking/lockdep.c:4923 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x95/0xc0 kernel/locking/spinlock.c:159 shmem_uncharge+0x1f/0x230 mm/shmem.c:341 __split_huge_page mm/huge_memory.c:2613 [inline] split_huge_page_to_list+0x1b95/0x2690 mm/huge_memory.c:2886 split_huge_page include/linux/huge_mm.h:204 [inline] shmem_punch_compound+0xcf/0x130 mm/shmem.c:814 shmem_undo_range+0x597/0x1370 mm/shmem.c:870 shmem_truncate_range+0xf/0x80 mm/shmem.c:980 shmem_setattr+0x70e/0xc20 mm/shmem.c:1039 notify_change+0x72f/0xd00 fs/attr.c:336 do_truncate+0xda/0x180 fs/open.c:64 do_sys_ftruncate+0x325/0x430 fs/open.c:195 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 RIP: 0033:0x45c889 Code: ad b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fa3d56dac78 EFLAGS: 00000246 ORIG_RAX: 000000000000004d RAX: ffffffffffffffda RBX: 00007fa3d56db6d4 RCX: 000000000045c889 RDX: 0000000000000000 RSI: 00000000000001ff RDI: 0000000000000006 RBP: 000000000076bfa0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff R13: 00000000000000e7 R14: 00000000004c3726 R15: 000000000076bfac