======================================================
WARNING: possible circular locking dependency detected
5.15.182-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor/4175 is trying to acquire lock:
ffff8880595a1138 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: flush_workqueue+0x126/0x1380 kernel/workqueue.c:2830

but task is already holding lock:
ffff8880608de0e0 (&type->s_umount_key#56){++++}-{3:3}, at: deactivate_super+0xa0/0xd0 fs/super.c:365

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&type->s_umount_key#56){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_finish_quota_recovery+0x12b/0x1ea0 fs/ocfs2/quota_local.c:600
       ocfs2_complete_recovery+0x1543/0x20b0 fs/ocfs2/journal.c:1295
       process_one_work+0x863/0x1000 kernel/workqueue.c:2310
       worker_thread+0xaa8/0x12a0 kernel/workqueue.c:2457
       kthread+0x436/0x520 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #1 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}:
       process_one_work+0x7bf/0x1000 kernel/workqueue.c:2286
       worker_thread+0xaa8/0x12a0 kernel/workqueue.c:2457
       kthread+0x436/0x520 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #0 ((wq_completion)ocfs2_wq){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       flush_workqueue+0x142/0x1380 kernel/workqueue.c:2830
       ocfs2_shutdown_local_alloc+0xe4/0xa10 fs/ocfs2/localalloc.c:379
       ocfs2_dismount_volume+0x1d6/0x880 fs/ocfs2/super.c:1882
       generic_shutdown_super+0x130/0x300 fs/super.c:475
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x418/0x4d0 fs/namespace.c:1143
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  (wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work) --> &type->s_umount_key#56

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->s_umount_key#56);
                               lock((work_completion)(&journal->j_recovery_work));
                               lock(&type->s_umount_key#56);
  lock((wq_completion)ocfs2_wq);

 *** DEADLOCK ***

1 lock held by syz-executor/4175:
 #0: ffff8880608de0e0 (&type->s_umount_key#56){++++}-{3:3}, at: deactivate_super+0xa0/0xd0 fs/super.c:365

stack backtrace:
CPU: 1 PID: 4175 Comm: syz-executor Not tainted 5.15.182-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 flush_workqueue+0x142/0x1380 kernel/workqueue.c:2830
 ocfs2_shutdown_local_alloc+0xe4/0xa10 fs/ocfs2/localalloc.c:379
 ocfs2_dismount_volume+0x1d6/0x880 fs/ocfs2/super.c:1882
 generic_shutdown_super+0x130/0x300 fs/super.c:475
 kill_block_super+0x7c/0xe0 fs/super.c:1427
 deactivate_locked_super+0x93/0xf0 fs/super.c:335
 cleanup_mnt+0x418/0x4d0 fs/namespace.c:1143
 task_work_run+0x125/0x1a0 kernel/task_work.c:188
 tracehook_notify_resume include/linux/tracehook.h:189 [inline]
 exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
 syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
 do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fa7ae728c97
Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007ffef6d3b458 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 00007fa7ae7a989d RCX: 00007fa7ae728c97
RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007ffef6d3b510
RBP: 00007ffef6d3b510 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000246 R12: 00007ffef6d3c5a0
R13: 00007fa7ae7a989d R14: 00000000000119d2 R15: 00007ffef6d3c5e0
 </TASK>
ocfs2: Unmounting device (7,4) on (node local)