====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.2.6910/29570 is trying to acquire lock: ffff888056ad3a98 (&ovl_i_mutex_dir_key[depth]){++++}-{4:4}, at: inode_lock_shared include/linux/fs.h:995 [inline] ffff888056ad3a98 (&ovl_i_mutex_dir_key[depth]){++++}-{4:4}, at: lookup_slow fs/namei.c:1832 [inline] ffff888056ad3a98 (&ovl_i_mutex_dir_key[depth]){++++}-{4:4}, at: walk_component+0x345/0x5b0 fs/namei.c:2151 but task is already holding lock: ffff888054feb088 (&of->mutex){+.+.}-{4:4}, at: kernfs_fop_write_iter+0x28f/0x570 fs/kernfs/file.c:343 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&of->mutex){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x193/0x1060 kernel/locking/mutex.c:760 kernfs_fop_write_iter+0x28f/0x570 fs/kernfs/file.c:343 iter_file_splice_write+0xa24/0x12e0 fs/splice.c:738 do_splice_from fs/splice.c:938 [inline] do_splice+0x1478/0x1fc0 fs/splice.c:1351 __do_splice+0x32a/0x360 fs/splice.c:1433 __do_sys_splice fs/splice.c:1636 [inline] __se_sys_splice fs/splice.c:1618 [inline] __x64_sys_splice+0x187/0x250 fs/splice.c:1618 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&pipe->mutex){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x193/0x1060 kernel/locking/mutex.c:760 pipe_lock fs/pipe.c:91 [inline] pipe_lock+0x64/0x80 fs/pipe.c:88 iter_file_splice_write+0x1ea/0x12e0 fs/splice.c:683 do_splice_from fs/splice.c:938 [inline] do_splice+0x1478/0x1fc0 fs/splice.c:1351 __do_splice+0x27d/0x360 fs/splice.c:1433 __do_sys_splice fs/splice.c:1636 [inline] __se_sys_splice fs/splice.c:1618 [inline] __x64_sys_splice+0x187/0x250 fs/splice.c:1618 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (sb_writers#6){.+.+}-{0:0}: percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1916 [inline] sb_start_write include/linux/fs.h:2052 [inline] mnt_want_write+0x6f/0x450 fs/namespace.c:508 ovl_fileattr_set+0x108/0x2c0 fs/overlayfs/inode.c:664 vfs_fileattr_set+0x77c/0xb80 fs/file_attr.c:298 ioctl_setflags+0x1c7/0x200 fs/file_attr.c:334 do_vfs_ioctl+0x120/0x14f0 fs/ioctl.c:560 __do_sys_ioctl fs/ioctl.c:595 [inline] __se_sys_ioctl fs/ioctl.c:583 [inline] __x64_sys_ioctl+0x114/0x210 fs/ioctl.c:583 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ovl_i_mutex_dir_key[depth]){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825 down_read+0x9b/0x480 kernel/locking/rwsem.c:1537 inode_lock_shared include/linux/fs.h:995 [inline] lookup_slow fs/namei.c:1832 [inline] walk_component+0x345/0x5b0 fs/namei.c:2151 lookup_last fs/namei.c:2652 [inline] path_lookupat+0x142/0x6d0 fs/namei.c:2676 filename_lookup+0x224/0x5f0 fs/namei.c:2705 kern_path+0x35/0x50 fs/namei.c:2863 lookup_bdev+0xd8/0x280 block/bdev.c:1205 resume_store+0x1d6/0x460 kernel/power/hibernate.c:1309 kobj_attr_store+0x58/0x80 lib/kobject.c:840 sysfs_kf_write+0xf2/0x150 fs/sysfs/file.c:142 kernfs_fop_write_iter+0x3af/0x570 fs/kernfs/file.c:352 iter_file_splice_write+0xa24/0x12e0 fs/splice.c:738 do_splice_from fs/splice.c:938 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1161 splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105 do_splice_direct_actor fs/splice.c:1204 [inline] do_splice_direct+0x174/0x240 fs/splice.c:1230 do_sendfile+0xb06/0xe50 fs/read_write.c:1370 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64 fs/read_write.c:1417 [inline] __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ovl_i_mutex_dir_key[depth] --> &pipe->mutex --> &of->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&of->mutex); lock(&pipe->mutex); lock(&of->mutex); rlock(&ovl_i_mutex_dir_key[depth]); *** DEADLOCK *** 3 locks held by syz.2.6910/29570: #0: ffff88802c818420 (sb_writers#8){.+.+}-{0:0}, at: splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105 #1: ffff888054feb088 (&of->mutex){+.+.}-{4:4}, at: kernfs_fop_write_iter+0x28f/0x570 fs/kernfs/file.c:343 #2: ffff8881006d5008 (kn->active#66){.+.+}-{0:0}, at: kernfs_get_active_of fs/kernfs/file.c:80 [inline] #2: ffff8881006d5008 (kn->active#66){.+.+}-{0:0}, at: kernfs_fop_write_iter+0x2ff/0x570 fs/kernfs/file.c:344 stack backtrace: CPU: 2 UID: 0 PID: 29570 Comm: syz.2.6910 Not tainted syzkaller #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2043 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825 down_read+0x9b/0x480 kernel/locking/rwsem.c:1537 inode_lock_shared include/linux/fs.h:995 [inline] lookup_slow fs/namei.c:1832 [inline] walk_component+0x345/0x5b0 fs/namei.c:2151 lookup_last fs/namei.c:2652 [inline] path_lookupat+0x142/0x6d0 fs/namei.c:2676 filename_lookup+0x224/0x5f0 fs/namei.c:2705 kern_path+0x35/0x50 fs/namei.c:2863 lookup_bdev+0xd8/0x280 block/bdev.c:1205 resume_store+0x1d6/0x460 kernel/power/hibernate.c:1309 kobj_attr_store+0x58/0x80 lib/kobject.c:840 sysfs_kf_write+0xf2/0x150 fs/sysfs/file.c:142 kernfs_fop_write_iter+0x3af/0x570 fs/kernfs/file.c:352 iter_file_splice_write+0xa24/0x12e0 fs/splice.c:738 do_splice_from fs/splice.c:938 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1161 splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105 do_splice_direct_actor fs/splice.c:1204 [inline] do_splice_direct+0x174/0x240 fs/splice.c:1230 do_sendfile+0xb06/0xe50 fs/read_write.c:1370 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64 fs/read_write.c:1417 [inline] __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe38db8efc9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe38ead4038 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007fe38dde6090 RCX: 00007fe38db8efc9 RDX: 0000000000000000 RSI: 0000000000000009 RDI: 0000000000000009 RBP: 00007fe38dc11f91 R08: 0000000000000000 R09: 0000000000000000 R10: 000000000000000b R11: 0000000000000246 R12: 0000000000000000 R13: 00007fe38dde6128 R14: 00007fe38dde6090 R15: 00007ffc01f3e338 PM: Image not found (code -22)