ip6_tables: ip6tables: counters copy to user failed while replacing table ====================================================== WARNING: possible circular locking dependency detected 4.14.284-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/9641 is trying to acquire lock: (&xt[i].mutex){+.+.}, at: [] target_revfn+0x43/0x210 net/netfilter/x_tables.c:354 but task is already holding lock: (&table[i].mutex){+.+.}, at: [] nfnl_lock net/netfilter/nfnetlink.c:61 [inline] (&table[i].mutex){+.+.}, at: [] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&table[i].mutex){+.+.}: __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122 notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93 call_netdevice_notifiers_info net/core/dev.c:1667 [inline] call_netdevice_notifiers net/core/dev.c:1683 [inline] rollback_registered_many+0x765/0xbb0 net/core/dev.c:7211 rollback_registered+0xca/0x170 net/core/dev.c:7253 unregister_netdevice_queue+0x1b4/0x360 net/core/dev.c:8274 unregister_netdevice include/linux/netdevice.h:2444 [inline] unregister_netdev+0x18/0x20 net/core/dev.c:8315 slcan_close drivers/net/can/slcan.c:659 [inline] slcan_hangup+0x13b/0x1a0 drivers/net/can/slcan.c:665 tty_ldisc_hangup+0x155/0x6c0 drivers/tty/tty_ldisc.c:745 __tty_hangup.part.0+0x31a/0x730 drivers/tty/tty_io.c:622 __tty_hangup drivers/tty/tty_io.c:2600 [inline] tty_vhangup drivers/tty/tty_io.c:695 [inline] tty_ioctl+0x730/0x1430 drivers/tty/tty_io.c:2599 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:500 [inline] do_vfs_ioctl+0x75a/0xff0 fs/ioctl.c:684 SYSC_ioctl fs/ioctl.c:701 [inline] SyS_ioctl+0x7f/0xb0 fs/ioctl.c:692 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #1 (rtnl_mutex){+.+.}: __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630 tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123 cleanup_entry+0x232/0x310 net/ipv6/netfilter/ip6_tables.c:685 __do_replace+0x38d/0x580 net/ipv6/netfilter/ip6_tables.c:1106 do_replace net/ipv6/netfilter/ip6_tables.c:1162 [inline] do_ip6t_set_ctl+0x256/0x3b0 net/ipv6/netfilter/ip6_tables.c:1688 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115 ipv6_setsockopt+0xc0/0x120 net/ipv6/ipv6_sockglue.c:937 tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2830 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x110/0x1e0 net/socket.c:1844 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #0 (&xt[i].mutex){+.+.}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 target_revfn+0x43/0x210 net/netfilter/x_tables.c:354 xt_find_revision+0x15e/0x1d0 net/netfilter/x_tables.c:378 nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678 nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214 netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2454 nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515 netlink_unicast_kernel net/netlink/af_netlink.c:1296 [inline] netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1322 netlink_sendmsg+0x648/0xbc0 net/netlink/af_netlink.c:1893 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xb5/0x100 net/socket.c:656 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062 __sys_sendmsg+0xa3/0x120 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x27/0x40 net/socket.c:2103 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb other info that might help us debug this: Chain exists of: &xt[i].mutex --> rtnl_mutex --> &table[i].mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&table[i].mutex); lock(rtnl_mutex); lock(&table[i].mutex); lock(&xt[i].mutex); *** DEADLOCK *** 1 lock held by syz-executor.1/9641: #0: (&table[i].mutex){+.+.}, at: [] nfnl_lock net/netfilter/nfnetlink.c:61 [inline] #0: (&table[i].mutex){+.+.}, at: [] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209 stack backtrace: CPU: 1 PID: 9641 Comm: syz-executor.1 Not tainted 4.14.284-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 target_revfn+0x43/0x210 net/netfilter/x_tables.c:354 xt_find_revision+0x15e/0x1d0 net/netfilter/x_tables.c:378 nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678 nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214 netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2454 nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515 netlink_unicast_kernel net/netlink/af_netlink.c:1296 [inline] netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1322 netlink_sendmsg+0x648/0xbc0 net/netlink/af_netlink.c:1893 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xb5/0x100 net/socket.c:656 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062 __sys_sendmsg+0xa3/0x120 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x27/0x40 net/socket.c:2103 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb RIP: 0033:0x7fa954b42109 RSP: 002b:00007fa9534b7168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007fa954c54f60 RCX: 00007fa954b42109 RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003 RBP: 00007fa954b9c05d R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd2a80cb1f R14: 00007fa9534b7300 R15: 0000000000022000 ip6_tables: ip6tables: counters copy to user failed while replacing table audit: type=1800 audit(1655458865.162:17): pid=9698 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="file0" dev="loop3" ino=9 res=0 attempt to access beyond end of device loop3: rw=2049, want=128, limit=16 audit: type=1800 audit(1655458865.552:18): pid=9724 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="file0" dev="loop3" ino=10 res=0 attempt to access beyond end of device loop3: rw=2049, want=128, limit=16 audit: type=1800 audit(1655458865.752:19): pid=9750 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="loop2" ino=12 res=0 audit: type=1800 audit(1655458865.812:20): pid=9762 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="file0" dev="loop4" ino=14 res=0 attempt to access beyond end of device loop2: rw=2049, want=128, limit=16 audit: type=1800 audit(1655458865.812:21): pid=9767 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="file0" dev="loop3" ino=13 res=0 attempt to access beyond end of device loop4: rw=2049, want=128, limit=16 attempt to access beyond end of device loop3: rw=2049, want=128, limit=16 audit: type=1800 audit(1655458866.412:22): pid=9798 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="loop2" ino=15 res=0 attempt to access beyond end of device attempt to access beyond end of device loop4: rw=2049, want=128, limit=16 attempt to access beyond end of device loop2: rw=2049, want=128, limit=16 loop3: rw=2049, want=128, limit=16 print_req_error: I/O error, dev loop4, sector 0 print_req_error: I/O error, dev loop3, sector 0 attempt to access beyond end of device loop1: rw=2049, want=128, limit=16 attempt to access beyond end of device loop3: rw=2049, want=128, limit=16 attempt to access beyond end of device attempt to access beyond end of device loop2: rw=2049, want=128, limit=16 loop4: rw=2049, want=128, limit=16 attempt to access beyond end of device loop1: rw=2049, want=128, limit=16 attempt to access beyond end of device loop3: rw=2049, want=128, limit=16 attempt to access beyond end of device loop1: rw=2049, want=128, limit=16 attempt to access beyond end of device netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'. loop3: rw=2049, want=128, limit=16 VFS: could not find a valid V7 on loop1. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'. xt_helper: cannot load conntrack support for proto=10 netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'. kvm: vcpu 0: requested 128 ns lapic timer period limited to 500000 ns kauditd_printk_skb: 10 callbacks suppressed audit: type=1800 audit(1655458872.222:33): pid=10192 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="sda1" ino=13884 res=0 audit: type=1800 audit(1655458873.002:34): pid=10235 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="sda1" ino=14025 res=0 kvm: vcpu 0: requested 128 ns lapic timer period limited to 500000 ns audit: type=1800 audit(1655458873.082:35): pid=10248 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="sda1" ino=13997 res=0