====================================================== WARNING: possible circular locking dependency detected 6.1.122-syzkaller #0 Tainted: G W ------------------------------------------------------ syz.0.1066/7617 is trying to acquire lock: ffff88804fcdea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 but task is already holding lock: ffff88804fcded88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff88804fcded88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:988 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:657 vfs_mkdir+0x3b6/0x590 fs/namei.c:4106 do_mkdirat+0x225/0x360 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6770 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1942 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline] ext4_free_blocks+0x1fb4/0x3020 fs/ext4/mballoc.c:6273 ext4_remove_blocks fs/ext4/extents.c:2525 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline] ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2939 ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4469 ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288 ext4_process_orphan+0x1aa/0x2d0 fs/ext4/orphan.c:339 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5522 [inline] ext4_fill_super+0x83f6/0x8b50 fs/ext4/super.c:5653 get_tree_bdev+0x3fe/0x620 fs/super.c:1366 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x2ba/0xb40 fs/namespace.c:3056 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #4 (&ei->i_data_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ext4_map_blocks+0x955/0x1cb0 fs/ext4/inode.c:671 mpage_map_one_extent fs/ext4/inode.c:2433 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2486 [inline] ext4_writepages+0x1643/0x3de0 fs/ext4/inode.c:2854 do_writepages+0x3a2/0x670 mm/page-writeback.c:2491 __writeback_single_inode+0x15d/0x11e0 fs/fs-writeback.c:1612 writeback_sb_inodes+0xc2b/0x1b20 fs/fs-writeback.c:1903 __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:1974 wb_writeback+0x4b1/0xe10 fs/fs-writeback.c:2079 wb_check_background_flush fs/fs-writeback.c:2145 [inline] wb_do_writeback fs/fs-writeback.c:2233 [inline] wb_workfn+0xc9e/0x1020 fs/fs-writeback.c:2260 process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292 worker_thread+0xa47/0x1200 kernel/workqueue.c:2439 kthread+0x28d/0x320 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354 ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:361 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3780 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352 ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:361 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3780 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (sb_internal#6){.+.+}-{0:0}: reacquire_held_locks+0x3a4/0x660 kernel/locking/lockdep.c:5187 __lock_release kernel/locking/lockdep.c:5376 [inline] lock_release+0x378/0xa20 kernel/locking/lockdep.c:5682 up_write+0x75/0x580 kernel/locking/rwsem.c:1625 inode_unlock include/linux/fs.h:763 [inline] ocfs2_free_ac_resource fs/ocfs2/suballoc.c:126 [inline] ocfs2_free_alloc_context+0x91/0x1a0 fs/ocfs2/suballoc.c:140 ocfs2_write_begin_nolock+0x4d9c/0x4e40 fs/ocfs2/aops.c:1825 ocfs2_dio_wr_get_block+0xc29/0x1920 fs/ocfs2/aops.c:2239 get_more_blocks fs/direct-io.c:665 [inline] do_direct_IO fs/direct-io.c:953 [inline] __blockdev_direct_IO+0x1d00/0x4810 fs/direct-io.c:1266 ocfs2_direct_IO+0x250/0x2c0 fs/ocfs2/aops.c:2468 generic_file_direct_write+0x204/0x460 mm/filemap.c:3769 __generic_file_write_iter+0x1c4/0x400 mm/filemap.c:3929 ocfs2_file_write_iter+0x19d7/0x2280 fs/ocfs2/file.c:2469 do_iter_write+0x6e6/0xc40 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x216/0x360 fs/read_write.c:1031 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:988 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:657 vfs_mkdir+0x3b6/0x590 fs/namei.c:4106 do_mkdirat+0x225/0x360 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&dquot->dq_lock); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); *** DEADLOCK *** 5 locks held by syz.0.1066/7617: #0: ffff8880609a8460 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff88804fcda648 (&type->i_mutex_dir_key#24/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff88804fcda648 (&type->i_mutex_dir_key#24/1){+.+.}-{3:3}, at: filename_create+0x25c/0x530 fs/namei.c:3876 #2: ffff888056773488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff888056773488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x182/0x5190 fs/ocfs2/suballoc.c:782 #3: ffff888074f000a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x2a0/0xb60 fs/ocfs2/quota_global.c:806 #4: ffff88804fcded88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #4: ffff88804fcded88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 stack backtrace: CPU: 0 PID: 7617 Comm: syz.0.1066 Tainted: G W 6.1.122-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:988 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:657 vfs_mkdir+0x3b6/0x590 fs/namei.c:4106 do_mkdirat+0x225/0x360 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f9a59384597 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9a5a11ce68 EFLAGS: 00000246 ORIG_RAX: 0000000000000102 RAX: ffffffffffffffda RBX: 00007f9a5a11cef0 RCX: 00007f9a59384597 RDX: 00000000000001ff RSI: 0000000020000040 RDI: 00000000ffffff9c RBP: 0000000020000140 R08: 0000000020000000 R09: 0000000000000000 R10: 0000000020000140 R11: 0000000000000246 R12: 0000000020000040 R13: 00007f9a5a11ceb0 R14: 0000000000000000 R15: 0000000000000000 (syz.0.1066,7617,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x2c7b5077, computed 0x28030c75. Applying ECC. (syz.0.1066,7617,0):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x2c7b5077, computed 0x28d1d8ae (syz.0.1066,7617,0):ocfs2_read_quota_phys_block:160 ERROR: status = -5 (syz.0.1066,7617,0):ocfs2_quota_read:201 ERROR: status = -5 Quota error (device loop0): find_tree_dqentry: Can't read quota tree block 5 Quota error (device loop0): qtree_read_dquot: Can't read quota structure for id 0 (syz.0.1066,7617,1):ocfs2_acquire_dquot:873 ERROR: status = -5 (syz.0.1066,7617,1):ocfs2_mknod:314 ERROR: status = -5 (syz.0.1066,7617,1):ocfs2_mknod:502 ERROR: status = -5 (syz.0.1066,7617,1):ocfs2_mkdir:659 ERROR: status = -5