====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.3.494/6316 is trying to acquire lock: ffff88805bd16a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb3/0x320 fs/ocfs2/refcounttree.c:932 but task is already holding lock: ffff88805bd16ab8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa1/0x320 fs/ocfs2/refcounttree.c:931 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365 ocfs2_mknod+0x142f/0x22b0 fs/ocfs2/namei.c:410 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376 ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374 ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (sb_internal#4){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1928 [inline] ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372 ocfs2_acquire_dquot+0x677/0xaf0 fs/ocfs2/quota_global.c:848 dqget+0x778/0xeb0 fs/quota/dquot.c:988 __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517 ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x8aa/0x22b0 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_try_remove_refcount_tree+0xb3/0x320 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x592/0x11e0 fs/ocfs2/xattr.c:3673 ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x36f/0x3e0 fs/posix_acl.c:966 __vfs_removexattr+0x3b7/0x3f0 fs/xattr.c:470 __vfs_removexattr_locked+0x1e4/0x230 fs/xattr.c:505 vfs_removexattr+0x7d/0x1b0 fs/xattr.c:527 ovl_do_removexattr fs/overlayfs/overlayfs.h:231 [inline] ovl_workdir_create+0x2ea/0x580 fs/overlayfs/super.c:818 ovl_make_workdir fs/overlayfs/super.c:1376 [inline] ovl_get_workdir+0x352/0x11a0 fs/overlayfs/super.c:1526 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2082 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xe6/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x24a/0xa40 fs/namespace.c:3034 do_mount fs/namespace.c:3377 [inline] __do_sys_mount fs/namespace.c:3585 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3562 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ocfs2_quota_ip_alloc_sem_key --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_quota_ip_alloc_sem_key); *** DEADLOCK *** 5 locks held by syz.3.494/6316: #0: ffff8880250000e0 (&type->s_umount_key#67/1){+.+.}-{3:3}, at: alloc_super+0x201/0x950 fs/super.c:229 #1: ffff8880237fa460 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386 #2: ffff88805bd12648 (&sb->s_type->i_mutex_key#28/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline] #2: ffff88805bd12648 (&sb->s_type->i_mutex_key#28/1){+.+.}-{3:3}, at: ovl_workdir_create+0x127/0x580 fs/overlayfs/super.c:768 #3: ffff88805bd16d88 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #3: ffff88805bd16d88 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: vfs_removexattr+0x69/0x1b0 fs/xattr.c:526 #4: ffff88805bd16ab8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa1/0x320 fs/ocfs2/refcounttree.c:931 stack backtrace: CPU: 1 PID: 6316 Comm: syz.3.494 Not tainted syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025 Call Trace: dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_try_remove_refcount_tree+0xb3/0x320 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x592/0x11e0 fs/ocfs2/xattr.c:3673 ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x36f/0x3e0 fs/posix_acl.c:966 __vfs_removexattr+0x3b7/0x3f0 fs/xattr.c:470 __vfs_removexattr_locked+0x1e4/0x230 fs/xattr.c:505 vfs_removexattr+0x7d/0x1b0 fs/xattr.c:527 ovl_do_removexattr fs/overlayfs/overlayfs.h:231 [inline] ovl_workdir_create+0x2ea/0x580 fs/overlayfs/super.c:818 ovl_make_workdir fs/overlayfs/super.c:1376 [inline] ovl_get_workdir+0x352/0x11a0 fs/overlayfs/super.c:1526 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2082 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xe6/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x24a/0xa40 fs/namespace.c:3034 do_mount fs/namespace.c:3377 [inline] __do_sys_mount fs/namespace.c:3585 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3562 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f1cf405e749 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1cf22c5038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f1cf42b4fa0 RCX: 00007f1cf405e749 RDX: 0000200000000080 RSI: 0000200000000040 RDI: 0000000000000000 RBP: 00007f1cf40e2f91 R08: 0000200000000400 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007f1cf42b5038 R14: 00007f1cf42b4fa0 R15: 00007ffc2fe382d8 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features.