====================================================== WARNING: possible circular locking dependency detected 5.15.145-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/26006 is trying to acquire lock: ffff8881443f20b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 but task is already holding lock: ffff8881443f00b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&tree->tree_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x864/0xb80 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1b9/0x280 fs/hfsplus/inode.c:267 notify_change+0xc6d/0xf50 fs/attr.c:505 do_truncate+0x21c/0x300 fs/open.c:65 vfs_truncate+0x2dd/0x3a0 fs/open.c:111 do_sys_truncate+0xda/0x190 fs/open.c:134 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 do_read_cache_page+0x752/0x1040 read_mapping_page include/linux/pagemap.h:515 [inline] __hfs_bnode_create+0x4f2/0xbb0 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x22e/0xe80 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x17f/0x570 fs/hfsplus/bfind.c:183 __hfsplus_getxattr+0x360/0xb10 fs/hfsplus/xattr.c:522 hfsplus_getxattr+0x98/0xd0 fs/hfsplus/xattr.c:590 vfs_getxattr_alloc+0x449/0x590 fs/xattr.c:374 ima_read_xattr+0x35/0x60 security/integrity/ima/ima_appraise.c:221 process_measurement+0x117d/0x21c0 security/integrity/ima/ima_main.c:333 ima_file_check+0xf3/0x180 security/integrity/ima/ima_main.c:533 do_open fs/namei.c:3616 [inline] path_openat+0x2745/0x2f20 fs/namei.c:3748 do_filp_open+0x21c/0x460 fs/namei.c:3775 do_sys_openat2+0x13b/0x500 fs/open.c:1211 do_sys_open fs/open.c:1227 [inline] __do_sys_openat fs/open.c:1243 [inline] __se_sys_openat fs/open.c:1238 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1238 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&tree->tree_lock/2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_find_init+0x146/0x1c0 hfsplus_delete_all_attrs+0x107/0x3c0 fs/hfsplus/attributes.c:366 hfsplus_delete_cat+0xb83/0xfb0 fs/hfsplus/catalog.c:425 hfsplus_file_release+0x19e/0x3e0 fs/hfsplus/inode.c:238 __fput+0x3bf/0x890 fs/file_table.c:280 task_work_run+0x129/0x1a0 kernel/task_work.c:164 exit_task_work include/linux/task_work.h:32 [inline] do_exit+0x6a3/0x2480 kernel/exit.c:872 do_group_exit+0x144/0x310 kernel/exit.c:994 get_signal+0xc66/0x14e0 kernel/signal.c:2889 arch_do_signal_or_restart+0xc3/0x1890 arch/x86/kernel/signal.c:867 handle_signal_work kernel/entry/common.c:148 [inline] exit_to_user_mode_loop+0x97/0x130 kernel/entry/common.c:172 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:208 irqentry_exit_to_user_mode+0x5/0x40 kernel/entry/common.c:314 exc_general_protection+0x358/0x4f0 arch/x86/kernel/traps.c:562 asm_exc_general_protection+0x22/0x30 arch/x86/include/asm/idtentry.h:562 other info that might help us debug this: Chain exists of: &tree->tree_lock/2 --> &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&tree->tree_lock/2); *** DEADLOCK *** 2 locks held by syz-executor.2/26006: #0: ffff8880772e3900 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #0: ffff8880772e3900 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: hfsplus_file_release+0xeb/0x3e0 fs/hfsplus/inode.c:235 #1: ffff8881443f00b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 stack backtrace: CPU: 0 PID: 26006 Comm: syz-executor.2 Not tainted 5.15.145-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_find_init+0x146/0x1c0 hfsplus_delete_all_attrs+0x107/0x3c0 fs/hfsplus/attributes.c:366 hfsplus_delete_cat+0xb83/0xfb0 fs/hfsplus/catalog.c:425 hfsplus_file_release+0x19e/0x3e0 fs/hfsplus/inode.c:238 __fput+0x3bf/0x890 fs/file_table.c:280 task_work_run+0x129/0x1a0 kernel/task_work.c:164 exit_task_work include/linux/task_work.h:32 [inline] do_exit+0x6a3/0x2480 kernel/exit.c:872 do_group_exit+0x144/0x310 kernel/exit.c:994 get_signal+0xc66/0x14e0 kernel/signal.c:2889 arch_do_signal_or_restart+0xc3/0x1890 arch/x86/kernel/signal.c:867 handle_signal_work kernel/entry/common.c:148 [inline] exit_to_user_mode_loop+0x97/0x130 kernel/entry/common.c:172 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:208 irqentry_exit_to_user_mode+0x5/0x40 kernel/entry/common.c:314 exc_general_protection+0x358/0x4f0 arch/x86/kernel/traps.c:562 asm_exc_general_protection+0x22/0x30 arch/x86/include/asm/idtentry.h:562 RIP: 0033:0x7f6faade1cf1 Code: Unable to access opcode bytes at RIP 0x7f6faade1cc7. RSP: 002b:0000000020000210 EFLAGS: 00010217 RAX: 0000000000000000 RBX: 00007f6faaf00f80 RCX: 00007f6faade1ce9 RDX: 0000000020000040 RSI: 0000000020000210 RDI: 0000000003248000 RBP: 00007f6faae2e47a R08: 0000000020000240 R09: 0000000020000240 R10: 00000000200000c0 R11: 0000000000000206 R12: 0000000000000000 R13: 000000000000000b R14: 00007f6faaf00f80 R15: 00007ffc88c202a8