====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc5-syzkaller-00362-ga785fd28d31f #0 Not tainted ------------------------------------------------------ syz-executor.4/18337 is trying to acquire lock: ffff888022eff8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff88807a377888 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x226/0x1120 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 hfsplus_get_block+0x277/0x9e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x3df/0xae0 fs/buffer.c:2412 filemap_read_folio+0xe5/0x2b0 mm/filemap.c:2389 do_read_cache_folio+0x1ff/0x540 mm/filemap.c:3696 do_read_cache_page mm/filemap.c:3762 [inline] read_cache_page+0x5b/0x180 mm/filemap.c:3771 read_mapping_page include/linux/pagemap.h:776 [inline] hfsplus_block_allocate+0x144/0x990 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x444/0xf90 fs/hfsplus/extents.c:468 hfsplus_get_block+0x1ae/0x9e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x3c0/0x1470 fs/buffer.c:2128 __block_write_begin fs/buffer.c:2178 [inline] block_write_begin+0xb1/0x490 fs/buffer.c:2239 cont_write_begin+0x52f/0x730 fs/buffer.c:2597 hfsplus_write_begin+0x87/0x140 fs/hfsplus/inode.c:52 generic_perform_write+0x278/0x600 mm/filemap.c:3923 __generic_file_write_iter+0x1f9/0x240 mm/filemap.c:4018 generic_file_write_iter+0xe3/0x350 mm/filemap.c:4044 call_write_iter include/linux/fs.h:1877 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x650/0xe40 fs/read_write.c:584 ksys_write+0x12f/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a2/0x510 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xe7f/0x1120 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:269 notify_change+0x670/0x1160 fs/attr.c:483 do_truncate+0x15c/0x220 fs/open.c:66 handle_truncate fs/namei.c:3295 [inline] do_open fs/namei.c:3640 [inline] path_openat+0x23f1/0x29c0 fs/namei.c:3793 do_filp_open+0x1de/0x430 fs/namei.c:3820 do_sys_openat2+0x176/0x1e0 fs/open.c:1407 do_sys_open fs/open.c:1422 [inline] __do_sys_creat fs/open.c:1498 [inline] __se_sys_creat fs/open.c:1492 [inline] __x64_sys_creat+0xcd/0x120 fs/open.c:1492 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz-executor.4/18337: #0: ffff88807deaa410 (sb_writers#33){.+.+}-{0:0}, at: do_open fs/namei.c:3629 [inline] #0: ffff88807deaa410 (sb_writers#33){.+.+}-{0:0}, at: path_openat+0x1e7c/0x29c0 fs/namei.c:3793 #1: ffff88807a377a80 (&sb->s_type->i_mutex_key#39){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline] #1: ffff88807a377a80 (&sb->s_type->i_mutex_key#39){+.+.}-{3:3}, at: do_truncate+0x14b/0x220 fs/open.c:64 #2: ffff88807a377888 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x226/0x1120 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 18337 Comm: syz-executor.4 Not tainted 6.5.0-rc5-syzkaller-00362-ga785fd28d31f #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a2/0x510 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xe7f/0x1120 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:269 notify_change+0x670/0x1160 fs/attr.c:483 do_truncate+0x15c/0x220 fs/open.c:66 handle_truncate fs/namei.c:3295 [inline] do_open fs/namei.c:3640 [inline] path_openat+0x23f1/0x29c0 fs/namei.c:3793 do_filp_open+0x1de/0x430 fs/namei.c:3820 do_sys_openat2+0x176/0x1e0 fs/open.c:1407 do_sys_open fs/open.c:1422 [inline] __do_sys_creat fs/open.c:1498 [inline] __se_sys_creat fs/open.c:1492 [inline] __x64_sys_creat+0xcd/0x120 fs/open.c:1492 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fe371a7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe3727e20c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 00007fe371b9bf80 RCX: 00007fe371a7cae9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000100 RBP: 00007fe371ac847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fe371b9bf80 R15: 00007ffd1860dcd8 hfsplus: unable to mark blocks free: error -4 hfsplus: can't free extent