====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc4-syzkaller-00031-g6e50979a9c87 #0 Not tainted ------------------------------------------------------ syz-executor.2/23651 is trying to acquire lock: ffff8880366b3890 (mapping.invalidate_lock#12){++++}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:811 [inline] ffff8880366b3890 (mapping.invalidate_lock#12){++++}-{3:3}, at: f2fs_vm_page_mkwrite+0x4f6/0x1350 fs/f2fs/file.c:104 but task is already holding lock: ffff88802ef26558 (sb_pagefaults#8){.+.+}-{0:0}, at: sb_start_pagefault include/linux/fs.h:1918 [inline] ffff88802ef26558 (sb_pagefaults#8){.+.+}-{0:0}, at: f2fs_vm_page_mkwrite+0x430/0x1350 fs/f2fs/file.c:99 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (sb_pagefaults#8){.+.+}-{0:0}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write+0x5c/0x1b0 include/linux/fs.h:1814 sb_start_pagefault include/linux/fs.h:1918 [inline] f2fs_vm_page_mkwrite+0x430/0x1350 fs/f2fs/file.c:99 do_page_mkwrite+0x19e/0x5e0 mm/memory.c:2947 do_shared_fault mm/memory.c:4579 [inline] do_fault mm/memory.c:4647 [inline] handle_pte_fault mm/memory.c:4931 [inline] __handle_mm_fault mm/memory.c:5073 [inline] handle_mm_fault+0x1952/0x26b0 mm/memory.c:5219 do_user_addr_fault+0x69b/0xcb0 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x7a/0x110 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 -> #4 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __might_fault+0xb2/0x110 mm/memory.c:5647 _copy_to_user+0x26/0x130 lib/usercopy.c:29 copy_to_user include/linux/uaccess.h:169 [inline] f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2365 [inline] __f2fs_ioctl+0xaf72/0xb540 fs/f2fs/file.c:4169 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #3 (&sbi->sb_lock){++++}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write+0x9c/0x270 kernel/locking/rwsem.c:1562 f2fs_down_write fs/f2fs/f2fs.h:2213 [inline] f2fs_handle_error+0xe0/0x230 fs/f2fs/super.c:3926 f2fs_check_nid_range fs/f2fs/node.c:39 [inline] __get_node_page+0xd9a/0x1570 fs/f2fs/node.c:1415 read_xattr_block fs/f2fs/xattr.c:305 [inline] lookup_all_xattrs fs/f2fs/xattr.c:354 [inline] f2fs_getxattr+0x743/0x1490 fs/f2fs/xattr.c:531 __f2fs_get_acl+0x52/0x900 fs/f2fs/acl.c:179 f2fs_acl_create fs/f2fs/acl.c:377 [inline] f2fs_init_acl+0xd2/0x9b0 fs/f2fs/acl.c:420 f2fs_init_inode_metadata+0x99a/0xf80 fs/f2fs/dir.c:591 f2fs_add_regular_entry+0x8ce/0xea0 fs/f2fs/dir.c:775 f2fs_add_dentry fs/f2fs/dir.c:816 [inline] f2fs_do_add_link+0x2a7/0x470 fs/f2fs/dir.c:855 f2fs_add_link fs/f2fs/f2fs.h:3564 [inline] f2fs_mkdir+0x2ec/0x520 fs/f2fs/namei.c:767 vfs_mkdir+0x3b3/0x590 fs/namei.c:4036 do_mkdirat+0x25b/0x530 fs/namei.c:4061 __do_sys_mkdir fs/namei.c:4081 [inline] __se_sys_mkdir fs/namei.c:4079 [inline] __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4079 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&fi->i_xattr_sem){++++}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_write+0x9c/0x270 kernel/locking/rwsem.c:1562 f2fs_down_write fs/f2fs/f2fs.h:2213 [inline] f2fs_setxattr+0x1d6/0x320 fs/f2fs/xattr.c:797 __f2fs_set_acl+0xa58/0xdd0 fs/f2fs/acl.c:269 set_posix_acl fs/posix_acl.c:957 [inline] vfs_remove_acl+0x586/0x800 fs/posix_acl.c:1209 ovl_do_remove_acl fs/overlayfs/overlayfs.h:292 [inline] ovl_workdir_create+0x4df/0x8f0 fs/overlayfs/super.c:821 ovl_make_workdir+0x107/0xdf0 fs/overlayfs/super.c:1294 ovl_get_workdir+0x2e4/0x410 fs/overlayfs/super.c:1444 ovl_fill_super+0x19d7/0x2790 fs/overlayfs/super.c:2000 mount_nodev+0x52/0xe0 fs/super.c:1405 legacy_get_tree+0xea/0x180 fs/fs_context.c:610 vfs_get_tree+0x88/0x270 fs/super.c:1489 do_new_mount+0x289/0xad0 fs/namespace.c:3145 do_mount fs/namespace.c:3488 [inline] __do_sys_mount fs/namespace.c:3697 [inline] __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3674 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&sbi->cp_rwsem){++++}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_read+0x39/0x50 kernel/locking/rwsem.c:1509 f2fs_down_read fs/f2fs/f2fs.h:2188 [inline] f2fs_lock_op fs/f2fs/f2fs.h:2231 [inline] f2fs_do_collapse fs/f2fs/file.c:1405 [inline] f2fs_collapse_range+0x223/0x3b0 fs/f2fs/file.c:1437 f2fs_fallocate+0x446/0x6e0 fs/f2fs/file.c:1837 vfs_fallocate+0x515/0x670 fs/open.c:323 ksys_fallocate fs/open.c:346 [inline] __do_sys_fallocate fs/open.c:354 [inline] __se_sys_fallocate fs/open.c:352 [inline] __x64_sys_fallocate+0xb9/0x100 fs/open.c:352 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (mapping.invalidate_lock#12){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_read+0x39/0x50 kernel/locking/rwsem.c:1509 filemap_invalidate_lock_shared include/linux/fs.h:811 [inline] f2fs_vm_page_mkwrite+0x4f6/0x1350 fs/f2fs/file.c:104 do_page_mkwrite+0x19e/0x5e0 mm/memory.c:2947 do_shared_fault mm/memory.c:4579 [inline] do_fault mm/memory.c:4647 [inline] handle_pte_fault mm/memory.c:4931 [inline] __handle_mm_fault mm/memory.c:5073 [inline] handle_mm_fault+0x1952/0x26b0 mm/memory.c:5219 do_user_addr_fault+0x69b/0xcb0 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x7a/0x110 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 other info that might help us debug this: Chain exists of: mapping.invalidate_lock#12 --> &mm->mmap_lock --> sb_pagefaults#8 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_pagefaults#8); lock(&mm->mmap_lock); lock(sb_pagefaults#8); lock(mapping.invalidate_lock#12); *** DEADLOCK *** 2 locks held by syz-executor.2/23651: #0: ffff8880756735d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline] #0: ffff8880756735d8 (&mm->mmap_lock){++++}-{3:3}, at: do_user_addr_fault+0x2e2/0xcb0 arch/x86/mm/fault.c:1369 #1: ffff88802ef26558 (sb_pagefaults#8){.+.+}-{0:0}, at: sb_start_pagefault include/linux/fs.h:1918 [inline] #1: ffff88802ef26558 (sb_pagefaults#8){.+.+}-{0:0}, at: f2fs_vm_page_mkwrite+0x430/0x1350 fs/f2fs/file.c:99 stack backtrace: CPU: 1 PID: 23651 Comm: syz-executor.2 Not tainted 6.2.0-rc4-syzkaller-00031-g6e50979a9c87 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x290 lib/dump_stack.c:106 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 down_read+0x39/0x50 kernel/locking/rwsem.c:1509 filemap_invalidate_lock_shared include/linux/fs.h:811 [inline] f2fs_vm_page_mkwrite+0x4f6/0x1350 fs/f2fs/file.c:104 do_page_mkwrite+0x19e/0x5e0 mm/memory.c:2947 do_shared_fault mm/memory.c:4579 [inline] do_fault mm/memory.c:4647 [inline] handle_pte_fault mm/memory.c:4931 [inline] __handle_mm_fault mm/memory.c:5073 [inline] handle_mm_fault+0x1952/0x26b0 mm/memory.c:5219 do_user_addr_fault+0x69b/0xcb0 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x7a/0x110 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 RIP: 0033:0x7f6fcc286c16 Code: 82 63 01 00 00 48 89 d1 f3 a4 c3 80 fa 08 73 12 80 fa 04 73 1e 80 fa 01 77 26 72 05 0f b6 0e 88 0f c3 48 8b 4c 16 f8 48 8b 36 <48> 89 4c 17 f8 48 89 37 c3 8b 4c 16 fc 8b 36 89 4c 17 fc 89 37 c3 RSP: 002b:00007ffda811c498 EFLAGS: 00010202 RAX: 0000000020000040 RBX: 0000000000000000 RCX: 0073746e6576652e RDX: 000000000000000c RSI: 6576652e73646970 RDI: 0000000020000040 RBP: 00007ffda811c558 R08: 00007f6fcc200000 R09: 00007f6fcbe00000 R10: 00007f6fcbe08ff0 R11: 0000000000000246 R12: 00000000001ff4a0 R13: 00007ffda811c580 R14: 00007f6fcc3abf80 R15: 0000000000000032