====================================================== WARNING: possible circular locking dependency detected 5.15.156-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/5210 is trying to acquire lock: ffff0000c0c70e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 but task is already holding lock: ffff0000cbe860b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&tree->tree_lock/2){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_find_init+0x144/0x1bc hfsplus_delete_all_attrs+0xfc/0x348 fs/hfsplus/attributes.c:366 hfsplus_delete_cat+0x9a4/0xd6c fs/hfsplus/catalog.c:425 hfsplus_file_release+0x17c/0x3b4 fs/hfsplus/inode.c:238 __fput+0x30c/0x7f0 fs/file_table.c:280 ____fput+0x20/0x30 fs/file_table.c:308 task_work_run+0x130/0x1e4 kernel/task_work.c:164 tracehook_notify_resume include/linux/tracehook.h:189 [inline] do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline] el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x6d4/0x9cc fs/hfsplus/extents.c:595 hfsplus_file_release+0x2a8/0x3b4 fs/hfsplus/inode.c:240 __fput+0x30c/0x7f0 fs/file_table.c:280 ____fput+0x20/0x30 fs/file_table.c:308 task_work_run+0x130/0x1e4 kernel/task_work.c:164 tracehook_notify_resume include/linux/tracehook.h:189 [inline] do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline] el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 block_read_full_page+0x2a0/0xc4c fs/buffer.c:2290 hfsplus_readpage+0x28/0x38 fs/hfsplus/inode.c:28 do_read_cache_page+0x60c/0x950 read_cache_page+0x68/0x84 mm/filemap.c:3574 read_mapping_page include/linux/pagemap.h:515 [inline] __hfs_bnode_create+0x3f0/0x864 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x200/0xcb0 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x134/0x4a0 fs/hfsplus/bfind.c:183 hfsplus_delete_attr+0x2a0/0x41c fs/hfsplus/attributes.c:341 hfsplus_removexattr fs/hfsplus/xattr.c:794 [inline] __hfsplus_setxattr+0xa80/0x1df0 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:434 hfsplus_user_setxattr+0x54/0x6c fs/hfsplus/xattr_user.c:30 __vfs_removexattr+0x370/0x38c fs/xattr.c:470 __vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505 vfs_removexattr+0xe0/0x23c fs/xattr.c:527 removexattr fs/xattr.c:857 [inline] path_removexattr+0x1ec/0x2ec fs/xattr.c:871 __do_sys_removexattr fs/xattr.c:885 [inline] __se_sys_removexattr fs/xattr.c:882 [inline] __arm64_sys_removexattr+0x60/0x78 fs/xattr.c:882 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock --> &tree->tree_lock/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/2); lock(&tree->tree_lock); lock(&tree->tree_lock/2); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz-executor.2/5210: #0: ffff0000e6080460 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #1: ffff0000c0c72b80 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000c0c72b80 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: vfs_removexattr+0xcc/0x23c fs/xattr.c:526 #2: ffff0000caa260b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc #3: ffff0000cbe860b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc stack backtrace: CPU: 0 PID: 5210 Comm: syz-executor.2 Not tainted 5.15.156-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 block_read_full_page+0x2a0/0xc4c fs/buffer.c:2290 hfsplus_readpage+0x28/0x38 fs/hfsplus/inode.c:28 do_read_cache_page+0x60c/0x950 read_cache_page+0x68/0x84 mm/filemap.c:3574 read_mapping_page include/linux/pagemap.h:515 [inline] __hfs_bnode_create+0x3f0/0x864 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x200/0xcb0 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x134/0x4a0 fs/hfsplus/bfind.c:183 hfsplus_delete_attr+0x2a0/0x41c fs/hfsplus/attributes.c:341 hfsplus_removexattr fs/hfsplus/xattr.c:794 [inline] __hfsplus_setxattr+0xa80/0x1df0 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:434 hfsplus_user_setxattr+0x54/0x6c fs/hfsplus/xattr_user.c:30 __vfs_removexattr+0x370/0x38c fs/xattr.c:470 __vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505 vfs_removexattr+0xe0/0x23c fs/xattr.c:527 removexattr fs/xattr.c:857 [inline] path_removexattr+0x1ec/0x2ec fs/xattr.c:871 __do_sys_removexattr fs/xattr.c:885 [inline] __se_sys_removexattr fs/xattr.c:882 [inline] __arm64_sys_removexattr+0x60/0x78 fs/xattr.c:882 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584