gfs2: fsid=syz:syz.0: found 1 quota changes ====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc7-syzkaller-gc912bf709078 #0 Not tainted ------------------------------------------------------ syz.1.123/7202 is trying to acquire lock: ffff0000c7bacae8 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xac/0x5c8 fs/gfs2/quota.c:720 but task is already holding lock: ffff0000dd907168 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x210/0x179c fs/gfs2/bmap.c:682 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1526 __gfs2_iomap_get+0x124/0x102c fs/gfs2/bmap.c:859 gfs2_iomap_get+0xd8/0x154 fs/gfs2/bmap.c:1413 bh_get+0x1ec/0x688 fs/gfs2/quota.c:417 qdsb_get+0x1c8/0x30c fs/gfs2/quota.c:566 gfs2_quota_hold+0x16c/0x560 fs/gfs2/quota.c:646 gfs2_quota_lock+0xb8/0x400 fs/gfs2/quota.c:1103 gfs2_quota_lock_check fs/gfs2/quota.h:50 [inline] alloc_dinode+0x180/0x4ec fs/gfs2/inode.c:410 gfs2_create_inode+0xbd8/0x1518 fs/gfs2/inode.c:739 gfs2_atomic_open+0xd8/0x1c4 fs/gfs2/inode.c:1315 atomic_open fs/namei.c:3415 [inline] lookup_open fs/namei.c:3523 [inline] open_last_lookups fs/namei.c:3621 [inline] path_openat+0xb54/0x2ae8 fs/namei.c:3857 do_filp_open+0x1bc/0x3cc fs/namei.c:3887 do_sys_openat2+0x124/0x1b8 fs/open.c:1413 do_sys_open fs/open.c:1428 [inline] __do_sys_openat fs/open.c:1444 [inline] __se_sys_openat fs/open.c:1439 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1439 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 do_qc+0xac/0x5c8 fs/gfs2/quota.c:720 gfs2_quota_change+0x238/0x728 fs/gfs2/quota.c:1315 gfs2_alloc_blocks+0x172c/0x2044 fs/gfs2/rgrp.c:2496 __gfs2_iomap_alloc+0x3b4/0x179c fs/gfs2/bmap.c:708 gfs2_iomap_alloc+0x138/0x1d0 fs/gfs2/bmap.c:1426 fallocate_chunk fs/gfs2/file.c:1198 [inline] __gfs2_fallocate+0xc5c/0x18bc fs/gfs2/file.c:1337 gfs2_fallocate+0x31c/0x458 fs/gfs2/file.c:1401 vfs_fallocate+0x480/0x5bc fs/open.c:330 ksys_fallocate fs/open.c:353 [inline] __do_sys_fallocate fs/open.c:361 [inline] __se_sys_fallocate fs/open.c:359 [inline] __arm64_sys_fallocate+0xc0/0x110 fs/open.c:359 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 5 locks held by syz.1.123/7202: #0: ffff0000d3828420 (sb_writers#25){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2854 [inline] #0: ffff0000d3828420 (sb_writers#25){.+.+}-{0:0}, at: vfs_fallocate+0x40c/0x5bc fs/open.c:329 #1: ffff0000dd906cd0 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #1: ffff0000dd906cd0 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: gfs2_fallocate+0x188/0x458 fs/gfs2/file.c:1380 #2: ffff0000d3828610 (sb_internal#5){.+.+}-{0:0}, at: gfs2_trans_begin+0x8c/0x100 fs/gfs2/trans.c:118 #3: ffff0000c7bad060 (&sdp->sd_log_flush_lock){++++}-{3:3}, at: __gfs2_trans_begin+0x510/0x908 fs/gfs2/trans.c:87 #4: ffff0000dd907168 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x210/0x179c fs/gfs2/bmap.c:682 stack backtrace: CPU: 1 PID: 7202 Comm: syz.1.123 Not tainted 6.10.0-rc7-syzkaller-gc912bf709078 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:317 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:324 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:114 dump_stack+0x1c/0x28 lib/dump_stack.c:123 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2060 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 do_qc+0xac/0x5c8 fs/gfs2/quota.c:720 gfs2_quota_change+0x238/0x728 fs/gfs2/quota.c:1315 gfs2_alloc_blocks+0x172c/0x2044 fs/gfs2/rgrp.c:2496 __gfs2_iomap_alloc+0x3b4/0x179c fs/gfs2/bmap.c:708 gfs2_iomap_alloc+0x138/0x1d0 fs/gfs2/bmap.c:1426 fallocate_chunk fs/gfs2/file.c:1198 [inline] __gfs2_fallocate+0xc5c/0x18bc fs/gfs2/file.c:1337 gfs2_fallocate+0x31c/0x458 fs/gfs2/file.c:1401 vfs_fallocate+0x480/0x5bc fs/open.c:330 ksys_fallocate fs/open.c:353 [inline] __do_sys_fallocate fs/open.c:361 [inline] __se_sys_fallocate fs/open.c:359 [inline] __arm64_sys_fallocate+0xc0/0x110 fs/open.c:359 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598