====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.9.256/7649 is trying to acquire lock: ffff88803c2ec770 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x455/0xb30 fs/ocfs2/quota_global.c:860 but task is already holding lock: ffff88805a48ec50 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590 ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7c1/0xf20 fs/quota/dquot.c:980 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2823 quota_setquota+0x4b7/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&ocfs2_sysfile_lock_key[GROUP_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590 inode_lock include/linux/fs.h:980 [inline] ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7c1/0xf20 fs/quota/dquot.c:980 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2823 quota_setquota+0x4b7/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/rtmutex_api.c:535 [inline] mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:547 wait_on_dquot fs/quota/dquot.c:357 [inline] dqget+0x73a/0xf20 fs/quota/dquot.c:975 dquot_transfer+0x2f8/0x6d0 fs/quota/dquot.c:2143 ext4_setattr+0x865/0x1bc0 fs/ext4/inode.c:5881 notify_change+0xc18/0xf60 fs/attr.c:546 chown_common+0x40c/0x5c0 fs/open.c:791 vfs_fchown fs/open.c:859 [inline] ksys_fchown+0xea/0x160 fs/open.c:871 __do_sys_fchown fs/open.c:876 [inline] __se_sys_fchown fs/open.c:874 [inline] __x64_sys_fchown+0x7a/0x90 fs/open.c:874 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&ei->xattr_sem){++++}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590 ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline] ext4_xattr_set_handle+0x165/0x1590 fs/ext4/xattr.c:2367 ext4_initxattrs+0x9f/0x110 fs/ext4/xattr_security.c:44 security_inode_init_security+0x2a0/0x3f0 security/security.c:1891 __ext4_new_inode+0x3314/0x3cb0 fs/ext4/ialloc.c:1325 ext4_create+0x22d/0x460 fs/ext4/namei.c:2822 lookup_open fs/namei.c:3796 [inline] open_last_lookups fs/namei.c:3895 [inline] path_openat+0x1500/0x3840 fs/namei.c:4131 do_filp_open+0x1fa/0x410 fs/namei.c:4161 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __x64_sys_openat+0x138/0x170 fs/open.c:1463 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444 jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501 jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540 ocfs2_start_trans+0x377/0x6d0 fs/ocfs2/journal.c:374 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1254 [inline] ocfs2_reserve_local_alloc_bits+0xb04/0x24e0 fs/ocfs2/localalloc.c:669 ocfs2_reserve_clusters_with_limit+0x1be/0xba0 fs/ocfs2/suballoc.c:1168 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2862 [inline] ocfs2_extend_dir+0x701/0x4870 fs/ocfs2/dir.c:3207 ocfs2_prepare_dir_for_insert+0x2fe8/0x5450 fs/ocfs2/dir.c:4312 ocfs2_mknod+0x819/0x2050 fs/ocfs2/namei.c:297 ocfs2_create+0x1a5/0x440 fs/ocfs2/namei.c:676 lookup_open fs/namei.c:3796 [inline] open_last_lookups fs/namei.c:3895 [inline] path_openat+0x1500/0x3840 fs/namei.c:4131 do_filp_open+0x1fa/0x410 fs/namei.c:4161 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_creat fs/open.c:1530 [inline] __se_sys_creat fs/open.c:1524 [inline] __x64_sys_creat+0x8f/0xc0 fs/open.c:1524 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537 ocfs2_start_trans+0x36b/0x6d0 fs/ocfs2/journal.c:372 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1254 [inline] ocfs2_reserve_local_alloc_bits+0xb04/0x24e0 fs/ocfs2/localalloc.c:669 ocfs2_reserve_clusters_with_limit+0x1be/0xba0 fs/ocfs2/suballoc.c:1168 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2862 [inline] ocfs2_extend_dir+0x701/0x4870 fs/ocfs2/dir.c:3207 ocfs2_prepare_dir_for_insert+0x2fe8/0x5450 fs/ocfs2/dir.c:4312 ocfs2_mknod+0x819/0x2050 fs/ocfs2/namei.c:297 ocfs2_create+0x1a5/0x440 fs/ocfs2/namei.c:676 lookup_open fs/namei.c:3796 [inline] open_last_lookups fs/namei.c:3895 [inline] path_openat+0x1500/0x3840 fs/namei.c:4131 do_filp_open+0x1fa/0x410 fs/namei.c:4161 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_creat fs/open.c:1530 [inline] __se_sys_creat fs/open.c:1524 [inline] __x64_sys_creat+0x8f/0xc0 fs/open.c:1524 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1916 [inline] sb_start_intwrite include/linux/fs.h:2099 [inline] ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370 ocfs2_acquire_dquot+0x455/0xb30 fs/ocfs2/quota_global.c:860 dqget+0x7c1/0xf20 fs/quota/dquot.c:980 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2823 quota_setquota+0x4b7/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: sb_internal#4 --> &ocfs2_sysfile_lock_key[GROUP_QUOTA_SYSTEM_INODE] --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[GROUP_QUOTA_SYSTEM_INODE]); lock(&ocfs2_quota_ip_alloc_sem_key); rlock(sb_internal#4); *** DEADLOCK *** 4 locks held by syz.9.256/7649: #0: ffff88803c2ec0d0 (&type->s_umount_key#75){++++}-{4:4}, at: __super_lock fs/super.c:59 [inline] #0: ffff88803c2ec0d0 (&type->s_umount_key#75){++++}-{4:4}, at: super_lock+0x2a9/0x3b0 fs/super.c:121 #1: ffff88806298a098 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb30 fs/ocfs2/quota_global.c:823 #2: ffff88805a48f000 (&ocfs2_sysfile_lock_key[GROUP_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:980 [inline] #2: ffff88805a48f000 (&ocfs2_sysfile_lock_key[GROUP_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 #3: ffff88805a48ec50 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 UID: 0 PID: 7649 Comm: syz.9.256 Not tainted syzkaller #0 PREEMPT_{RT,(full)} Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1916 [inline] sb_start_intwrite include/linux/fs.h:2099 [inline] ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370 ocfs2_acquire_dquot+0x455/0xb30 fs/ocfs2/quota_global.c:860 dqget+0x7c1/0xf20 fs/quota/dquot.c:980 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2823 quota_setquota+0x4b7/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fdf6da6f6c9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fdf6bcd6038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007fdf6dcc5fa0 RCX: 00007fdf6da6f6c9 RDX: 0000000000000000 RSI: 00002000000000c0 RDI: ffffffff80000801 RBP: 00007fdf6daf1f91 R08: 0000000000000000 R09: 0000000000000000 R10: 00002000000002c0 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fdf6dcc6038 R14: 00007fdf6dcc5fa0 R15: 00007ffc5c0e6e88 (syz.9.256,7649,1):ocfs2_verify_group_and_input:428 ERROR: add a group which is in the current volume. (syz.9.256,7649,1):ocfs2_group_add:511 ERROR: status = -22