====================================================== WARNING: possible circular locking dependency detected 5.15.158-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/8930 is trying to acquire lock: ffff888024a043f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 but task is already holding lock: ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_dio_write_checks fs/ext4/file.c:452 [inline] ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_dio_write_iter fs/ext4/file.c:520 [inline] ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_file_write_iter+0xe94/0x1990 fs/ext4/file.c:681 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&sb->s_type->i_mutex_key#9){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 inode_lock_shared include/linux/fs.h:799 [inline] ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3152 bmap+0xa1/0xd0 fs/inode.c:1756 jbd2_journal_bmap fs/jbd2/journal.c:980 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1790 [inline] jbd2_journal_flush+0x7a2/0xc90 fs/jbd2/journal.c:2496 ext4_ioctl_checkpoint fs/ext4/ioctl.c:849 [inline] __ext4_ioctl fs/ext4/ioctl.c:1267 [inline] ext4_ioctl+0x3249/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 mutex_lock_io_nested+0x45/0x60 kernel/locking/mutex.c:777 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits+0x950/0xc00 fs/jbd2/transaction.c:299 start_this_handle+0x747/0x1570 fs/jbd2/transaction.c:423 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 __ext4_journal_start_sb+0x175/0x370 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_handle_inode_extension+0x1a7/0x8b0 fs/ext4/file.c:323 ext4_dio_write_iter fs/ext4/file.c:577 [inline] ext4_file_write_iter+0x17b7/0x1990 fs/ext4/file.c:681 do_iter_readv_writev+0x594/0x7a0 do_iter_write+0x1ea/0x760 fs/read_write.c:855 iter_file_splice_write+0x806/0xfa0 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0xe3/0x1c0 fs/splice.c:936 splice_direct_to_actor+0x500/0xc10 fs/splice.c:891 do_splice_direct+0x285/0x3d0 fs/splice.c:979 do_sendfile+0x625/0xff0 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1317 [inline] __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sb->s_type->i_mutex_key#9); lock(&journal->j_checkpoint_mutex); lock(&sb->s_type->i_mutex_key#9); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 2 locks held by syz-executor.0/8930: #0: ffff888024a00460 (sb_writers#5){.+.+}-{0:0}, at: do_sendfile+0x600/0xff0 fs/read_write.c:1248 #1: ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_dio_write_checks fs/ext4/file.c:452 [inline] #1: ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_dio_write_iter fs/ext4/file.c:520 [inline] #1: ffff88805850f198 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_file_write_iter+0xe94/0x1990 fs/ext4/file.c:681 stack backtrace: CPU: 1 PID: 8930 Comm: syz-executor.0 Not tainted 5.15.158-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 mutex_lock_io_nested+0x45/0x60 kernel/locking/mutex.c:777 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits+0x950/0xc00 fs/jbd2/transaction.c:299 start_this_handle+0x747/0x1570 fs/jbd2/transaction.c:423 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 __ext4_journal_start_sb+0x175/0x370 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_handle_inode_extension+0x1a7/0x8b0 fs/ext4/file.c:323 ext4_dio_write_iter fs/ext4/file.c:577 [inline] ext4_file_write_iter+0x17b7/0x1990 fs/ext4/file.c:681 do_iter_readv_writev+0x594/0x7a0 do_iter_write+0x1ea/0x760 fs/read_write.c:855 iter_file_splice_write+0x806/0xfa0 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0xe3/0x1c0 fs/splice.c:936 splice_direct_to_actor+0x500/0xc10 fs/splice.c:891 do_splice_direct+0x285/0x3d0 fs/splice.c:979 do_sendfile+0x625/0xff0 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1317 [inline] __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f64fe814d69 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f64fcd870c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007f64fe942f80 RCX: 00007f64fe814d69 RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000003 RBP: 00007f64fe86149e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000100000005 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f64fe942f80 R15: 00007ffe3ac627f8