====================================================== WARNING: possible circular locking dependency detected 4.14.262-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/18128 is trying to acquire lock: ("dio/%s"sb->s_id){+.+.}, at: [] flush_workqueue+0xcb/0x1310 kernel/workqueue.c:2622 but task is already holding lock: (&sb->s_type->i_mutex_key#25){++++}, at: [] inode_lock include/linux/fs.h:719 [inline] (&sb->s_type->i_mutex_key#25){++++}, at: [] generic_file_write_iter+0x99/0x650 mm/filemap.c:3205 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&sb->s_type->i_mutex_key#25){++++}: down_write+0x34/0x90 kernel/locking/rwsem.c:54 inode_lock include/linux/fs.h:719 [inline] __generic_file_fsync+0x9e/0x190 fs/libfs.c:989 fat_file_fsync+0x73/0x1f0 fs/fat/file.c:165 vfs_fsync_range+0x103/0x260 fs/sync.c:196 generic_write_sync include/linux/fs.h:2684 [inline] dio_complete+0x561/0x8d0 fs/direct-io.c:330 process_one_work+0x793/0x14a0 kernel/workqueue.c:2117 worker_thread+0x5cc/0xff0 kernel/workqueue.c:2251 kthread+0x30d/0x420 kernel/kthread.c:232 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404 -> #1 ((&dio->complete_work)){+.+.}: process_one_work+0x736/0x14a0 kernel/workqueue.c:2093 worker_thread+0x5cc/0xff0 kernel/workqueue.c:2251 kthread+0x30d/0x420 kernel/kthread.c:232 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404 -> #0 ("dio/%s"sb->s_id){+.+.}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 flush_workqueue+0xfa/0x1310 kernel/workqueue.c:2625 drain_workqueue+0x177/0x3e0 kernel/workqueue.c:2790 destroy_workqueue+0x71/0x710 kernel/workqueue.c:4116 __alloc_workqueue_key+0xd50/0x1080 kernel/workqueue.c:4093 sb_init_dio_done_wq+0x34/0x80 fs/direct-io.c:624 do_blockdev_direct_IO fs/direct-io.c:1287 [inline] __blockdev_direct_IO+0x3df1/0xdcb0 fs/direct-io.c:1423 blockdev_direct_IO include/linux/fs.h:2994 [inline] fat_direct_IO+0x19b/0x320 fs/fat/inode.c:275 generic_file_direct_write+0x1df/0x420 mm/filemap.c:2958 __generic_file_write_iter+0x2a2/0x590 mm/filemap.c:3137 generic_file_write_iter+0x36f/0x650 mm/filemap.c:3208 call_write_iter include/linux/fs.h:1780 [inline] aio_write+0x2ed/0x560 fs/aio.c:1553 io_submit_one fs/aio.c:1641 [inline] do_io_submit+0x847/0x1570 fs/aio.c:1709 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb other info that might help us debug this: Chain exists of: "dio/%s"sb->s_id --> (&dio->complete_work) --> &sb->s_type->i_mutex_key#25 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sb->s_type->i_mutex_key#25); lock((&dio->complete_work)); lock(&sb->s_type->i_mutex_key#25); lock("dio/%s"sb->s_id); *** DEADLOCK *** 2 locks held by syz-executor.5/18128: #0: (sb_writers#16){.+.+}, at: [] file_start_write include/linux/fs.h:2714 [inline] #0: (sb_writers#16){.+.+}, at: [] aio_write+0x408/0x560 fs/aio.c:1552 #1: (&sb->s_type->i_mutex_key#25){++++}, at: [] inode_lock include/linux/fs.h:719 [inline] #1: (&sb->s_type->i_mutex_key#25){++++}, at: [] generic_file_write_iter+0x99/0x650 mm/filemap.c:3205 stack backtrace: CPU: 0 PID: 18128 Comm: syz-executor.5 Not tainted 4.14.262-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 flush_workqueue+0xfa/0x1310 kernel/workqueue.c:2625 drain_workqueue+0x177/0x3e0 kernel/workqueue.c:2790 destroy_workqueue+0x71/0x710 kernel/workqueue.c:4116 __alloc_workqueue_key+0xd50/0x1080 kernel/workqueue.c:4093 sb_init_dio_done_wq+0x34/0x80 fs/direct-io.c:624 do_blockdev_direct_IO fs/direct-io.c:1287 [inline] __blockdev_direct_IO+0x3df1/0xdcb0 fs/direct-io.c:1423 blockdev_direct_IO include/linux/fs.h:2994 [inline] fat_direct_IO+0x19b/0x320 fs/fat/inode.c:275 generic_file_direct_write+0x1df/0x420 mm/filemap.c:2958 __generic_file_write_iter+0x2a2/0x590 mm/filemap.c:3137 generic_file_write_iter+0x36f/0x650 mm/filemap.c:3208 call_write_iter include/linux/fs.h:1780 [inline] aio_write+0x2ed/0x560 fs/aio.c:1553 io_submit_one fs/aio.c:1641 [inline] do_io_submit+0x847/0x1570 fs/aio.c:1709 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb RIP: 0033:0x7f9e55d92fe9 RSP: 002b:00007f9e54708168 EFLAGS: 00000246 ORIG_RAX: 00000000000000d1 RAX: ffffffffffffffda RBX: 00007f9e55ea5f60 RCX: 00007f9e55d92fe9 RDX: 0000000020000540 RSI: 00000000000018af RDI: 00007f9e55e81000 RBP: 00007f9e55ded08d R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffef7af52bf R14: 00007f9e54708300 R15: 0000000000022000 8021q: adding VLAN 0 to HW filter on device batadv80 team0: Port device batadv80 added 8021q: adding VLAN 0 to HW filter on device batadv10 usb usb14-port1: Cannot enable. Maybe the USB cable is bad? team0: Port device batadv10 added 8021q: adding VLAN 0 to HW filter on device batadv81 team0: Port device batadv81 added EXT4-fs (loop3): mounted filesystem without journal. Opts: ,errors=continue audit: type=1800 audit(1642470497.509:186): pid=18259 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="loop3" ino=18 res=0 audit: type=1804 audit(1642470497.509:187): pid=18259 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir286165103/syzkaller.HNHAHs/179/file0/bus" dev="loop3" ino=18 res=1 8021q: adding VLAN 0 to HW filter on device batadv82 EXT4-fs (loop3): mounted filesystem without journal. Opts: ,errors=continue audit: type=1800 audit(1642470497.839:188): pid=18332 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="loop3" ino=18 res=0 team0: Port device batadv82 added audit: type=1804 audit(1642470497.859:189): pid=18332 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir286165103/syzkaller.HNHAHs/180/file0/bus" dev="loop3" ino=18 res=1 EXT4-fs (loop3): mounted filesystem without journal. Opts: ,errors=continue audit: type=1800 audit(1642470498.159:190): pid=18424 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="sda1" ino=14443 res=0 8021q: adding VLAN 0 to HW filter on device batadv83 usb usb14-port1: Cannot enable. Maybe the USB cable is bad? usb usb14-port1: unable to enumerate USB device audit: type=1804 audit(1642470498.179:191): pid=18424 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir286165103/syzkaller.HNHAHs/181/file0/bus" dev="sda1" ino=14443 res=1 team0: Port device batadv83 added 8021q: adding VLAN 0 to HW filter on device batadv12 team0: Port device batadv12 added 8021q: adding VLAN 0 to HW filter on device batadv84 team0: Port device batadv84 added 8021q: adding VLAN 0 to HW filter on device batadv13 team0: Port device batadv13 added 8021q: adding VLAN 0 to HW filter on device batadv9 team0: Port device batadv9 added 8021q: adding VLAN 0 to HW filter on device batadv85 team0: Port device batadv85 added 8021q: adding VLAN 0 to HW filter on device batadv86 team0: Port device batadv86 added 8021q: adding VLAN 0 to HW filter on device batadv10 team0: Port device batadv10 added 8021q: adding VLAN 0 to HW filter on device batadv14 team0: Port device batadv14 added 8021q: adding VLAN 0 to HW filter on device batadv87 team0: Port device batadv87 added EXT4-fs (loop5): corrupt root inode, run e2fsck EXT4-fs (loop5): mount failed FAT-fs (loop5): Unrecognized mount option "subj_user=ext4" or missing value 8021q: adding VLAN 0 to HW filter on device batadv88 team0: Port device batadv88 added FAT-fs (loop5): Unrecognized mount option "subj_user=ext4" or missing value 8021q: adding VLAN 0 to HW filter on device batadv89 team0: Port device batadv89 added 8021q: adding VLAN 0 to HW filter on device batadv90 team0: Port device batadv90 added 8021q: adding VLAN 0 to HW filter on device batadv91 team0: Port device batadv91 added 8021q: adding VLAN 0 to HW filter on device batadv92 team0: Port device batadv92 added 8021q: adding VLAN 0 to HW filter on device batadv11 team0: Port device batadv11 added 8021q: adding VLAN 0 to HW filter on device batadv12 team0: Port device batadv12 added 8021q: adding VLAN 0 to HW filter on device batadv93 team0: Port device batadv93 added 8021q: adding VLAN 0 to HW filter on device batadv15 team0: Port device batadv15 added 8021q: adding VLAN 0 to HW filter on device batadv94 team0: Port device batadv94 added 8021q: adding VLAN 0 to HW filter on device batadv95 team0: Port device batadv95 added 8021q: adding VLAN 0 to HW filter on device batadv96 team0: Port device batadv96 added 8021q: adding VLAN 0 to HW filter on device batadv97 team0: Port device batadv97 added 8021q: adding VLAN 0 to HW filter on device batadv98 team0: Port device batadv98 added 8021q: adding VLAN 0 to HW filter on device batadv99 team0: Port device batadv99 added 8021q: adding VLAN 0 to HW filter on device batadv100 team0: Port device batadv100 added