====================================================== WARNING: possible circular locking dependency detected 5.15.148-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/5803 is trying to acquire lock: ffff888073bb40f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff888020e68e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 do_read_cache_page+0x752/0x1040 read_mapping_page include/linux/pagemap.h:515 [inline] hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x5d6/0x840 fs/buffer.c:2471 hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53 __page_symlink+0x15b/0x2a0 fs/namei.c:5163 hfsplus_symlink+0xc6/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x2ad/0x490 fs/namei.c:4435 do_symlinkat+0x1fd/0x600 fs/namei.c:4464 __do_sys_symlink fs/namei.c:4486 [inline] __se_sys_symlink fs/namei.c:4484 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4484 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:673 [inline] do_direct_IO fs/direct-io.c:959 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x1b13/0x4f40 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3275 [inline] hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x204/0x460 mm/filemap.c:3687 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2146 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 4 locks held by syz-executor.0/5803: #0: ffff888018fff9f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1088 #1: ffff88807ed8a460 (sb_writers#21){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590 #2: ffff888020e69080 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #2: ffff888020e69080 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: generic_file_write_iter+0x7c/0x1b0 mm/filemap.c:3941 #3: ffff888020e68e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 stack backtrace: CPU: 0 PID: 5803 Comm: syz-executor.0 Not tainted 5.15.148-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:673 [inline] do_direct_IO fs/direct-io.c:959 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x1b13/0x4f40 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3275 [inline] hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x204/0x460 mm/filemap.c:3687 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2146 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7f6b8a36cda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f6b888ed0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f6b8a49af80 RCX: 00007f6b8a36cda9 RDX: 000000000003fe00 RSI: 0000000020004200 RDI: 0000000000000004 RBP: 00007f6b8a3b947a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f6b8a49af80 R15: 00007fff73694a18