====================================================== WARNING: possible circular locking dependency detected 6.2.0-syzkaller-13534-gb01fe98d34f3 #0 Not tainted ------------------------------------------------------ syz-executor.3/30688 is trying to acquire lock: ffff88804383e990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x146/0x430 fs/jbd2/journal.c:689 but task is already holding lock: ffff888044934030 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] ffff888044934030 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename+0x1924/0x26d0 fs/ext4/namei.c:3879 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}: down_write_nested+0x96/0x200 kernel/locking/rwsem.c:1689 inode_lock_nested include/linux/fs.h:793 [inline] ext4_rename+0x1924/0x26d0 fs/ext4/namei.c:3879 ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4193 vfs_rename+0xef6/0x17a0 fs/namei.c:4772 ovl_do_rename.constprop.0+0x16a/0x270 fs/overlayfs/overlayfs.h:312 ovl_copy_up_workdir fs/overlayfs/copy_up.c:749 [inline] ovl_do_copy_up fs/overlayfs/copy_up.c:879 [inline] ovl_copy_up_one+0xbb1/0x2cc0 fs/overlayfs/copy_up.c:1049 ovl_copy_up_flags+0x150/0x1d0 fs/overlayfs/copy_up.c:1095 ovl_rename+0x28d/0x1770 fs/overlayfs/dir.c:1139 vfs_rename+0xef6/0x17a0 fs/namei.c:4772 do_renameat2+0xb62/0xc90 fs/namei.c:4923 __do_sys_rename fs/namei.c:4969 [inline] __se_sys_rename fs/namei.c:4967 [inline] __ia32_sys_rename+0x80/0xa0 fs/namei.c:4967 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 -> #0 (jbd2_handle){++++}-{0:0}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 jbd2_log_wait_commit+0x17b/0x430 fs/jbd2/journal.c:692 jbd2_journal_stop+0x5f5/0xfd0 fs/jbd2/transaction.c:1959 __ext4_journal_stop+0xe2/0x1f0 fs/ext4/ext4_jbd2.c:133 ext4_rename+0x1606/0x26d0 fs/ext4/namei.c:4014 ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4193 vfs_rename+0xef6/0x17a0 fs/namei.c:4772 do_renameat2+0xb62/0xc90 fs/namei.c:4923 __do_sys_rename fs/namei.c:4969 [inline] __se_sys_rename fs/namei.c:4967 [inline] __ia32_sys_rename+0x80/0xa0 fs/namei.c:4967 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#3/4); lock(jbd2_handle); lock(&type->i_mutex_dir_key#3/4); lock(jbd2_handle); *** DEADLOCK *** 4 locks held by syz-executor.3/30688: #0: ffff888043914460 (sb_writers#4){.+.+}-{0:0}, at: do_renameat2+0x37f/0xc90 fs/namei.c:4859 #1: ffff88801cb59810 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff88801cb59810 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x229/0x280 fs/namei.c:2991 #2: ffff888044931810 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff888044931810 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: vfs_rename+0x4f9/0x17a0 fs/namei.c:4744 #3: ffff888044934030 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #3: ffff888044934030 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename+0x1924/0x26d0 fs/ext4/namei.c:3879 stack backtrace: CPU: 2 PID: 30688 Comm: syz-executor.3 Not tainted 6.2.0-syzkaller-13534-gb01fe98d34f3 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 jbd2_log_wait_commit+0x17b/0x430 fs/jbd2/journal.c:692 jbd2_journal_stop+0x5f5/0xfd0 fs/jbd2/transaction.c:1959 __ext4_journal_stop+0xe2/0x1f0 fs/ext4/ext4_jbd2.c:133 ext4_rename+0x1606/0x26d0 fs/ext4/namei.c:4014 ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4193 vfs_rename+0xef6/0x17a0 fs/namei.c:4772 do_renameat2+0xb62/0xc90 fs/namei.c:4923 __do_sys_rename fs/namei.c:4969 [inline] __se_sys_rename fs/namei.c:4967 [inline] __ia32_sys_rename+0x80/0xa0 fs/namei.c:4967 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 RIP: 0023:0xf7ffc579 Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00 RSP: 002b:00000000f7ff75cc EFLAGS: 00000296 ORIG_RAX: 0000000000000026 RAX: ffffffffffffffda RBX: 0000000020000100 RCX: 0000000020000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000296 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 ---------------- Code disassembly (best guess), 2 bytes skipped: 0: 10 06 adc %al,(%rsi) 2: 03 74 b4 01 add 0x1(%rsp,%rsi,4),%esi 6: 10 07 adc %al,(%rdi) 8: 03 74 b0 01 add 0x1(%rax,%rsi,4),%esi c: 10 08 adc %cl,(%rax) e: 03 74 d8 01 add 0x1(%rax,%rbx,8),%esi 1e: 00 51 52 add %dl,0x52(%rcx) 21: 55 push %rbp 22: 89 e5 mov %esp,%ebp 24: 0f 34 sysenter 26: cd 80 int $0x80 * 28: 5d pop %rbp <-- trapping instruction 29: 5a pop %rdx 2a: 59 pop %rcx 2b: c3 retq 2c: 90 nop 2d: 90 nop 2e: 90 nop 2f: 90 nop 30: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi 37: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi