====================================================== WARNING: possible circular locking dependency detected 6.1.16-syzkaller #0 Not tainted ------------------------------------------------------ kworker/u4:16/4573 is trying to acquire lock: ffff88801eb40920 (&q->queue_lock){..-.}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:375 [inline] ffff88801eb40920 (&q->queue_lock){..-.}-{2:2}, at: throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 but task is already holding lock: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:41 [inline] ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbd/0x840 kernel/time/timer.c:1464 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 ((&sq->pending_timer)){+.-.}-{0:0}: lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 del_timer_sync+0x111/0x2e0 kernel/time/timer.c:1417 throtl_pd_free+0x15/0x40 block/blk-throttle.c:493 blkcg_deactivate_policy+0x32d/0x550 block/blk-cgroup.c:1499 blk_throtl_exit+0xa6/0x140 block/blk-throttle.c:2406 disk_release+0x1dd/0x380 block/genhd.c:1171 device_release+0x91/0x1c0 kobject_cleanup lib/kobject.c:681 [inline] kobject_release lib/kobject.c:712 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0x224/0x460 lib/kobject.c:729 do_floppy_init+0x373/0xc59 drivers/block/floppy.c:4758 async_run_entry_fn+0xa2/0x410 kernel/async.c:127 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #1 (&blkcg->lock){....}-{2:2}: lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:350 [inline] blkg_create+0xa94/0x1280 block/blk-cgroup.c:336 blkcg_init_disk+0xee/0x350 block/blk-cgroup.c:1260 __alloc_disk_node+0x2ce/0x590 block/genhd.c:1385 __blk_alloc_disk+0x2c/0x80 block/genhd.c:1424 brd_alloc+0x2f9/0x6a0 drivers/block/brd.c:397 brd_init+0x100/0x1c2 drivers/block/brd.c:484 do_one_initcall+0x2d6/0xa80 init/main.c:1303 do_initcall_level+0x157/0x207 init/main.c:1376 do_initcalls+0x49/0x86 init/main.c:1392 kernel_init_freeable+0x473/0x61f init/main.c:1631 kernel_init+0x19/0x290 init/main.c:1519 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #0 (&q->queue_lock){..-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:119 [inline] _raw_spin_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:170 spin_lock_irq include/linux/spinlock.h:375 [inline] throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 call_timer_fn+0x200/0x840 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers+0x67c/0x890 kernel/time/timer.c:1790 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1803 __do_softirq+0x30d/0xb1b kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x155/0x240 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649 fsnotify_parent include/linux/fsnotify.h:62 [inline] fsnotify_file include/linux/fsnotify.h:99 [inline] fsnotify_perm+0x358/0x590 include/linux/fsnotify.h:124 rw_verify_area fs/read_write.c:374 [inline] do_iter_read+0x1e1/0xc70 fs/read_write.c:791 lo_read_simple drivers/block/loop.c:290 [inline] do_req_filebacked drivers/block/loop.c:500 [inline] loop_handle_cmd drivers/block/loop.c:1873 [inline] loop_process_work+0xba6/0x21c0 drivers/block/loop.c:1908 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 other info that might help us debug this: Chain exists of: &q->queue_lock --> &blkcg->lock --> (&sq->pending_timer) Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock((&sq->pending_timer)); lock(&blkcg->lock); lock((&sq->pending_timer)); lock(&q->queue_lock); *** DEADLOCK *** 3 locks held by kworker/u4:16/4573: #0: ffff88801e9e1938 ((wq_completion)loop2){+.+.}-{0:0}, at: process_one_work+0x77b/0x1380 #1: ffffc90003b37d20 ((work_completion)(&worker->work)){+.+.}-{0:0}, at: process_one_work+0x7be/0x1380 kernel/workqueue.c:2264 #2: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:41 [inline] #2: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbd/0x840 kernel/time/timer.c:1464 stack backtrace: CPU: 1 PID: 4573 Comm: kworker/u4:16 Not tainted 6.1.16-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Workqueue: loop2 loop_workfn Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:119 [inline] _raw_spin_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:170 spin_lock_irq include/linux/spinlock.h:375 [inline] throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 call_timer_fn+0x200/0x840 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers+0x67c/0x890 kernel/time/timer.c:1790 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1803 __do_softirq+0x30d/0xb1b kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x155/0x240 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649 RIP: 0010:fsnotify_parent include/linux/fsnotify.h:62 [inline] RIP: 0010:fsnotify_file include/linux/fsnotify.h:99 [inline] RIP: 0010:fsnotify_perm+0x358/0x590 include/linux/fsnotify.h:124 Code: d8 48 c1 e8 03 42 80 3c 30 00 74 08 48 89 df e8 be 7d ee fd 48 8b 03 49 89 c4 48 8d 68 28 48 89 e8 48 c1 e8 03 42 80 3c 30 00 <74> 08 48 89 ef e8 9e 7d ee fd bb c8 07 00 00 48 03 5d 00 48 89 df RSP: 0018:ffffc90003b377f8 EFLAGS: 00000246 RAX: 1ffff11008114811 RBX: ffff888040d2f7e8 RCX: ffff88801dfe9d40 RDX: ffff88801dfe9d40 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffff8880408a4088 R08: ffffffff83f246f6 R09: fffffbfff1ca5386 R10: 0000000000000000 R11: dffffc0000000001 R12: ffff8880408a4060 R13: 0000000000020000 R14: dffffc0000000000 R15: dffffc0000000000 rw_verify_area fs/read_write.c:374 [inline] do_iter_read+0x1e1/0xc70 fs/read_write.c:791 lo_read_simple drivers/block/loop.c:290 [inline] do_req_filebacked drivers/block/loop.c:500 [inline] loop_handle_cmd drivers/block/loop.c:1873 [inline] loop_process_work+0xba6/0x21c0 drivers/block/loop.c:1908 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 ---------------- Code disassembly (best guess): 0: d8 48 c1 fmuls -0x3f(%rax) 3: e8 03 42 80 3c callq 0x3c80420b 8: 30 00 xor %al,(%rax) a: 74 08 je 0x14 c: 48 89 df mov %rbx,%rdi f: e8 be 7d ee fd callq 0xfdee7dd2 14: 48 8b 03 mov (%rbx),%rax 17: 49 89 c4 mov %rax,%r12 1a: 48 8d 68 28 lea 0x28(%rax),%rbp 1e: 48 89 e8 mov %rbp,%rax 21: 48 c1 e8 03 shr $0x3,%rax 25: 42 80 3c 30 00 cmpb $0x0,(%rax,%r14,1) * 2a: 74 08 je 0x34 <-- trapping instruction 2c: 48 89 ef mov %rbp,%rdi 2f: e8 9e 7d ee fd callq 0xfdee7dd2 34: bb c8 07 00 00 mov $0x7c8,%ebx 39: 48 03 5d 00 add 0x0(%rbp),%rbx 3d: 48 89 df mov %rbx,%rdi