====================================================== WARNING: possible circular locking dependency detected 6.1.137-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.2542/15261 is trying to acquire lock: ffff88805fe90650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_setattr+0xaa6/0x1cf0 fs/ocfs2/file.c:1263 but task is already holding lock: ffff88807f9c3f60 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xa97/0x1cf0 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){+.+.}-{3:3}: down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_try_remove_refcount_tree+0xb3/0x320 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x592/0x11e0 fs/ocfs2/xattr.c:3673 ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:1160 [inline] posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189 __vfs_removexattr+0x3b7/0x3f0 fs/xattr.c:479 __vfs_removexattr_locked+0x1e4/0x230 fs/xattr.c:514 vfs_removexattr+0x7d/0x1b0 fs/xattr.c:536 ovl_do_removexattr fs/overlayfs/overlayfs.h:270 [inline] ovl_workdir_create+0x3fb/0x7a0 fs/overlayfs/super.c:821 ovl_make_workdir fs/overlayfs/super.c:1389 [inline] ovl_get_workdir+0x388/0x1540 fs/overlayfs/super.c:1539 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095 mount_nodev+0x52/0xe0 fs/super.c:1489 legacy_get_tree+0xe6/0x180 fs/fs_context.c:632 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x24a/0xa40 fs/namespace.c:3057 do_mount fs/namespace.c:3400 [inline] __do_sys_mount fs/namespace.c:3608 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3585 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #3 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520 ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1463/0x2350 fs/ocfs2/namei.c:410 ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4106 do_mkdirat+0x1d0/0x430 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:354 ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361 ocfs2_create+0x1b6/0x4a0 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x1187/0x2e70 fs/namei.c:3780 do_filp_open+0x1c1/0x3c0 fs/namei.c:3810 do_sys_openat2+0x142/0x490 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x135/0x160 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:352 ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361 ocfs2_create+0x1b6/0x4a0 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x1187/0x2e70 fs/namei.c:3780 do_filp_open+0x1c1/0x3c0 fs/namei.c:3810 do_sys_openat2+0x142/0x490 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x135/0x160 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xaa6/0x1cf0 fs/ocfs2/file.c:1263 notify_change+0xc74/0xf40 fs/attr.c:499 ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline] ovl_workdir_create+0x5e1/0x7a0 fs/overlayfs/super.c:833 ovl_make_workdir fs/overlayfs/super.c:1389 [inline] ovl_get_workdir+0x388/0x1540 fs/overlayfs/super.c:1539 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095 mount_nodev+0x52/0xe0 fs/super.c:1489 legacy_get_tree+0xe6/0x180 fs/fs_context.c:632 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x24a/0xa40 fs/namespace.c:3057 do_mount fs/namespace.c:3400 [inline] __do_sys_mount fs/namespace.c:3608 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3585 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: sb_internal#3 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(&oi->ip_xattr_sem); lock(&oi->ip_alloc_sem); lock(sb_internal#3); *** DEADLOCK *** 5 locks held by syz.3.2542/15261: #0: ffff88807aa9a0e0 (&type->s_umount_key#78/1){+.+.}-{3:3}, at: alloc_super+0x1fa/0x930 fs/super.c:228 #1: ffff88805fe90460 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:393 #2: ffff88807f9c2648 (&sb->s_type->i_mutex_key#28/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #2: ffff88807f9c2648 (&sb->s_type->i_mutex_key#28/1){+.+.}-{3:3}, at: ovl_workdir_create+0x150/0x7a0 fs/overlayfs/super.c:771 #3: ffff88807f9c42c8 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff88807f9c42c8 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: ovl_workdir_create+0x55a/0x7a0 fs/overlayfs/super.c:832 #4: ffff88807f9c3f60 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xa97/0x1cf0 fs/ocfs2/file.c:1262 stack backtrace: CPU: 1 PID: 15261 Comm: syz.3.2542 Not tainted 6.1.137-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025 Call Trace: dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xaa6/0x1cf0 fs/ocfs2/file.c:1263 notify_change+0xc74/0xf40 fs/attr.c:499 ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline] ovl_workdir_create+0x5e1/0x7a0 fs/overlayfs/super.c:833 ovl_make_workdir fs/overlayfs/super.c:1389 [inline] ovl_get_workdir+0x388/0x1540 fs/overlayfs/super.c:1539 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095 mount_nodev+0x52/0xe0 fs/super.c:1489 legacy_get_tree+0xe6/0x180 fs/fs_context.c:632 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x24a/0xa40 fs/namespace.c:3057 do_mount fs/namespace.c:3400 [inline] __do_sys_mount fs/namespace.c:3608 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3585 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f932758e969 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f93283e8038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f93277b6080 RCX: 00007f932758e969 RDX: 0000200000000340 RSI: 00002000000000c0 RDI: 0000000000000000 RBP: 00007f9327610ab1 R08: 0000200000000080 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f93277b6080 R15: 00007ffc54d75a98 overlayfs: upper fs does not support tmpfile. (syz.3.2542,15261,0):ocfs2_check_dir_entry:325 ERROR: bad entry in directory #72: rec_len % 4 != 0 - offset=16, inode=66, rec_len=491, name_len=2 (syz.3.2542,15261,0):ocfs2_prepare_dir_for_insert:4311 ERROR: status = -2 (syz.3.2542,15261,0):__ocfs2_prepare_orphan_dir:2168 ERROR: status = -2 (syz.3.2542,15261,0):ocfs2_prepare_orphan_dir:2210 ERROR: status = -2 (syz.3.2542,15261,0):ocfs2_prepare_orphan_dir:2226 ERROR: status = -2 (syz.3.2542,15261,0):ocfs2_unlink:964 ERROR: status = -2 overlayfs: cleanup of 'work/#49' failed (-2) overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features.