device bridge_slave_1 left promiscuous mode bridge0: port 2(bridge_slave_1) entered disabled state device bridge_slave_0 left promiscuous mode bridge0: port 1(bridge_slave_0) entered disabled state ====================================================== WARNING: possible circular locking dependency detected 5.8.0-rc2-syzkaller #0 Not tainted ------------------------------------------------------ kworker/u4:0/16128 is trying to acquire lock: ffff88805e288280 (&macvlan_netdev_addr_lock_key/1){+...}-{2:2}, at: netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] ffff88805e288280 (&macvlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync net/core/dev_addr_lists.c:915 [inline] ffff88805e288280 (&macvlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync+0xf4/0x190 net/core/dev_addr_lists.c:909 but task is already holding lock: ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:358 [inline] ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: netif_addr_lock_bh include/linux/netdevice.h:4248 [inline] ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync net/core/dev_addr_lists.c:914 [inline] ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync+0xb0/0x190 net/core/dev_addr_lists.c:909 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}: _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:361 netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] dev_uc_unsync net/core/dev_addr_lists.c:694 [inline] dev_uc_unsync+0xf4/0x190 net/core/dev_addr_lists.c:688 macvlan_stop+0xfe/0x4c0 drivers/net/macvlan.c:678 __dev_close_many+0x1b3/0x2e0 net/core/dev.c:1605 dev_close_many+0x238/0x650 net/core/dev.c:1630 rollback_registered_many+0x3af/0xf60 net/core/dev.c:8953 unregister_netdevice_many.part.0+0x1a/0x2f0 net/core/dev.c:10121 unregister_netdevice_many+0x36/0x50 net/core/dev.c:10120 macvlan_device_event+0x5a7/0x9da drivers/net/macvlan.c:1733 notifier_call_chain+0xb5/0x200 kernel/notifier.c:83 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:2033 call_netdevice_notifiers_extack net/core/dev.c:2045 [inline] call_netdevice_notifiers net/core/dev.c:2059 [inline] rollback_registered_many+0x665/0xf60 net/core/dev.c:8976 rollback_registered net/core/dev.c:9021 [inline] unregister_netdevice_queue+0x2dd/0x570 net/core/dev.c:10102 unregister_vlan_dev+0x2c0/0x570 net/8021q/vlan.c:111 vlan_ioctl_handler+0x311/0xeed net/8021q/vlan.c:629 sock_ioctl+0x4d1/0x730 net/socket.c:1157 vfs_ioctl fs/ioctl.c:48 [inline] ksys_ioctl+0x11a/0x180 fs/ioctl.c:753 __do_sys_ioctl fs/ioctl.c:762 [inline] __se_sys_ioctl fs/ioctl.c:760 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:760 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:359 entry_SYSCALL_64_after_hwframe+0x44/0xa9 -> #0 (&macvlan_netdev_addr_lock_key/1){+...}-{2:2}: check_prev_add kernel/locking/lockdep.c:2496 [inline] check_prevs_add kernel/locking/lockdep.c:2601 [inline] validate_chain kernel/locking/lockdep.c:3218 [inline] __lock_acquire+0x2acb/0x56e0 kernel/locking/lockdep.c:4380 lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:4959 _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:361 netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] dev_mc_unsync net/core/dev_addr_lists.c:915 [inline] dev_mc_unsync+0xf4/0x190 net/core/dev_addr_lists.c:909 vlan_dev_stop+0x51/0x350 net/8021q/vlan_dev.c:315 __dev_close_many+0x1b3/0x2e0 net/core/dev.c:1605 dev_close_many+0x238/0x650 net/core/dev.c:1630 rollback_registered_many+0x3af/0xf60 net/core/dev.c:8953 unregister_netdevice_many.part.0+0x1a/0x2f0 net/core/dev.c:10121 unregister_netdevice_many net/core/dev.c:10120 [inline] default_device_exit_batch+0x30c/0x3d0 net/core/dev.c:10604 ops_exit_list+0x10d/0x160 net/core/net_namespace.c:189 cleanup_net+0x4ea/0xa00 net/core/net_namespace.c:603 process_one_work+0x94c/0x1670 kernel/workqueue.c:2269 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415 kthread+0x3b5/0x4a0 kernel/kthread.c:291 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&vlan_netdev_addr_lock_key/1); lock(&macvlan_netdev_addr_lock_key/1); lock(&vlan_netdev_addr_lock_key/1); lock(&macvlan_netdev_addr_lock_key/1); *** DEADLOCK *** 5 locks held by kworker/u4:0/16128: #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: atomic64_set include/asm-generic/atomic-instrumented.h:856 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: atomic_long_set include/asm-generic/atomic-long.h:41 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:616 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:643 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: process_one_work+0x82b/0x1670 kernel/workqueue.c:2240 #1: ffffc90005287da8 (net_cleanup_work){+.+.}-{0:0}, at: process_one_work+0x85f/0x1670 kernel/workqueue.c:2244 #2: ffffffff8a7a3a70 (pernet_ops_rwsem){++++}-{3:3}, at: cleanup_net+0x9b/0xa00 net/core/net_namespace.c:565 #3: ffffffff8a7b08e8 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock_unregistering net/core/dev.c:10557 [inline] #3: ffffffff8a7b08e8 (rtnl_mutex){+.+.}-{3:3}, at: default_device_exit_batch+0xea/0x3d0 net/core/dev.c:10595 #4: ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:358 [inline] #4: ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: netif_addr_lock_bh include/linux/netdevice.h:4248 [inline] #4: ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync net/core/dev_addr_lists.c:914 [inline] #4: ffff88808f06c280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync+0xb0/0x190 net/core/dev_addr_lists.c:909 stack backtrace: CPU: 0 PID: 16128 Comm: kworker/u4:0 Not tainted 5.8.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: netns cleanup_net Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x18f/0x20d lib/dump_stack.c:118 check_noncircular+0x324/0x3e0 kernel/locking/lockdep.c:1827 check_prev_add kernel/locking/lockdep.c:2496 [inline] check_prevs_add kernel/locking/lockdep.c:2601 [inline] validate_chain kernel/locking/lockdep.c:3218 [inline] __lock_acquire+0x2acb/0x56e0 kernel/locking/lockdep.c:4380 lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:4959 _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:361 netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] dev_mc_unsync net/core/dev_addr_lists.c:915 [inline] dev_mc_unsync+0xf4/0x190 net/core/dev_addr_lists.c:909 vlan_dev_stop+0x51/0x350 net/8021q/vlan_dev.c:315 __dev_close_many+0x1b3/0x2e0 net/core/dev.c:1605 dev_close_many+0x238/0x650 net/core/dev.c:1630 rollback_registered_many+0x3af/0xf60 net/core/dev.c:8953 unregister_netdevice_many.part.0+0x1a/0x2f0 net/core/dev.c:10121 unregister_netdevice_many net/core/dev.c:10120 [inline] default_device_exit_batch+0x30c/0x3d0 net/core/dev.c:10604 ops_exit_list+0x10d/0x160 net/core/net_namespace.c:189 cleanup_net+0x4ea/0xa00 net/core/net_namespace.c:603 process_one_work+0x94c/0x1670 kernel/workqueue.c:2269 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415 kthread+0x3b5/0x4a0 kernel/kthread.c:291 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 device veth1_macvtap left promiscuous mode device veth0_macvtap left promiscuous mode device veth1_vlan left promiscuous mode device veth0_vlan left promiscuous mode bond9 (unregistering): (slave bridge12): Releasing backup interface bond9 (unregistering): Released all slaves bond0 (unregistering): (slave bridge10): Releasing backup interface bond8 (unregistering): Released all slaves bond7 (unregistering): Released all slaves bond6 (unregistering): (slave bridge7): Releasing backup interface bond6 (unregistering): (slave bridge6): Releasing backup interface device bridge6 left promiscuous mode bond6 (unregistering): Released all slaves bond5 (unregistering): Released all slaves bond4 (unregistering): Released all slaves bond3 (unregistering): Released all slaves bond2 (unregistering): Released all slaves bond1 (unregistering): Released all slaves team0 (unregistering): Port device team_slave_1 removed team0 (unregistering): Port device team_slave_0 removed bond0 (unregistering): (slave bond_slave_1): Releasing backup interface bond0 (unregistering): (slave bond_slave_0): Releasing backup interface bond0 (unregistering): Released all slaves tipc: TX() has been purged, node left! tipc: TX() has been purged, node left!