ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode. ====================================================== WARNING: possible circular locking dependency detected 5.15.173-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.4457/14275 is trying to acquire lock: ffff88807bcec650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266 but task is already holding lock: ffff8880628122e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xbd1/0x1ce0 fs/ocfs2/file.c:1265 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0xa4b/0x1930 fs/ocfs2/xattr.c:3673 ocfs2_set_acl+0x4cb/0x570 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x252/0x3c0 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x33b/0x3a0 fs/posix_acl.c:966 __vfs_removexattr+0x3ce/0x410 fs/xattr.c:470 __vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:505 vfs_removexattr+0xff/0x2a0 fs/xattr.c:527 removexattr fs/xattr.c:857 [inline] path_removexattr+0x22a/0x320 fs/xattr.c:871 __do_sys_lremovexattr fs/xattr.c:891 [inline] __se_sys_lremovexattr fs/xattr.c:888 [inline] __x64_sys_lremovexattr+0x59/0x70 fs/xattr.c:888 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #3 (&oi->ip_xattr_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1e8f/0x2cd0 fs/ocfs2/namei.c:408 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_open fs/open.c:1277 [inline] __se_sys_open fs/open.c:1273 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1273 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354 ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:359 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_open fs/open.c:1277 [inline] __se_sys_open fs/open.c:1273 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1273 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352 ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:359 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_open fs/open.c:1277 [inline] __se_sys_open fs/open.c:1273 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1273 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266 notify_change+0xc6d/0xf50 fs/attr.c:505 chmod_common+0x2a7/0x4b0 fs/open.c:582 do_fchmodat fs/open.c:621 [inline] __do_sys_chmod fs/open.c:639 [inline] __se_sys_chmod fs/open.c:637 [inline] __x64_sys_chmod+0xf4/0x180 fs/open.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: sb_internal#4 --> &oi->ip_xattr_sem --> &ocfs2_file_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(&oi->ip_xattr_sem); lock(&ocfs2_file_ip_alloc_sem_key); lock(sb_internal#4); *** DEADLOCK *** 3 locks held by syz.2.4457/14275: #0: ffff88807bcec460 (sb_writers#29){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff888062812648 (&type->i_mutex_dir_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff888062812648 (&type->i_mutex_dir_key#26){+.+.}-{3:3}, at: chmod_common+0x1b7/0x4b0 fs/open.c:576 #2: ffff8880628122e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xbd1/0x1ce0 fs/ocfs2/file.c:1265 stack backtrace: CPU: 1 PID: 14275 Comm: syz.2.4457 Not tainted 5.15.173-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266 notify_change+0xc6d/0xf50 fs/attr.c:505 chmod_common+0x2a7/0x4b0 fs/open.c:582 do_fchmodat fs/open.c:621 [inline] __do_sys_chmod fs/open.c:639 [inline] __se_sys_chmod fs/open.c:637 [inline] __x64_sys_chmod+0xf4/0x180 fs/open.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f2516cf1919 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f2514b69038 EFLAGS: 00000246 ORIG_RAX: 000000000000005a RAX: ffffffffffffffda RBX: 00007f2516ea8fa0 RCX: 00007f2516cf1919 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000180 RBP: 00007f2516d6497e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f2516ea8fa0 R15: 00007ffce159a208