====================================================== WARNING: possible circular locking dependency detected 6.2.0-syzkaller-13194-g5af607a861d4 #0 Not tainted ------------------------------------------------------ syz-executor.0/6927 is trying to acquire lock: ffff88814b5d23f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x238/0x4b0 fs/jbd2/checkpoint.c:110 but task is already holding lock: ffff88814b5d0b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: do_writepages+0x1a8/0x640 mm/page-writeback.c:2551 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_write+0x53/0x390 kernel/locking/percpu-rwsem.c:227 ext4_ind_migrate+0x23b/0x860 fs/ext4/migrate.c:624 ext4_ioctl_setflags fs/ext4/ioctl.c:696 [inline] ext4_fileattr_set+0x1582/0x1a50 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x7ff/0xc40 fs/ioctl.c:696 ioctl_fssetxattr fs/ioctl.c:758 [inline] do_vfs_ioctl+0xfa8/0x1670 fs/ioctl.c:845 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:768 [inline] ext4_bmap+0x52/0x470 fs/ext4/inode.c:3242 bmap+0xae/0x120 fs/inode.c:1799 jbd2_journal_bmap+0xac/0x1c0 fs/jbd2/journal.c:976 __jbd2_journal_erase fs/jbd2/journal.c:1788 [inline] jbd2_journal_flush+0x87b/0xc90 fs/jbd2/journal.c:2491 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0xb3f/0x4c90 fs/ext4/ioctl.c:1590 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x143/0x11a0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x238/0x4b0 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14e0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x39d/0x9d0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x706/0x890 fs/ext4/ext4_jbd2.c:111 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_do_writepages+0x12bf/0x3750 fs/ext4/inode.c:2859 ext4_writepages+0x27c/0x5e0 fs/ext4/inode.c:2964 do_writepages+0x1a8/0x640 mm/page-writeback.c:2551 filemap_fdatawrite_wbc mm/filemap.c:390 [inline] filemap_fdatawrite_wbc+0x147/0x1b0 mm/filemap.c:380 __filemap_fdatawrite_range+0xb8/0xf0 mm/filemap.c:423 filemap_write_and_wait_range mm/filemap.c:678 [inline] filemap_write_and_wait_range+0xa1/0x120 mm/filemap.c:669 __iomap_dio_rw+0x5ea/0x1d80 fs/iomap/direct-io.c:566 iomap_dio_rw+0x40/0xa0 fs/iomap/direct-io.c:683 ext4_dio_write_iter fs/ext4/file.c:587 [inline] ext4_file_write_iter+0x1053/0x1710 fs/ext4/file.c:698 call_write_iter include/linux/fs.h:1851 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x9f6/0xe20 fs/read_write.c:584 ksys_write+0x12b/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &journal->j_checkpoint_mutex --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 4 locks held by syz-executor.0/6927: #0: ffff888028c68fe8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xe7/0x100 fs/file.c:1046 #1: ffff88814b5ce460 (sb_writers#4){.+.+}-{0:0}, at: ksys_write+0x12b/0x250 fs/read_write.c:637 #2: ffff888048828e08 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff888048828e08 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_dio_write_iter fs/ext4/file.c:525 [inline] #2: ffff888048828e08 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_file_write_iter+0xcb5/0x1710 fs/ext4/file.c:698 #3: ffff88814b5d0b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: do_writepages+0x1a8/0x640 mm/page-writeback.c:2551 stack backtrace: CPU: 1 PID: 6927 Comm: syz-executor.0 Not tainted 6.2.0-syzkaller-13194-g5af607a861d4 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x143/0x11a0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x238/0x4b0 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14e0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x39d/0x9d0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x706/0x890 fs/ext4/ext4_jbd2.c:111 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_do_writepages+0x12bf/0x3750 fs/ext4/inode.c:2859 ext4_writepages+0x27c/0x5e0 fs/ext4/inode.c:2964 do_writepages+0x1a8/0x640 mm/page-writeback.c:2551 filemap_fdatawrite_wbc mm/filemap.c:390 [inline] filemap_fdatawrite_wbc+0x147/0x1b0 mm/filemap.c:380 __filemap_fdatawrite_range+0xb8/0xf0 mm/filemap.c:423 filemap_write_and_wait_range mm/filemap.c:678 [inline] filemap_write_and_wait_range+0xa1/0x120 mm/filemap.c:669 __iomap_dio_rw+0x5ea/0x1d80 fs/iomap/direct-io.c:566 iomap_dio_rw+0x40/0xa0 fs/iomap/direct-io.c:683 ext4_dio_write_iter fs/ext4/file.c:587 [inline] ext4_file_write_iter+0x1053/0x1710 fs/ext4/file.c:698 call_write_iter include/linux/fs.h:1851 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x9f6/0xe20 fs/read_write.c:584 ksys_write+0x12b/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7feb6f08c169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007feb6fe61168 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007feb6f1abf80 RCX: 00007feb6f08c169 RDX: 000000000002300e RSI: 0000000020000200 RDI: 0000000000000005 RBP: 00007feb6f0e7ca1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffca84f25bf R14: 00007feb6fe61300 R15: 0000000000022000