====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc7-syzkaller-00185-g28f20a19294d #0 Not tainted ------------------------------------------------------ syz-executor.4/16827 is trying to acquire lock: ffff888023676120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 but task is already holding lock: ffff888044a734a0 (&ni->ni_lock#2){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline] ffff888044a734a0 (&ni->ni_lock#2){+.+.}-{3:3}, at: ni_write_inode+0x167/0x10a0 fs/ntfs3/frecord.c:3256 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->ni_lock#2){+.+.}-{3:3}: __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 ntfs_set_state+0x212/0x730 fs/ntfs3/fsntfs.c:946 attr_set_size+0x3311/0x4290 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x2fa/0x4b0 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x9bd/0x1480 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x365/0xbe0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xabc/0x16c0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x14f/0x500 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x933/0xb00 fs/ntfs3/file.c:708 notify_change+0xc8b/0xf40 fs/attr.c:483 chown_common+0x500/0x850 fs/open.c:768 do_fchownat+0x16d/0x240 fs/open.c:799 __do_sys_chown fs/open.c:819 [inline] __se_sys_chown fs/open.c:817 [inline] __x64_sys_chown+0x82/0x90 fs/open.c:817 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&ni->file.run_lock#2){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:511 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ntfs_create_inode+0x524/0x3850 fs/ntfs3/inode.c:1308 ntfs_atomic_open+0x423/0x570 fs/ntfs3/namei.c:425 atomic_open fs/namei.c:3355 [inline] lookup_open fs/namei.c:3463 [inline] open_last_lookups fs/namei.c:3560 [inline] path_openat+0x1044/0x3180 fs/namei.c:3790 do_filp_open+0x234/0x490 fs/namei.c:3820 do_sys_openat2+0x13e/0x1d0 fs/open.c:1407 do_sys_open fs/open.c:1422 [inline] __do_sys_open fs/open.c:1430 [inline] __se_sys_open fs/open.c:1426 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1426 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&wnd->rw_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x516/0x10a0 fs/ntfs3/frecord.c:3352 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0x69b/0xfa0 fs/fs-writeback.c:1668 writeback_single_inode+0x21b/0x790 fs/fs-writeback.c:1724 write_inode_now+0x1d3/0x260 fs/fs-writeback.c:2766 ntfs_extend+0x39a/0x490 fs/ntfs3/file.c:355 ntfs_file_write_iter+0x308/0x6d0 fs/ntfs3/file.c:1076 call_write_iter include/linux/fs.h:1877 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x782/0xaf0 fs/read_write.c:584 ksys_write+0x1a0/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &wnd->rw_lock/1 --> &ni->file.run_lock#2 --> &ni->ni_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock#2); lock(&ni->file.run_lock#2); lock(&ni->ni_lock#2); lock(&wnd->rw_lock/1); *** DEADLOCK *** 4 locks held by syz-executor.4/16827: #0: ffff88807591d248 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2b0/0x340 fs/file.c:1062 #1: ffff88802a9d6410 (sb_writers#25){.+.+}-{0:0}, at: vfs_write+0x216/0xaf0 fs/read_write.c:580 #2: ffff888044a73740 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:791 [inline] #2: ffff888044a73740 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: ntfs_file_write_iter+0x1cb/0x6d0 fs/ntfs3/file.c:1060 #3: ffff888044a734a0 (&ni->ni_lock#2){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline] #3: ffff888044a734a0 (&ni->ni_lock#2){+.+.}-{3:3}, at: ni_write_inode+0x167/0x10a0 fs/ntfs3/frecord.c:3256 stack backtrace: CPU: 1 PID: 16827 Comm: syz-executor.4 Not tainted 6.5.0-rc7-syzkaller-00185-g28f20a19294d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x516/0x10a0 fs/ntfs3/frecord.c:3352 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0x69b/0xfa0 fs/fs-writeback.c:1668 writeback_single_inode+0x21b/0x790 fs/fs-writeback.c:1724 write_inode_now+0x1d3/0x260 fs/fs-writeback.c:2766 ntfs_extend+0x39a/0x490 fs/ntfs3/file.c:355 ntfs_file_write_iter+0x308/0x6d0 fs/ntfs3/file.c:1076 call_write_iter include/linux/fs.h:1877 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x782/0xaf0 fs/read_write.c:584 ksys_write+0x1a0/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f1b4ec7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1b4f9460c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f1b4ed9bf80 RCX: 00007f1b4ec7cae9 RDX: 0000000000000050 RSI: 00000000200029c0 RDI: 0000000000000004 RBP: 00007f1b4ecc847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f1b4ed9bf80 R15: 00007fffa47e4c88