====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-00062-gc061cf420ded #0 Not tainted ------------------------------------------------------ syz.8.3964/24008 is trying to acquire lock: ffff888058279800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] ffff888058279800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xd2e/0x2a30 fs/ocfs2/xattr.c:3622 but task is already holding lock: ffff88805659ce38 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x416/0x2a30 fs/ocfs2/xattr.c:3583 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&oi->ip_xattr_sem){++++}-{4:4}: down_read+0x9a/0x330 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x2fd/0x7d0 fs/ocfs2/acl.c:366 ocfs2_mknod+0xd0a/0x2440 fs/ocfs2/namei.c:410 ocfs2_create+0x185/0x450 fs/ocfs2/namei.c:674 lookup_open.isra.0+0x1177/0x14c0 fs/namei.c:3649 open_last_lookups fs/namei.c:3748 [inline] path_openat+0x904/0x2d60 fs/namei.c:3984 do_filp_open+0x20c/0x470 fs/namei.c:4014 do_sys_openat2+0x17a/0x1e0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __x64_sys_openat+0x175/0x210 fs/open.c:1428 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (jbd2_handle){++++}-{0:0}: jbd2_journal_lock_updates+0xa5/0x340 fs/jbd2/transaction.c:865 __ocfs2_flush_truncate_log+0x28e/0x1150 fs/ocfs2/alloc.c:6029 ocfs2_flush_truncate_log+0x4a/0x70 fs/ocfs2/alloc.c:6076 ocfs2_sync_fs+0x1c8/0x3d0 fs/ocfs2/super.c:402 sync_filesystem+0x1cf/0x290 fs/sync.c:66 ocfs2_remount+0xc5/0xd10 fs/ocfs2/super.c:611 legacy_reconfigure+0x11c/0x180 fs/fs_context.c:685 reconfigure_super+0x452/0xb60 fs/super.c:1083 do_remount fs/namespace.c:3047 [inline] path_mount+0x172d/0x1f20 fs/namespace.c:3826 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount fs/namespace.c:4034 [inline] __x64_sys_mount+0x294/0x320 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849 down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_xattr_set+0xd2e/0x2a30 fs/ocfs2/xattr.c:3622 __vfs_setxattr+0x176/0x1e0 fs/xattr.c:200 __vfs_setxattr_noperm+0x127/0x660 fs/xattr.c:234 __vfs_setxattr_locked+0x182/0x260 fs/xattr.c:295 vfs_setxattr+0x146/0x360 fs/xattr.c:321 do_setxattr+0x142/0x170 fs/xattr.c:636 filename_setxattr+0x16d/0x1d0 fs/xattr.c:665 path_setxattrat+0x1e0/0x290 fs/xattr.c:713 __do_sys_lsetxattr fs/xattr.c:754 [inline] __se_sys_lsetxattr fs/xattr.c:750 [inline] __x64_sys_lsetxattr+0xc9/0x140 fs/xattr.c:750 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); *** DEADLOCK *** 3 locks held by syz.8.3964/24008: #0: ffff88803078c420 (sb_writers#30){.+.+}-{0:0}, at: filename_setxattr+0xbc/0x1d0 fs/xattr.c:663 #1: ffff88805659d100 (&sb->s_type->i_mutex_key#37){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #1: ffff88805659d100 (&sb->s_type->i_mutex_key#37){+.+.}-{4:4}, at: vfs_setxattr+0x123/0x360 fs/xattr.c:320 #2: ffff88805659ce38 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x416/0x2a30 fs/ocfs2/xattr.c:3583 stack backtrace: CPU: 1 UID: 0 PID: 24008 Comm: syz.8.3964 Not tainted 6.13.0-rc3-syzkaller-00062-gc061cf420ded #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x419/0x5d0 kernel/locking/lockdep.c:2074 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849 down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_xattr_set+0xd2e/0x2a30 fs/ocfs2/xattr.c:3622 __vfs_setxattr+0x176/0x1e0 fs/xattr.c:200 __vfs_setxattr_noperm+0x127/0x660 fs/xattr.c:234 __vfs_setxattr_locked+0x182/0x260 fs/xattr.c:295 vfs_setxattr+0x146/0x360 fs/xattr.c:321 do_setxattr+0x142/0x170 fs/xattr.c:636 filename_setxattr+0x16d/0x1d0 fs/xattr.c:665 path_setxattrat+0x1e0/0x290 fs/xattr.c:713 __do_sys_lsetxattr fs/xattr.c:754 [inline] __se_sys_lsetxattr fs/xattr.c:750 [inline] __x64_sys_lsetxattr+0xc9/0x140 fs/xattr.c:750 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f42ad585d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f42ae38f038 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd RAX: ffffffffffffffda RBX: 00007f42ad775fa0 RCX: 00007f42ad585d29 RDX: 0000000020000200 RSI: 00000000200000c0 RDI: 0000000020000100 RBP: 00007f42ad601a20 R08: 0000000000000000 R09: 0000000000000000 R10: 000000000000fe37 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f42ad775fa0 R15: 00007ffe290c1518