ntfs3: loop1: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc6-syzkaller-00039-g06dc10eae55b #0 Not tainted ------------------------------------------------------ syz-executor.1/11692 is trying to acquire lock: ffff8880292ea120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 but task is already holding lock: ffff888055c725e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline] ffff888055c725e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x163/0x1070 fs/ntfs3/frecord.c:3256 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->ni_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ntfs_set_state+0x212/0x730 fs/ntfs3/fsntfs.c:946 attr_set_size+0x3311/0x4290 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x2fa/0x4b0 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x9bd/0x1480 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x365/0xbe0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xabc/0x16c0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x14f/0x500 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x916/0xae0 fs/ntfs3/file.c:708 notify_change+0xb99/0xe60 fs/attr.c:499 chown_common+0x500/0x850 fs/open.c:783 do_fchownat+0x16d/0x240 fs/open.c:814 __do_sys_lchown fs/open.c:839 [inline] __se_sys_lchown fs/open.c:837 [inline] __x64_sys_lchown+0x85/0x90 fs/open.c:837 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&ni->file.run_lock#2){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:511 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x9bd/0x1480 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x365/0xbe0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xabc/0x16c0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x14f/0x500 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x916/0xae0 fs/ntfs3/file.c:708 notify_change+0xb99/0xe60 fs/attr.c:499 chown_common+0x500/0x850 fs/open.c:783 do_fchownat+0x16d/0x240 fs/open.c:814 __do_sys_lchown fs/open.c:839 [inline] __se_sys_lchown fs/open.c:837 [inline] __x64_sys_lchown+0x85/0x90 fs/open.c:837 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&wnd->rw_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x54f/0x1070 fs/ntfs3/frecord.c:3353 ntfs_truncate fs/ntfs3/file.c:407 [inline] ntfs3_setattr+0x725/0xae0 fs/ntfs3/file.c:682 notify_change+0xb99/0xe60 fs/attr.c:499 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3298 [inline] do_open fs/namei.c:3643 [inline] path_openat+0x2959/0x3180 fs/namei.c:3796 do_filp_open+0x234/0x490 fs/namei.c:3823 do_sys_openat2+0x13e/0x1d0 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_open fs/open.c:1445 [inline] __se_sys_open fs/open.c:1441 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1441 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &wnd->rw_lock/1 --> &ni->file.run_lock#2 --> &ni->ni_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->file.run_lock#2); lock(&ni->ni_lock); lock(&wnd->rw_lock/1); *** DEADLOCK *** 3 locks held by syz-executor.1/11692: #0: ffff888073cf0410 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:403 #1: ffff888055c72880 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff888055c72880 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: do_truncate+0x20c/0x300 fs/open.c:64 #2: ffff888055c725e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline] #2: ffff888055c725e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x163/0x1070 fs/ntfs3/frecord.c:3256 stack backtrace: CPU: 0 PID: 11692 Comm: syz-executor.1 Not tainted 6.6.0-rc6-syzkaller-00039-g06dc10eae55b #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x54f/0x1070 fs/ntfs3/frecord.c:3353 ntfs_truncate fs/ntfs3/file.c:407 [inline] ntfs3_setattr+0x725/0xae0 fs/ntfs3/file.c:682 notify_change+0xb99/0xe60 fs/attr.c:499 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3298 [inline] do_open fs/namei.c:3643 [inline] path_openat+0x2959/0x3180 fs/namei.c:3796 do_filp_open+0x234/0x490 fs/namei.c:3823 do_sys_openat2+0x13e/0x1d0 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_open fs/open.c:1445 [inline] __se_sys_open fs/open.c:1441 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1441 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7feee5c7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007feee6a620c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000002 RAX: ffffffffffffffda RBX: 00007feee5d9bf80 RCX: 00007feee5c7cae9 RDX: 0000000000000000 RSI: 0000000000004200 RDI: 00000000200000c0 RBP: 00007feee5cc847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007feee5d9bf80 R15: 00007ffc5df20118