====================================================== WARNING: possible circular locking dependency detected 6.7.0-syzkaller-12824-g9d64bf433c53 #0 Not tainted ------------------------------------------------------ syz-executor.5/3994 is trying to acquire lock: ffff888035fcc8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0xe5/0x990 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff88805aa4ed08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752 hfsplus_get_block+0x277/0x9e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x38f/0xa60 fs/buffer.c:2382 filemap_read_folio+0xe9/0x2c0 mm/filemap.c:2324 do_read_cache_folio+0x205/0x540 mm/filemap.c:3703 do_read_cache_page mm/filemap.c:3769 [inline] read_cache_page+0x5b/0x160 mm/filemap.c:3778 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0x144/0x990 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_get_block+0x1ae/0x9e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x4fb/0x16e0 fs/buffer.c:2103 __block_write_begin fs/buffer.c:2152 [inline] block_write_begin+0xb1/0x490 fs/buffer.c:2211 cont_write_begin+0x530/0x730 fs/buffer.c:2565 hfsplus_write_begin+0x87/0x140 fs/hfsplus/inode.c:47 page_symlink+0x391/0x490 fs/namei.c:5228 hfsplus_symlink+0xd3/0x2b0 fs/hfsplus/dir.c:449 vfs_symlink fs/namei.c:4480 [inline] vfs_symlink+0x3e4/0x620 fs/namei.c:4464 do_symlinkat+0x25f/0x310 fs/namei.c:4506 __do_sys_symlink fs/namei.c:4527 [inline] __se_sys_symlink fs/namei.c:4525 [inline] __x64_sys_symlink+0x79/0x90 fs/namei.c:4525 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2445/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752 hfsplus_block_allocate+0xe5/0x990 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x48e/0x7f0 fs/hfsplus/dir.c:376 hfsplus_rename+0xbc/0x200 fs/hfsplus/dir.c:547 vfs_rename+0xf83/0x20a0 fs/namei.c:4879 do_renameat2+0xc50/0xdc0 fs/namei.c:5036 __do_sys_rename fs/namei.c:5083 [inline] __se_sys_rename fs/namei.c:5081 [inline] __x64_sys_rename+0x81/0xa0 fs/namei.c:5081 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 7 locks held by syz-executor.5/3994: #0: ffff88807c67a420 (sb_writers#20){.+.+}-{0:0}, at: do_renameat2+0x3d2/0xdc0 fs/namei.c:4966 #1: ffff88805aa4c680 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #1: ffff88805aa4c680 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3065 [inline] #1: ffff88805aa4c680 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3062 [inline] #1: ffff88805aa4c680 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: do_renameat2+0xad5/0xdc0 fs/namei.c:4971 #2: ffff88805aa4dac0 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #2: ffff88805aa4dac0 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: lock_two_nondirectories+0xd1/0x200 fs/inode.c:1109 #3: ffff88805aa4e180 (&sb->s_type->i_mutex_key#26/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #3: ffff88805aa4e180 (&sb->s_type->i_mutex_key#26/4){+.+.}-{3:3}, at: lock_two_nondirectories+0xed/0x200 fs/inode.c:1111 #4: ffff888035fcc998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x184/0x7f0 fs/hfsplus/dir.c:370 #5: ffff888079eb00b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a3/0x200 fs/hfsplus/bfind.c:30 #6: ffff88805aa4ed08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 3994 Comm: syz-executor.5 Not tainted 6.7.0-syzkaller-12824-g9d64bf433c53 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x317/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2445/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752 hfsplus_block_allocate+0xe5/0x990 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x48e/0x7f0 fs/hfsplus/dir.c:376 hfsplus_rename+0xbc/0x200 fs/hfsplus/dir.c:547 vfs_rename+0xf83/0x20a0 fs/namei.c:4879 do_renameat2+0xc50/0xdc0 fs/namei.c:5036 __do_sys_rename fs/namei.c:5083 [inline] __se_sys_rename fs/namei.c:5081 [inline] __x64_sys_rename+0x81/0xa0 fs/namei.c:5081 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f1c0847cda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1c091da0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f1c085ac050 RCX: 00007f1c0847cda9 RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000020000b00 RBP: 00007f1c084c947a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f1c085ac050 R15: 00007ffcc0dbf5f8