(syz.4.410,7437,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xc2d589a7, computed 0x6a4501d0. Applying ECC. ====================================================== WARNING: possible circular locking dependency detected 6.1.129-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.410/7437 is trying to acquire lock: ffff0000df3194a0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 but task is already holding lock: ffff0000df319808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff0000df319808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:816 dqget+0x660/0xcec fs/quota/dquot.c:988 ocfs2_setattr+0x1044/0x1b5c fs/ocfs2/file.c:1243 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6771 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6831 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_free_space+0x840/0xce4 fs/quota/dquot.c:1942 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline] ext4_free_blocks+0x1b14/0x2b64 fs/ext4/mballoc.c:6273 ext4_remove_blocks fs/ext4/extents.c:2525 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline] ext4_ext_remove_space+0x1acc/0x42ec fs/ext4/extents.c:2939 ext4_ext_truncate+0x168/0x210 fs/ext4/extents.c:4469 ext4_truncate+0xa08/0x1178 fs/ext4/inode.c:4288 ext4_evict_inode+0xc3c/0x12cc fs/ext4/inode.c:286 evict+0x418/0x894 fs/inode.c:705 iput_final fs/inode.c:1834 [inline] iput+0x7c0/0x8a4 fs/inode.c:1860 d_delete_notify include/linux/fsnotify.h:267 [inline] vfs_rmdir+0x330/0x43c fs/namei.c:4204 do_rmdir+0x2e0/0x720 fs/namei.c:4252 __do_sys_unlinkat fs/namei.c:4432 [inline] __se_sys_unlinkat fs/namei.c:4426 [inline] __arm64_sys_unlinkat+0xe0/0xfc fs/namei.c:4426 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #4 (&ei->i_data_sem){++++}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283 ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5601 notify_change+0xb58/0xe1c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:65 do_sys_ftruncate+0x288/0x31c fs/open.c:193 __do_sys_ftruncate fs/open.c:204 [inline] __se_sys_ftruncate fs/open.c:202 [inline] __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354 ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879 ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609 generic_shutdown_super+0x130/0x328 fs/super.c:501 kill_block_super+0x70/0xdc fs/super.c:1470 deactivate_locked_super+0xac/0x124 fs/super.c:332 deactivate_super+0xf0/0x110 fs/super.c:363 cleanup_mnt+0x394/0x41c fs/namespace.c:1186 __cleanup_mnt+0x20/0x30 fs/namespace.c:1193 task_work_run+0x240/0x2f0 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] do_notify_resume+0x2080/0x2cb8 arch/arm64/kernel/signal.c:1132 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879 ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609 generic_shutdown_super+0x130/0x328 fs/super.c:501 kill_block_super+0x70/0xdc fs/super.c:1470 deactivate_locked_super+0xac/0x124 fs/super.c:332 deactivate_super+0xf0/0x110 fs/super.c:363 cleanup_mnt+0x394/0x41c fs/namespace.c:1186 __cleanup_mnt+0x20/0x30 fs/namespace.c:1193 task_work_run+0x240/0x2f0 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] do_notify_resume+0x2080/0x2cb8 arch/arm64/kernel/signal.c:1132 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (sb_internal#3){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350 ocfs2_write_info+0x114/0x354 fs/ocfs2/quota_global.c:982 dquot_set_dqinfo+0x398/0x5f4 fs/quota/dquot.c:2911 quota_setinfo+0x3b0/0x4fc fs/quota/quota.c:174 do_quotactl+0x4c0/0x698 fs/quota/quota.c:796 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl fs/quota/quota.c:916 [inline] __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:816 dqget+0x660/0xcec fs/quota/dquot.c:988 ocfs2_setattr+0x1044/0x1b5c fs/ocfs2/file.c:1243 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8); lock(&dquot->dq_lock); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8); lock(&ocfs2_quota_ip_alloc_sem_key); *** DEADLOCK *** 4 locks held by syz.4.410/7437: #0: ffff0000d12bc460 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437 #1: ffff0000df31a648 (&type->i_mutex_dir_key#10){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000df31a648 (&type->i_mutex_dir_key#10){++++}-{3:3}, at: chown_common+0x358/0x7d8 fs/open.c:726 #2: ffff0000f4bf60a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:811 #3: ffff0000df319808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff0000df319808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 stack backtrace: CPU: 1 PID: 7437 Comm: syz.4.410 Not tainted 6.1.129-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:816 dqget+0x660/0xcec fs/quota/dquot.c:988 ocfs2_setattr+0x1044/0x1b5c fs/ocfs2/file.c:1243 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 (syz.4.410,7437,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x7d05e7ff, computed 0x7dc2e7ff. Applying ECC. (syz.4.410,7437,0):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x7d05e7ff, computed 0x7dc2e7ff (syz.4.410,7437,0):ocfs2_read_quota_phys_block:160 ERROR: status = -5 (syz.4.410,7437,0):ocfs2_quota_read:201 ERROR: status = -5 Quota error (device loop4): find_tree_dqentry: Can't read quota tree block 2 Quota error (device loop4): qtree_read_dquot: Can't read quota structure for id 60929 (syz.4.410,7437,0):ocfs2_acquire_dquot:878 ERROR: status = -5 (syz.4.410,7437,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x7d05e7ff, computed 0x7dc2e7ff. Applying ECC. (syz.4.410,7437,0):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x7d05e7ff, computed 0x7dc2e7ff (syz.4.410,7437,0):ocfs2_read_quota_phys_block:160 ERROR: status = -5 (syz.4.410,7437,0):ocfs2_quota_read:201 ERROR: status = -5 Quota error (device loop4): find_tree_dqentry: Can't read quota tree block 2 Quota error (device loop4): qtree_read_dquot: Can't read quota structure for id 0 (syz.4.410,7437,0):ocfs2_acquire_dquot:878 ERROR: status = -5 (syz.4.410,7437,0):ocfs2_mknod:314 ERROR: status = -5 (syz.4.410,7437,0):ocfs2_mknod:502 ERROR: status = -5 (syz.4.410,7437,0):ocfs2_create:676 ERROR: status = -5