====================================================== WARNING: possible circular locking dependency detected 6.1.0-rc6-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/24439 is trying to acquire lock: ffff88805d120650 (sb_internal#3){.+.+}-{0:0}, at: btrfs_dirty_inode+0xf4/0x250 fs/btrfs/inode.c:6085 but task is already holding lock: ffff88805d120558 (sb_pagefaults#2){.+.+}-{0:0}, at: do_page_mkwrite+0x19b/0x680 mm/memory.c:2978 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (sb_pagefaults#2){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_pagefault include/linux/fs.h:1930 [inline] btrfs_page_mkwrite+0x1b5/0x1140 fs/btrfs/inode.c:8415 do_page_mkwrite+0x19b/0x680 mm/memory.c:2978 do_shared_fault mm/memory.c:4619 [inline] do_fault mm/memory.c:4687 [inline] handle_pte_fault mm/memory.c:4955 [inline] __handle_mm_fault+0x2280/0x3a40 mm/memory.c:5097 handle_mm_fault+0x1cc/0x780 mm/memory.c:5218 do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 -> #4 (&mm->mmap_lock#2){++++}-{3:3}: __might_fault mm/memory.c:5646 [inline] __might_fault+0x10c/0x180 mm/memory.c:5639 _copy_to_user+0x29/0x150 lib/usercopy.c:29 copy_to_user include/linux/uaccess.h:169 [inline] btrfs_ioctl_get_subvol_rootref+0x74e/0xad0 fs/btrfs/ioctl.c:3203 btrfs_ioctl+0x2de6/0x5be0 fs/btrfs/ioctl.c:5556 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #3 (btrfs-root-00){++++}-{3:3}: down_read_nested+0x9e/0x450 kernel/locking/rwsem.c:1634 __btrfs_tree_read_lock+0x32/0x350 fs/btrfs/locking.c:134 btrfs_tree_read_lock fs/btrfs/locking.c:140 [inline] btrfs_read_lock_root_node+0x82/0x3a0 fs/btrfs/locking.c:279 btrfs_search_slot_get_root fs/btrfs/ctree.c:1665 [inline] btrfs_search_slot+0x3ca/0x2c70 fs/btrfs/ctree.c:1985 btrfs_update_root+0xdb/0x630 fs/btrfs/root-tree.c:132 commit_fs_roots+0x359/0x720 fs/btrfs/transaction.c:1441 btrfs_commit_transaction+0xb3c/0x36e0 fs/btrfs/transaction.c:2353 btrfs_sync_file+0xe8d/0x13e0 fs/btrfs/file.c:2305 vfs_fsync_range+0x13e/0x230 fs/sync.c:188 generic_write_sync include/linux/fs.h:2883 [inline] btrfs_do_write_iter+0x676/0x1450 fs/btrfs/file.c:1990 call_write_iter include/linux/fs.h:2191 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735 do_iter_write+0x182/0x700 fs/read_write.c:861 vfs_writev+0x1aa/0x630 fs/read_write.c:934 do_pwritev+0x1b6/0x270 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __x64_sys_pwritev2+0xef/0x150 fs/read_write.c:1081 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&fs_info->reloc_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 btrfs_commit_transaction+0xa8a/0x36e0 fs/btrfs/transaction.c:2316 btrfs_sync_file+0xe8d/0x13e0 fs/btrfs/file.c:2305 vfs_fsync_range+0x13e/0x230 fs/sync.c:188 generic_write_sync include/linux/fs.h:2883 [inline] btrfs_do_write_iter+0x676/0x1450 fs/btrfs/file.c:1990 call_write_iter include/linux/fs.h:2191 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735 do_iter_write+0x182/0x700 fs/read_write.c:861 vfs_writev+0x1aa/0x630 fs/read_write.c:934 do_pwritev+0x1b6/0x270 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __x64_sys_pwritev2+0xef/0x150 fs/read_write.c:1081 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (btrfs_trans_unblocked){++++}-{0:0}: wait_current_trans+0x242/0x470 fs/btrfs/transaction.c:512 start_transaction+0x3f8/0x1470 fs/btrfs/transaction.c:655 btrfs_create_common+0x1aa/0x260 fs/btrfs/inode.c:6633 btrfs_create+0x116/0x160 fs/btrfs/inode.c:6679 lookup_open.isra.0+0xf05/0x12a0 fs/namei.c:3413 open_last_lookups fs/namei.c:3481 [inline] path_openat+0x996/0x2860 fs/namei.c:3710 do_filp_open+0x1ba/0x410 fs/namei.c:3740 do_sys_openat2+0x16d/0x4c0 fs/open.c:1310 do_sys_open fs/open.c:1326 [inline] __do_sys_openat fs/open.c:1342 [inline] __se_sys_openat fs/open.c:1337 [inline] __x64_sys_openat+0x143/0x1f0 fs/open.c:1337 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] start_transaction+0x878/0x1470 fs/btrfs/transaction.c:652 btrfs_dirty_inode+0xf4/0x250 fs/btrfs/inode.c:6085 btrfs_update_time+0x25a/0x2c0 fs/btrfs/inode.c:6127 inode_update_time fs/inode.c:1871 [inline] __file_update_time fs/inode.c:2088 [inline] file_update_time+0x1fb/0x270 fs/inode.c:2119 btrfs_page_mkwrite+0x4f1/0x1140 fs/btrfs/inode.c:8431 do_page_mkwrite+0x19b/0x680 mm/memory.c:2978 do_shared_fault mm/memory.c:4619 [inline] do_fault mm/memory.c:4687 [inline] handle_pte_fault mm/memory.c:4955 [inline] __handle_mm_fault+0x2280/0x3a40 mm/memory.c:5097 handle_mm_fault+0x1cc/0x780 mm/memory.c:5218 do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 other info that might help us debug this: Chain exists of: sb_internal#3 --> &mm->mmap_lock#2 --> sb_pagefaults#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_pagefaults#2); lock(&mm->mmap_lock#2); lock(sb_pagefaults#2); lock(sb_internal#3); *** DEADLOCK *** 2 locks held by syz-executor.4/24439: #0: ffff8880282c66d8 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline] #0: ffff8880282c66d8 (&mm->mmap_lock#2){++++}-{3:3}, at: do_user_addr_fault+0xa51/0x1210 arch/x86/mm/fault.c:1379 #1: ffff88805d120558 (sb_pagefaults#2){.+.+}-{0:0}, at: do_page_mkwrite+0x19b/0x680 mm/memory.c:2978 stack backtrace: CPU: 0 PID: 24439 Comm: syz-executor.4 Not tainted 6.1.0-rc6-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] start_transaction+0x878/0x1470 fs/btrfs/transaction.c:652 btrfs_dirty_inode+0xf4/0x250 fs/btrfs/inode.c:6085 btrfs_update_time+0x25a/0x2c0 fs/btrfs/inode.c:6127 inode_update_time fs/inode.c:1871 [inline] __file_update_time fs/inode.c:2088 [inline] file_update_time+0x1fb/0x270 fs/inode.c:2119 btrfs_page_mkwrite+0x4f1/0x1140 fs/btrfs/inode.c:8431 do_page_mkwrite+0x19b/0x680 mm/memory.c:2978 do_shared_fault mm/memory.c:4619 [inline] do_fault mm/memory.c:4687 [inline] handle_pte_fault mm/memory.c:4955 [inline] __handle_mm_fault+0x2280/0x3a40 mm/memory.c:5097 handle_mm_fault+0x1cc/0x780 mm/memory.c:5218 do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 RIP: 0033:0x7f3fb4a2bdb9 Code: 48 8b 04 24 48 85 c0 74 17 48 8b 54 24 18 48 0f ca 48 89 54 24 18 48 83 f8 01 0f 85 9b 02 00 00 48 8b 44 24 10 48 8b 54 24 18 <48> 89 10 e9 c2 fd ff ff 48 8b 44 24 10 0f b7 10 48 8b 04 24 48 85 RSP: 002b:00007ffdd09ab740 EFLAGS: 00010246 RAX: 0000000020000100 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000020000000 RSI: 0000000000000000 RDI: 0000555555c1c2e8 RBP: 00007ffdd09ab838 R08: 0000000000000000 R09: 0000000000000000 R10: 00007f3fb4605c98 R11: 0000000000000246 R12: 00000000001539f9 R13: 00007ffdd09ab860 R14: 00007f3fb4babf80 R15: 0000000000000032