bcachefs (loop0): alloc_read... done bcachefs (loop0): stripes_read... done bcachefs (loop0): snapshots_read... done bcachefs (loop0): check_allocations... ====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc6-syzkaller-00061-ge9d22f7a6655 #0 Not tainted ------------------------------------------------------ syz.0.822/9319 is trying to acquire lock: ffff888055d00988 (&c->sb_lock){+.+.}-{3:3}, at: bch2_gc_mark_key+0xb8d/0xd60 fs/bcachefs/btree_gc.c:600 but task is already holding lock: ffff888055d01a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_gc_btree.constprop.0+0x109/0x1030 fs/bcachefs/btree_gc.c:644 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&c->btree_root_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 bch2_btree_roots_to_journal_entries+0x93/0x570 fs/bcachefs/btree_update_interior.c:2633 bch2_fs_mark_clean+0x31b/0x470 fs/bcachefs/sb-clean.c:376 bch2_fs_read_only+0x88a/0xf10 fs/bcachefs/super.c:381 __bch2_fs_stop+0xfc/0x540 fs/bcachefs/super.c:614 generic_shutdown_super+0x15c/0x3d0 fs/super.c:642 bch2_kill_sb+0x3b/0x50 fs/bcachefs/fs.c:2044 deactivate_locked_super+0xc1/0x1a0 fs/super.c:473 deactivate_super+0xde/0x100 fs/super.c:506 cleanup_mnt+0x222/0x450 fs/namespace.c:1267 task_work_run+0x151/0x250 kernel/task_work.c:180 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x275/0x2a0 kernel/entry/common.c:218 do_syscall_64+0xda/0x250 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&c->sb_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 bch2_gc_mark_key+0xb8d/0xd60 fs/bcachefs/btree_gc.c:600 bch2_gc_btree.constprop.0+0xb4c/0x1030 fs/bcachefs/btree_gc.c:648 bch2_gc_btrees+0x426/0x8b0 fs/bcachefs/btree_gc.c:697 bch2_check_allocations+0x85c/0x24f0 fs/bcachefs/btree_gc.c:1224 bch2_run_recovery_pass+0x91/0x1a0 fs/bcachefs/recovery_passes.c:182 bch2_run_recovery_passes+0x33b/0x710 fs/bcachefs/recovery_passes.c:225 bch2_fs_recovery+0x25ff/0x3e40 fs/bcachefs/recovery.c:813 bch2_fs_start+0x2e9/0x600 fs/bcachefs/super.c:1035 bch2_fs_open+0xfa0/0x1110 fs/bcachefs/super.c:2132 bch2_mount+0xe2c/0x1230 fs/bcachefs/fs.c:1926 legacy_get_tree+0x10c/0x220 fs/fs_context.c:662 vfs_get_tree+0x92/0x380 fs/super.c:1789 do_new_mount fs/namespace.c:3352 [inline] path_mount+0x14e6/0x1f20 fs/namespace.c:3679 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount fs/namespace.c:3875 [inline] __x64_sys_mount+0x297/0x320 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&c->btree_root_lock); lock(&c->sb_lock); lock(&c->btree_root_lock); lock(&c->sb_lock); *** DEADLOCK *** 4 locks held by syz.0.822/9319: #0: ffff888055d00278 (&c->state_lock){+.+.}-{3:3}, at: bch2_fs_start+0x3e/0x600 fs/bcachefs/super.c:1005 #1: ffff888055d26750 (&c->gc_lock){++++}-{3:3}, at: bch2_check_allocations+0xe5/0x24f0 fs/bcachefs/btree_gc.c:1209 #2: ffff888055d042d8 (&c->btree_trans_barrier){.+.+}-{0:0}, at: srcu_lock_acquire include/linux/srcu.h:116 [inline] #2: ffff888055d042d8 (&c->btree_trans_barrier){.+.+}-{0:0}, at: srcu_read_lock include/linux/srcu.h:215 [inline] #2: ffff888055d042d8 (&c->btree_trans_barrier){.+.+}-{0:0}, at: __bch2_trans_get+0x649/0xde0 fs/bcachefs/btree_iter.c:3193 #3: ffff888055d01a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_gc_btree.constprop.0+0x109/0x1030 fs/bcachefs/btree_gc.c:644 stack backtrace: CPU: 0 PID: 9319 Comm: syz.0.822 Not tainted 6.10.0-rc6-syzkaller-00061-ge9d22f7a6655 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 bch2_gc_mark_key+0xb8d/0xd60 fs/bcachefs/btree_gc.c:600 bch2_gc_btree.constprop.0+0xb4c/0x1030 fs/bcachefs/btree_gc.c:648 bch2_gc_btrees+0x426/0x8b0 fs/bcachefs/btree_gc.c:697 bch2_check_allocations+0x85c/0x24f0 fs/bcachefs/btree_gc.c:1224 bch2_run_recovery_pass+0x91/0x1a0 fs/bcachefs/recovery_passes.c:182 bch2_run_recovery_passes+0x33b/0x710 fs/bcachefs/recovery_passes.c:225 bch2_fs_recovery+0x25ff/0x3e40 fs/bcachefs/recovery.c:813 bch2_fs_start+0x2e9/0x600 fs/bcachefs/super.c:1035 bch2_fs_open+0xfa0/0x1110 fs/bcachefs/super.c:2132 bch2_mount+0xe2c/0x1230 fs/bcachefs/fs.c:1926 legacy_get_tree+0x10c/0x220 fs/fs_context.c:662 vfs_get_tree+0x92/0x380 fs/super.c:1789 do_new_mount fs/namespace.c:3352 [inline] path_mount+0x14e6/0x1f20 fs/namespace.c:3679 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount fs/namespace.c:3875 [inline] __x64_sys_mount+0x297/0x320 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f12347772da Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 7e 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f12354bce78 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f12354bcf00 RCX: 00007f12347772da RDX: 00000000200001c0 RSI: 0000000020000700 RDI: 00007f12354bcec0 RBP: 00000000200001c0 R08: 00007f12354bcf00 R09: 0000000003010400 R10: 0000000003010400 R11: 0000000000000206 R12: 0000000020000700 R13: 00007f12354bcec0 R14: 0000000000005bc4 R15: 00000000200000c0 bucket 0:14 gen 0 data type journal has wrong dirty_sectors: got 1792, should be 256, fixing bucket 0:22 gen 0 has wrong data_type: got free, should be sb, fixing bucket 0:22 gen 0 data type sb has wrong dirty_sectors: got 0, should be 256, fixing bucket 0:126 gen 0 has wrong data_type: got free, should be sb, fixing bucket 0:126 gen 0 data type sb has wrong dirty_sectors: got 0, should be 256, fixing bucket 0:127 gen 0 has wrong data_type: got free, should be sb, fixing bucket 0:127 gen 0 data type sb has wrong dirty_sectors: got 0, should be 256, fixing dev 0 has wrong sb sectors: got 530440, should be 6152, fixing dev 0 has wrong cached buckets: got 8, should be 0, fixing done bcachefs (loop0): going read-write bcachefs (loop0): journal_replay... bcachefs (loop0): bch2_journal_replay(): error ERESTARTSYS bcachefs (loop0): bch2_fs_recovery(): error ERESTARTSYS bcachefs (loop0): bch2_fs_start(): error starting filesystem ERESTARTSYS bcachefs (loop0): shutting down bcachefs (loop0): going read-only bcachefs (loop0): finished waiting for writes to stop bcachefs (loop0): flushing journal and stopping allocators, journal seq 12 bcachefs (loop0): flushing journal and stopping allocators complete, journal seq 12 bcachefs (loop0): unshutdown complete, journal seq 12 bcachefs (loop0): done going read-only, filesystem not clean bcachefs (loop0): shutdown complete