====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc5-syzkaller-g9a03cbd79d3a #0 Not tainted ------------------------------------------------------ syz-executor.0/10908 is trying to acquire lock: ffff000134333eb8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x2ac/0x1884 fs/ext4/inode.c:574 but task is already holding lock: ffff0000df03e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0x5c/0x78 kernel/locking/rwsem.c:1520 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:435 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6770 dqget+0x844/0xc48 fs/quota/dquot.c:914 __dquot_initialize+0x344/0xb54 fs/quota/dquot.c:1492 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1550 ext4_xattr_set+0xe8/0x354 fs/ext4/xattr.c:2544 ext4_xattr_trusted_set+0x4c/0x64 fs/ext4/xattr_trusted.c:38 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:203 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:237 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:298 vfs_setxattr+0x1a8/0x344 fs/xattr.c:324 do_setxattr fs/xattr.c:609 [inline] setxattr+0x208/0x29c fs/xattr.c:632 path_setxattr+0x17c/0x258 fs/xattr.c:651 __do_sys_setxattr fs/xattr.c:667 [inline] __se_sys_setxattr fs/xattr.c:663 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:663 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:479 ext4_write_dquot+0x1b4/0x288 fs/ext4/super.c:6754 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6802 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0x48c/0xd20 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0xed4/0x43dc fs/ext4/mballoc.c:5571 ext4_ext_map_blocks+0x1378/0x5f50 fs/ext4/extents.c:4286 ext4_map_blocks+0x828/0x1884 fs/ext4/inode.c:651 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:863 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:919 ext4_append+0x260/0x4cc fs/ext4/namei.c:83 ext4_init_new_dir+0x294/0x8e4 fs/ext4/namei.c:2955 ext4_mkdir+0x3d4/0xa64 fs/ext4/namei.c:3001 vfs_mkdir+0x240/0x3a8 fs/namei.c:4038 do_mkdirat+0x20c/0x610 fs/namei.c:4061 __do_sys_mkdirat fs/namei.c:4076 [inline] __se_sys_mkdirat fs/namei.c:4074 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4074 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x238/0x718 kernel/locking/lockdep.c:5669 down_read+0x5c/0x78 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x2ac/0x1884 fs/ext4/inode.c:574 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:863 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:919 ext4_quota_read+0x178/0x294 fs/ext4/super.c:7089 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x164/0xa08 fs/quota/quota_tree.c:624 find_tree_dqentry+0x394/0xa08 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x12c/0x634 fs/quota/quota_tree.c:672 v2_read_dquot+0xc0/0x11c fs/quota/quota_v2.c:333 dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:435 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6770 dqget+0x844/0xc48 fs/quota/dquot.c:914 __dquot_initialize+0x344/0xb54 fs/quota/dquot.c:1492 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1550 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x968/0x1140 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x644c/0x6a30 fs/ext4/super.c:5637 get_tree_bdev+0x360/0x54c fs/super.c:1303 ext4_get_tree+0x28/0x38 fs/ext4/super.c:5668 vfs_get_tree+0x90/0x274 fs/super.c:1510 do_new_mount+0x25c/0x8c8 fs/namespace.c:3042 path_mount+0x590/0xe20 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3571 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.0/10908: #0: ffff0000df03e0e0 (&type->s_umount_key#25/1){+.+.}-{3:3}, at: alloc_super+0x1b4/0x824 fs/super.c:228 #1: ffff0000e0734ea8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x5c4 fs/quota/dquot.c:432 #2: ffff0000df03e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 stack backtrace: CPU: 1 PID: 10908 Comm: syz-executor.0 Not tainted 6.3.0-rc5-syzkaller-g9a03cbd79d3a #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x238/0x718 kernel/locking/lockdep.c:5669 down_read+0x5c/0x78 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x2ac/0x1884 fs/ext4/inode.c:574 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:863 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:919 ext4_quota_read+0x178/0x294 fs/ext4/super.c:7089 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x164/0xa08 fs/quota/quota_tree.c:624 find_tree_dqentry+0x394/0xa08 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x12c/0x634 fs/quota/quota_tree.c:672 v2_read_dquot+0xc0/0x11c fs/quota/quota_v2.c:333 dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:435 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6770 dqget+0x844/0xc48 fs/quota/dquot.c:914 __dquot_initialize+0x344/0xb54 fs/quota/dquot.c:1492 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1550 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x968/0x1140 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x644c/0x6a30 fs/ext4/super.c:5637 get_tree_bdev+0x360/0x54c fs/super.c:1303 ext4_get_tree+0x28/0x38 fs/ext4/super.c:5668 vfs_get_tree+0x90/0x274 fs/super.c:1510 do_new_mount+0x25c/0x8c8 fs/namespace.c:3042 path_mount+0x590/0xe20 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3571 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 EXT4-fs error (device loop0): ext4_mb_mark_diskspace_used:3789: comm syz-executor.0: Allocating blocks 41-42 which overlap fs metadata EXT4-fs (loop0): Remounting filesystem read-only EXT4-fs (loop0): 1 truncate cleaned up EXT4-fs (loop0): mounted filesystem 00000000-0000-0000-0000-000000000000 without journal. Quota mode: writeback. EXT4-fs error (device loop0): __ext4_remount:6433: comm syz-executor.0: Abort forced by user EXT4-fs (loop0): Remounting filesystem read-only