====================================================== WARNING: possible circular locking dependency detected 6.1.0-syzkaller-14594-g72a85e2b0a1e #0 Not tainted ------------------------------------------------------ syz-executor.0/10551 is trying to acquire lock: ffff8880303700f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xde/0x1420 fs/hfs/extent.c:397 but task is already holding lock: ffff8880530f00b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x167/0x1e0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock/1){+.+.}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 hfs_find_init+0x167/0x1e0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_get_block+0x519/0xbb0 fs/hfs/extent.c:366 block_read_full_folio+0x3b3/0xfa0 fs/buffer.c:2271 filemap_read_folio+0x187/0x7d0 mm/filemap.c:2426 do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3553 do_read_cache_page mm/filemap.c:3595 [inline] read_cache_page+0x56/0x270 mm/filemap.c:3604 read_mapping_page include/linux/pagemap.h:755 [inline] hfs_btree_open+0x50c/0xf20 fs/hfs/btree.c:78 hfs_mdb_get+0x148f/0x21a0 fs/hfs/mdb.c:204 hfs_fill_super+0xfc7/0x1690 fs/hfs/super.c:406 mount_bdev+0x26c/0x3a0 fs/super.c:1359 legacy_get_tree+0xea/0x180 fs/fs_context.c:610 vfs_get_tree+0x88/0x270 fs/super.c:1489 do_new_mount+0x289/0xad0 fs/namespace.c:3145 do_mount fs/namespace.c:3488 [inline] __do_sys_mount fs/namespace.c:3697 [inline] __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3674 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 hfs_extend_file+0xde/0x1420 fs/hfs/extent.c:397 hfs_bmap_reserve+0xfa/0x410 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x1ea/0x460 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x67/0x980 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x323/0x1420 fs/hfs/extent.c:401 hfs_get_block+0x3fc/0xbb0 fs/hfs/extent.c:353 __block_write_begin_int+0x54c/0x1a80 fs/buffer.c:1991 __block_write_begin fs/buffer.c:2041 [inline] block_write_begin+0x93/0x1e0 fs/buffer.c:2102 cont_write_begin+0x606/0x860 fs/buffer.c:2456 hfs_write_begin+0x86/0xd0 fs/hfs/inode.c:58 cont_expand_zero fs/buffer.c:2383 [inline] cont_write_begin+0x2cf/0x860 fs/buffer.c:2446 hfs_write_begin+0x86/0xd0 fs/hfs/inode.c:58 hfs_file_truncate+0x159/0xa10 fs/hfs/extent.c:494 hfs_inode_setattr+0x45d/0x690 fs/hfs/inode.c:651 notify_change+0xe50/0x1100 fs/attr.c:482 do_truncate+0x200/0x2f0 fs/open.c:65 do_sys_ftruncate+0x2b0/0x350 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz-executor.0/10551: #0: ffff8880530f2460 (sb_writers#31){.+.+}-{0:0}, at: do_sys_ftruncate+0x243/0x350 fs/open.c:190 #1: ffff888030372328 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff888030372328 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: do_truncate+0x1ec/0x2f0 fs/open.c:63 #2: ffff888030372178 (&HFS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xde/0x1420 fs/hfs/extent.c:397 #3: ffff8880530f00b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x167/0x1e0 stack backtrace: CPU: 1 PID: 10551 Comm: syz-executor.0 Not tainted 6.1.0-syzkaller-14594-g72a85e2b0a1e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x290 lib/dump_stack.c:106 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 hfs_extend_file+0xde/0x1420 fs/hfs/extent.c:397 hfs_bmap_reserve+0xfa/0x410 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x1ea/0x460 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x67/0x980 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x323/0x1420 fs/hfs/extent.c:401 hfs_get_block+0x3fc/0xbb0 fs/hfs/extent.c:353 __block_write_begin_int+0x54c/0x1a80 fs/buffer.c:1991 __block_write_begin fs/buffer.c:2041 [inline] block_write_begin+0x93/0x1e0 fs/buffer.c:2102 cont_write_begin+0x606/0x860 fs/buffer.c:2456 hfs_write_begin+0x86/0xd0 fs/hfs/inode.c:58 cont_expand_zero fs/buffer.c:2383 [inline] cont_write_begin+0x2cf/0x860 fs/buffer.c:2446 hfs_write_begin+0x86/0xd0 fs/hfs/inode.c:58 hfs_file_truncate+0x159/0xa10 fs/hfs/extent.c:494 hfs_inode_setattr+0x45d/0x690 fs/hfs/inode.c:651 notify_change+0xe50/0x1100 fs/attr.c:482 do_truncate+0x200/0x2f0 fs/open.c:65 do_sys_ftruncate+0x2b0/0x350 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f99f188c0a9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f99f2533168 EFLAGS: 00000246 ORIG_RAX: 000000000000004d RAX: ffffffffffffffda RBX: 00007f99f19abf80 RCX: 00007f99f188c0a9 RDX: 0000000000000000 RSI: 00000000000045ec RDI: 0000000000000004 RBP: 00007f99f18e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fffbf21698f R14: 00007f99f2533300 R15: 0000000000022000