====================================================== WARNING: possible circular locking dependency detected 6.1.114-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.63/4210 is trying to acquire lock: ffff88807b790650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260 but task is already holding lock: ffff88805af8cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xd87/0x1f80 fs/ocfs2/file.c:1259 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0x1179/0x1f80 fs/ocfs2/file.c:1240 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xde/0x150 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:821 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0x1179/0x1f80 fs/ocfs2/file.c:1240 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xde/0x150 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:821 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5727 ext4_ext_map_blocks+0x1c1c/0x7ab0 fs/ext4/extents.c:4339 ext4_map_blocks+0xa2b/0x1cb0 fs/ext4/inode.c:678 _ext4_get_block+0x23b/0x660 fs/ext4/inode.c:821 ext4_block_write_begin+0x631/0x1400 fs/ext4/inode.c:1123 ext4_write_begin+0x638/0xf80 ext4_da_write_begin+0x30a/0x9c0 fs/ext4/inode.c:2999 generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3845 ext4_buffered_write_iter+0x122/0x3a0 fs/ext4/file.c:285 ext4_file_write_iter+0x1d7/0x1930 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x857/0xbc0 fs/read_write.c:584 ksys_write+0x19c/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #3 (&ei->i_data_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4283 ext4_setattr+0x10f5/0x1a00 fs/ext4/inode.c:5601 notify_change+0xce3/0xfc0 fs/attr.c:499 do_truncate+0x21c/0x300 fs/open.c:65 do_sys_ftruncate+0x2e2/0x380 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354 ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2468 dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2505 ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:926 ocfs2_fill_super+0x4c7a/0x5730 fs/ocfs2/super.c:1139 mount_bdev+0x2c9/0x3f0 fs/super.c:1443 legacy_get_tree+0xeb/0x180 fs/fs_context.c:632 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x2ba/0xb40 fs/namespace.c:3056 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2468 dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2505 ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:926 ocfs2_fill_super+0x4c7a/0x5730 fs/ocfs2/super.c:1139 mount_bdev+0x2c9/0x3f0 fs/super.c:1443 legacy_get_tree+0xeb/0x180 fs/fs_context.c:632 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x2ba/0xb40 fs/namespace.c:3056 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (sb_internal#5){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260 notify_change+0xce3/0xfc0 fs/attr.c:499 do_truncate+0x21c/0x300 fs/open.c:65 do_sys_ftruncate+0x2e2/0x380 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#5); *** DEADLOCK *** 3 locks held by syz.0.63/4210: #0: ffff88807b790460 (sb_writers#21){.+.+}-{0:0}, at: do_sys_ftruncate+0x251/0x380 fs/open.c:190 #1: ffff88805af8d108 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff88805af8d108 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: do_truncate+0x208/0x300 fs/open.c:63 #2: ffff88805af8cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xd87/0x1f80 fs/ocfs2/file.c:1259 stack backtrace: CPU: 1 PID: 4210 Comm: syz.0.63 Not tainted 6.1.114-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260 notify_change+0xce3/0xfc0 fs/attr.c:499 do_truncate+0x21c/0x300 fs/open.c:65 do_sys_ftruncate+0x2e2/0x380 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fafcdd7dff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fafceb90038 EFLAGS: 00000246 ORIG_RAX: 000000000000004d RAX: ffffffffffffffda RBX: 00007fafcdf35f80 RCX: 00007fafcdd7dff9 RDX: 0000000000000000 RSI: 0000000002007ffb RDI: 0000000000000005 RBP: 00007fafcddf0296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fafcdf35f80 R15: 00007ffdb8485d08