====================================================== WARNING: possible circular locking dependency detected 6.7.0-syzkaller-12829-g125514880ddd #0 Not tainted ------------------------------------------------------ syz-executor.2/10666 is trying to acquire lock: ffff8880414f30f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff88802a2687c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x422/0xe10 fs/buffer.c:2382 filemap_read_folio+0x19c/0x780 mm/filemap.c:2324 do_read_cache_folio+0x134/0x810 mm/filemap.c:3703 do_read_cache_page+0x30/0x200 mm/filemap.c:3769 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50b/0x1a70 fs/buffer.c:2103 __block_write_begin fs/buffer.c:2152 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2211 cont_write_begin+0x643/0x880 fs/buffer.c:2565 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 page_symlink+0x2c5/0x4e0 fs/namei.c:5228 hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x12f/0x2a0 fs/namei.c:4480 do_symlinkat+0x222/0x3a0 fs/namei.c:4506 __do_sys_symlink fs/namei.c:4527 [inline] __se_sys_symlink fs/namei.c:4525 [inline] __x64_sys_symlink+0x7e/0x90 fs/namei.c:4525 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x1c8/0x630 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x6fe/0x22d0 fs/hfsplus/xattr.c:354 hfsplus_initxattrs+0x158/0x220 fs/hfsplus/xattr_security.c:59 security_inode_init_security+0x2a7/0x470 security/security.c:1752 hfsplus_mknod+0x1c2/0x2a0 fs/hfsplus/dir.c:498 lookup_open fs/namei.c:3496 [inline] open_last_lookups fs/namei.c:3565 [inline] path_openat+0x13fe/0x31e0 fs/namei.c:3795 do_filp_open+0x234/0x490 fs/namei.c:3825 do_sys_openat2+0x13e/0x1d0 fs/open.c:1404 do_sys_open fs/open.c:1419 [inline] __do_sys_openat fs/open.c:1435 [inline] __se_sys_openat fs/open.c:1430 [inline] __x64_sys_openat+0x247/0x290 fs/open.c:1430 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 6 locks held by syz-executor.2/10666: #0: ffff888055576420 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:409 #1: ffff88802a26e180 (&type->i_mutex_dir_key#16){++++}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff88802a26e180 (&type->i_mutex_dir_key#16){++++}-{3:3}, at: open_last_lookups fs/namei.c:3562 [inline] #1: ffff88802a26e180 (&type->i_mutex_dir_key#16){++++}-{3:3}, at: path_openat+0x7c2/0x31e0 fs/namei.c:3795 #2: ffff8880414f3198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_mknod+0x7e/0x2a0 fs/hfsplus/dir.c:486 #3: ffff8880362820b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 #4: ffff8880362840b0 (&tree->tree_lock#2/2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 #5: ffff88802a2687c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 10666 Comm: syz-executor.2 Not tainted 6.7.0-syzkaller-12829-g125514880ddd #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x1c8/0x630 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x6fe/0x22d0 fs/hfsplus/xattr.c:354 hfsplus_initxattrs+0x158/0x220 fs/hfsplus/xattr_security.c:59 security_inode_init_security+0x2a7/0x470 security/security.c:1752 hfsplus_mknod+0x1c2/0x2a0 fs/hfsplus/dir.c:498 lookup_open fs/namei.c:3496 [inline] open_last_lookups fs/namei.c:3565 [inline] path_openat+0x13fe/0x31e0 fs/namei.c:3795 do_filp_open+0x234/0x490 fs/namei.c:3825 do_sys_openat2+0x13e/0x1d0 fs/open.c:1404 do_sys_open fs/open.c:1419 [inline] __do_sys_openat fs/open.c:1435 [inline] __se_sys_openat fs/open.c:1430 [inline] __x64_sys_openat+0x247/0x290 fs/open.c:1430 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7fa78f27cda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa78ffdc0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 00007fa78f3abf80 RCX: 00007fa78f27cda9 RDX: 000000000000275a RSI: 00000000200001c0 RDI: ffffffffffffff9c RBP: 00007fa78f2c947a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fa78f3abf80 R15: 00007ffc12759e98 hfsplus: inconsistency in B*Tree (3840,1,255,1,0) hfsplus: xattr search failed