======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc2-syzkaller-g2e7aff49b5da #0 Not tainted
------------------------------------------------------
syz.2.852/9123 is trying to acquire lock:
ffff0000f19eed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
ffff0000f19eed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x108/0x24cc fs/ocfs2/localalloc.c:636

but task is already holding lock:
ffff0000f1898660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_write_begin+0x178/0x38c fs/ocfs2/aops.c:1900

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:823
       dqget+0x660/0xcec fs/quota/dquot.c:977
       ocfs2_setattr+0xd90/0x19e4 fs/ocfs2/file.c:1243
       notify_change+0x9f0/0xca0 fs/attr.c:552
       chown_common+0x438/0x700 fs/open.c:778
       vfs_fchown fs/open.c:846 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:858
       __do_sys_fchown fs/open.c:863 [inline]
       __se_sys_fchown fs/open.c:861 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:861
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}:
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:818 [inline]
       ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:823
       dqget+0x660/0xcec fs/quota/dquot.c:977
       ocfs2_setattr+0xd90/0x19e4 fs/ocfs2/file.c:1243
       notify_change+0x9f0/0xca0 fs/attr.c:552
       chown_common+0x438/0x700 fs/open.c:778
       vfs_fchown fs/open.c:846 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:858
       __do_sys_fchown fs/open.c:863 [inline]
       __se_sys_fchown fs/open.c:861 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:861
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #5 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585
       __mutex_lock kernel/locking/mutex.c:735 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787
       wait_on_dquot fs/quota/dquot.c:354 [inline]
       dqget+0x5f0/0xcec fs/quota/dquot.c:972
       __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1505
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1567
       __ext4_new_inode+0x694/0x37dc fs/ext4/ialloc.c:992
       ext4_xattr_inode_create fs/ext4/xattr.c:1486 [inline]
       ext4_xattr_inode_lookup_create+0x9e4/0x1a28 fs/ext4/xattr.c:1596
       ext4_xattr_block_set+0x224/0x2e08 fs/ext4/xattr.c:1916
       ext4_xattr_set_handle+0xc68/0x12d0 fs/ext4/xattr.c:2458
       ext4_xattr_set+0x224/0x344 fs/ext4/xattr.c:2560
       ext4_xattr_trusted_set+0x4c/0x64 fs/ext4/xattr_trusted.c:38
       __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200
       __vfs_setxattr_noperm+0x110/0x578 fs/xattr.c:234
       __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295
       vfs_setxattr+0x1a8/0x344 fs/xattr.c:321
       do_setxattr fs/xattr.c:636 [inline]
       filename_setxattr+0x260/0x404 fs/xattr.c:665
       path_setxattrat+0x370/0x41c fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #4 (&ei->xattr_sem){++++}-{4:4}:
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline]
       ext4_xattr_set_handle+0x1dc/0x12d0 fs/ext4/xattr.c:2373
       ext4_initxattrs+0xa4/0x11c fs/ext4/xattr_security.c:44
       security_inode_init_security+0x73c/0x908 security/security.c:1847
       ext4_init_security+0x44/0x58 fs/ext4/xattr_security.c:58
       __ext4_new_inode+0x2ba8/0x37dc fs/ext4/ialloc.c:1324
       ext4_create+0x234/0x480 fs/ext4/namei.c:2841
       lookup_open fs/namei.c:3649 [inline]
       open_last_lookups fs/namei.c:3748 [inline]
       path_openat+0x13e4/0x2b14 fs/namei.c:3984
       do_filp_open+0x1e8/0x404 fs/namei.c:4014
       do_sys_openat2+0x124/0x1b8 fs/open.c:1402
       do_sys_open fs/open.c:1417 [inline]
       __do_sys_openat fs/open.c:1433 [inline]
       __se_sys_openat fs/open.c:1428 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1428
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352
       ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x1f4/0x920 fs/ocfs2/super.c:1877
       ocfs2_put_super+0xec/0x368 fs/ocfs2/super.c:1608
       generic_shutdown_super+0x12c/0x2bc fs/super.c:642
       kill_block_super+0x44/0x90 fs/super.c:1710
       deactivate_locked_super+0xc4/0x12c fs/super.c:473
       deactivate_super+0xe0/0x100 fs/super.c:506
       cleanup_mnt+0x34c/0x3dc fs/namespace.c:1373
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1380
       task_work_run+0x230/0x2e0 kernel/task_work.c:239
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       do_notify_resume+0x178/0x1f4 arch/arm64/kernel/entry-common.c:151
       exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline]
       el0_svc+0xac/0x168 arch/arm64/kernel/entry-common.c:745
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x58/0x2fc kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350
       ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x1f4/0x920 fs/ocfs2/super.c:1877
       ocfs2_put_super+0xec/0x368 fs/ocfs2/super.c:1608
       generic_shutdown_super+0x12c/0x2bc fs/super.c:642
       kill_block_super+0x44/0x90 fs/super.c:1710
       deactivate_locked_super+0xc4/0x12c fs/super.c:473
       deactivate_super+0xe0/0x100 fs/super.c:506
       cleanup_mnt+0x34c/0x3dc fs/namespace.c:1373
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1380
       task_work_run+0x230/0x2e0 kernel/task_work.c:239
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       do_notify_resume+0x178/0x1f4 arch/arm64/kernel/entry-common.c:151
       exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline]
       el0_svc+0xac/0x168 arch/arm64/kernel/entry-common.c:745
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #1 (sb_internal#4){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1725 [inline]
       sb_start_intwrite include/linux/fs.h:1908 [inline]
       ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348
       ocfs2_mknod+0xe58/0x2438 fs/ocfs2/namei.c:361
       ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3649 [inline]
       open_last_lookups fs/namei.c:3748 [inline]
       path_openat+0x13e4/0x2b14 fs/namei.c:3984
       do_filp_open+0x1e8/0x404 fs/namei.c:4014
       do_sys_openat2+0x124/0x1b8 fs/open.c:1402
       do_sys_open fs/open.c:1417 [inline]
       __do_sys_openat fs/open.c:1433 [inline]
       __se_sys_openat fs/open.c:1428 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1428
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226
       lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:818 [inline]
       ocfs2_reserve_local_alloc_bits+0x108/0x24cc fs/ocfs2/localalloc.c:636
       ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1166
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1227 [inline]
       ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2746
       ocfs2_extend_allocation+0x474/0x18c0 fs/ocfs2/file.c:589
       ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
       ocfs2_expand_nonsparse_inode+0x12c/0x3a8 fs/ocfs2/aops.c:1619
       ocfs2_write_begin_nolock+0xfac/0x3e90 fs/ocfs2/aops.c:1685
       ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1902
       generic_perform_write+0x29c/0x868 mm/filemap.c:4055
       __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4156
       ocfs2_file_write_iter+0x161c/0x1f3c fs/ocfs2/file.c:2469
       do_iter_readv_writev+0x490/0x6d4
       vfs_writev+0x410/0xbc8 fs/read_write.c:1050
       do_pwritev fs/read_write.c:1146 [inline]
       __do_sys_pwritev2 fs/read_write.c:1204 [inline]
       __se_sys_pwritev2 fs/read_write.c:1195 [inline]
       __arm64_sys_pwritev2+0x1d8/0x2ec fs/read_write.c:1195
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);

 *** DEADLOCK ***

3 locks held by syz.2.852/9123:
 #0: ffff0000c827c420 (sb_writers#28){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2964 [inline]
 #0: ffff0000c827c420 (sb_writers#28){.+.+}-{0:0}, at: vfs_writev+0x3a8/0xbc8 fs/read_write.c:1048
 #1: ffff0000f18989c0 (&sb->s_type->i_mutex_key#37){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
 #1: ffff0000f18989c0 (&sb->s_type->i_mutex_key#37){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x3a4/0x1f3c fs/ocfs2/file.c:2399
 #2: ffff0000f1898660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_write_begin+0x178/0x38c fs/ocfs2/aops.c:1900

stack backtrace:
CPU: 1 UID: 0 PID: 9123 Comm: syz.2.852 Not tainted 6.13.0-rc2-syzkaller-g2e7aff49b5da #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:484 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074
 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226
 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849
 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:818 [inline]
 ocfs2_reserve_local_alloc_bits+0x108/0x24cc fs/ocfs2/localalloc.c:636
 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1166
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1227 [inline]
 ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2746
 ocfs2_extend_allocation+0x474/0x18c0 fs/ocfs2/file.c:589
 ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
 ocfs2_expand_nonsparse_inode+0x12c/0x3a8 fs/ocfs2/aops.c:1619
 ocfs2_write_begin_nolock+0xfac/0x3e90 fs/ocfs2/aops.c:1685
 ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1902
 generic_perform_write+0x29c/0x868 mm/filemap.c:4055
 __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4156
 ocfs2_file_write_iter+0x161c/0x1f3c fs/ocfs2/file.c:2469
 do_iter_readv_writev+0x490/0x6d4
 vfs_writev+0x410/0xbc8 fs/read_write.c:1050
 do_pwritev fs/read_write.c:1146 [inline]
 __do_sys_pwritev2 fs/read_write.c:1204 [inline]
 __se_sys_pwritev2 fs/read_write.c:1195 [inline]
 __arm64_sys_pwritev2+0x1d8/0x2ec fs/read_write.c:1195
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600