====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc6-next-20231020-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor370/5057 is trying to acquire lock: ffff8880789487c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 but task is already holding lock: ffff88814826e0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a2/0x200 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1330 kernel/locking/mutex.c:747 hfsplus_file_truncate+0xecf/0x1120 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:269 notify_change+0x742/0x11c0 fs/attr.c:499 do_truncate+0x15c/0x220 fs/open.c:66 handle_truncate fs/namei.c:3280 [inline] do_open fs/namei.c:3625 [inline] path_openat+0x266c/0x2cd0 fs/namei.c:3778 do_filp_open+0x1dc/0x430 fs/namei.c:3808 do_sys_openat2+0x176/0x1e0 fs/open.c:1440 __do_sys_openat2+0x1a3/0x2a0 fs/open.c:1496 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e22/0x5dc0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1b1/0x530 kernel/locking/lockdep.c:5718 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1330 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456 hfsplus_rename+0x118/0x200 fs/hfsplus/dir.c:552 vfs_rename+0x13dd/0x1c30 fs/namei.c:4843 do_renameat2+0xc3c/0xdc0 fs/namei.c:4995 __do_sys_renameat2 fs/namei.c:5028 [inline] __se_sys_renameat2 fs/namei.c:5025 [inline] __x64_sys_renameat2+0xeb/0x130 fs/namei.c:5025 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz-executor370/5057: #0: ffff888148268418 (sb_writers#9){.+.+}-{0:0}, at: do_renameat2+0x3d5/0xdc0 fs/namei.c:4929 #1: ffff888078949e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #1: ffff888078949e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3046 [inline] #1: ffff888078949e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3043 [inline] #1: ffff888078949e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_renameat2+0xb25/0xdc0 fs/namei.c:4934 #2: ffff88801d010300 (&type->i_mutex_dir_key#6){++++}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #2: ffff88801d010300 (&type->i_mutex_dir_key#6){++++}-{3:3}, at: lock_two_inodes+0x1b2/0x1e0 fs/inode.c:1127 #3: ffff88814826e0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a2/0x200 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 1 PID: 5057 Comm: syz-executor370 Not tainted 6.6.0-rc6-next-20231020-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x310/0x3f0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e22/0x5dc0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1b1/0x530 kernel/locking/lockdep.c:5718 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1330 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456 hfsplus_rename+0x118/0x200 fs/hfsplus/dir.c:552 vfs_rename+0x13dd/0x1c30 fs/namei.c:4843 do_renameat2+0xc3c/0xdc0 fs/namei.c:4995 __do_sys_renameat2 fs/namei.c:5028 [inline] __se_sys_renameat2 fs/namei.c:5025 [inline] __x64_sys_renameat2+0xeb/0x130 fs/namei.c:5025 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f3afe57bc19 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffdbed47618 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007f3afe57bc19 RDX: 0000000000000007 RSI: 00000000200001c0 RDI: 0000000000000007 RBP: 00007f3afe5ef5f0 R08: 0000000000000000 R09: 00005555574cf4c0 R10: 0000000020000200 R11: 0000000000000246 R12: 00007ffdbed47640 R13: 00007ffdbed47868 R14: 431bde82d7b634db R15: 00007f3afe5c403b