====================================================== WARNING: possible circular locking dependency detected 6.1.119-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.320/5996 is trying to acquire lock: ffff888054121698 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 but task is already holding lock: ffff888051f90208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_file_open+0x2cf/0x710 fs/ext4/file.c:872 do_dentry_open+0x7f9/0x10f0 fs/open.c:882 do_open fs/namei.c:3626 [inline] path_openat+0x2644/0x2e60 fs/namei.c:3783 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_creat fs/open.c:1412 [inline] __se_sys_creat fs/open.c:1406 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1406 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1940 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline] ext4_free_blocks+0x1fb4/0x3020 fs/ext4/mballoc.c:6273 ext4_remove_blocks fs/ext4/extents.c:2525 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline] ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2939 ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4469 ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288 ext4_setattr+0x10f5/0x1a00 fs/ext4/inode.c:5601 notify_change+0xce3/0xfc0 fs/attr.c:499 do_truncate+0x21c/0x300 fs/open.c:65 handle_truncate fs/namei.c:3285 [inline] do_open fs/namei.c:3630 [inline] path_openat+0x27e2/0x2e60 fs/namei.c:3783 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_creat fs/open.c:1412 [inline] __se_sys_creat fs/open.c:1406 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1406 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7171 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb51/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb51/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 dquot_get_dqblk+0x27/0x2b0 fs/quota/dquot.c:2697 quota_getquota+0x27a/0x6e0 fs/quota/quota.c:214 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz.0.320/5996: #0: ffff888051f900e0 (&type->s_umount_key#32){++++}-{3:3}, at: user_get_super+0x11a/0x250 fs/super.c:889 #1: ffff8880541f4b28 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #2: ffff888051f90208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 stack backtrace: CPU: 0 PID: 5996 Comm: syz.0.320 Not tainted 6.1.119-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7171 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb51/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb51/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 dquot_get_dqblk+0x27/0x2b0 fs/quota/dquot.c:2697 quota_getquota+0x27a/0x6e0 fs/quota/quota.c:214 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f313fb7ff19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f313f9de058 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007f313fd46160 RCX: 00007f313fb7ff19 RDX: 000000000000ee00 RSI: 0000000020000040 RDI: ffffffff80000701 RBP: 00007f313fbf3986 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f313fd46160 R15: 00007ffd073f7e08