===================================================== WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected 5.11.0-rc1-syzkaller #0 Not tainted ----------------------------------------------------- syz-executor.2/6133 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: ffff888026df22b8 (&new->fa_lock){.+.+}-{2:2}, at: kill_fasync_rcu fs/fcntl.c:1004 [inline] ffff888026df22b8 (&new->fa_lock){.+.+}-{2:2}, at: kill_fasync fs/fcntl.c:1025 [inline] ffff888026df22b8 (&new->fa_lock){.+.+}-{2:2}, at: kill_fasync+0x14b/0x460 fs/fcntl.c:1018 and this task is already holding: ffff888022a48498 (&ctx->completion_lock#2){-...}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:379 [inline] ffff888022a48498 (&ctx->completion_lock#2){-...}-{2:2}, at: io_submit_flush_completions+0x4d/0x3a0 fs/io_uring.c:1829 which would create a new lock dependency: (&ctx->completion_lock#2){-...}-{2:2} -> (&new->fa_lock){.+.+}-{2:2} but this new dependency connects a HARDIRQ-irq-safe lock: (&ctx->completion_lock#2){-...}-{2:2} ... which became HARDIRQ-irq-safe at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:159 io_timeout_fn+0x6f/0x3d0 fs/io_uring.c:5619 __run_hrtimer kernel/time/hrtimer.c:1519 [inline] __hrtimer_run_queues+0x693/0xea0 kernel/time/hrtimer.c:1583 hrtimer_interrupt+0x334/0x940 kernel/time/hrtimer.c:1645 local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1085 [inline] __sysvec_apic_timer_interrupt+0x146/0x540 arch/x86/kernel/apic/apic.c:1102 asm_call_irq_on_stack+0xf/0x20 __run_sysvec_on_irqstack arch/x86/include/asm/irq_stack.h:37 [inline] run_sysvec_on_irqstack_cond arch/x86/include/asm/irq_stack.h:89 [inline] sysvec_apic_timer_interrupt+0xbd/0x100 arch/x86/kernel/apic/apic.c:1096 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:628 __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:169 [inline] _raw_spin_unlock_irq+0x25/0x40 kernel/locking/spinlock.c:199 spin_unlock_irq include/linux/spinlock.h:404 [inline] io_timeout fs/io_uring.c:5823 [inline] io_issue_sqe+0x1cf3/0x4490 fs/io_uring.c:6217 __io_queue_sqe+0x228/0x10c0 fs/io_uring.c:6484 io_queue_sqe+0x631/0x10d0 fs/io_uring.c:6550 io_queue_link_head fs/io_uring.c:6561 [inline] io_submit_sqes+0xac1/0x2720 fs/io_uring.c:6886 __do_sys_io_uring_enter+0x6d1/0x1e70 fs/io_uring.c:9192 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 to a HARDIRQ-irq-unsafe lock: (&new->fa_lock){.+.+}-{2:2} ... which became HARDIRQ-irq-unsafe at: ... lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 pipe_write+0xb7a/0x1ac0 fs/pipe.c:558 call_write_iter include/linux/fs.h:1901 [inline] new_sync_write+0x426/0x650 fs/read_write.c:518 vfs_write+0x791/0xa30 fs/read_write.c:605 ksys_write+0x1ee/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&new->fa_lock); local_irq_disable(); lock(&ctx->completion_lock#2); lock(&new->fa_lock); lock(&ctx->completion_lock#2); *** DEADLOCK *** 3 locks held by syz-executor.2/6133: #0: ffff888022a483e8 (&ctx->uring_lock){+.+.}-{3:3}, at: __do_sys_io_uring_enter+0x6c6/0x1e70 fs/io_uring.c:9191 #1: ffff888022a48498 (&ctx->completion_lock#2){-...}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:379 [inline] #1: ffff888022a48498 (&ctx->completion_lock#2){-...}-{2:2}, at: io_submit_flush_completions+0x4d/0x3a0 fs/io_uring.c:1829 #2: ffffffff8b363860 (rcu_read_lock){....}-{1:2}, at: kill_fasync+0x3d/0x460 fs/fcntl.c:1023 the dependencies between HARDIRQ-irq-safe lock and the holding lock: -> (&ctx->completion_lock#2){-...}-{2:2} { IN-HARDIRQ-W at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x39/0x50 kernel/locking/spinlock.c:159 io_timeout_fn+0x6f/0x3d0 fs/io_uring.c:5619 __run_hrtimer kernel/time/hrtimer.c:1519 [inline] __hrtimer_run_queues+0x693/0xea0 kernel/time/hrtimer.c:1583 hrtimer_interrupt+0x334/0x940 kernel/time/hrtimer.c:1645 local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1085 [inline] __sysvec_apic_timer_interrupt+0x146/0x540 arch/x86/kernel/apic/apic.c:1102 asm_call_irq_on_stack+0xf/0x20 __run_sysvec_on_irqstack arch/x86/include/asm/irq_stack.h:37 [inline] run_sysvec_on_irqstack_cond arch/x86/include/asm/irq_stack.h:89 [inline] sysvec_apic_timer_interrupt+0xbd/0x100 arch/x86/kernel/apic/apic.c:1096 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:628 __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:169 [inline] _raw_spin_unlock_irq+0x25/0x40 kernel/locking/spinlock.c:199 spin_unlock_irq include/linux/spinlock.h:404 [inline] io_timeout fs/io_uring.c:5823 [inline] io_issue_sqe+0x1cf3/0x4490 fs/io_uring.c:6217 __io_queue_sqe+0x228/0x10c0 fs/io_uring.c:6484 io_queue_sqe+0x631/0x10d0 fs/io_uring.c:6550 io_queue_link_head fs/io_uring.c:6561 [inline] io_submit_sqes+0xac1/0x2720 fs/io_uring.c:6886 __do_sys_io_uring_enter+0x6d1/0x1e70 fs/io_uring.c:9192 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 INITIAL USE at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0x32/0x50 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:379 [inline] io_submit_flush_completions+0x4d/0x3a0 fs/io_uring.c:1829 __io_req_complete+0x209/0x310 fs/io_uring.c:1870 io_nop fs/io_uring.c:3893 [inline] io_issue_sqe+0x1234/0x4490 fs/io_uring.c:6180 __io_queue_sqe+0x228/0x10c0 fs/io_uring.c:6484 io_queue_sqe+0x631/0x10d0 fs/io_uring.c:6550 io_submit_sqe fs/io_uring.c:6623 [inline] io_submit_sqes+0x1495/0x2720 fs/io_uring.c:6871 __do_sys_io_uring_enter+0x6d1/0x1e70 fs/io_uring.c:9192 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 } ... key at: [] __key.10+0x0/0x40 ... acquired at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 __io_commit_cqring fs/io_uring.c:1344 [inline] io_commit_cqring+0x34e/0xa90 fs/io_uring.c:1654 io_submit_flush_completions+0x269/0x3a0 fs/io_uring.c:1851 __io_req_complete+0x209/0x310 fs/io_uring.c:1870 io_nop fs/io_uring.c:3893 [inline] io_issue_sqe+0x1234/0x4490 fs/io_uring.c:6180 __io_queue_sqe+0x228/0x10c0 fs/io_uring.c:6484 io_queue_sqe+0x631/0x10d0 fs/io_uring.c:6550 io_submit_sqe fs/io_uring.c:6623 [inline] io_submit_sqes+0x1495/0x2720 fs/io_uring.c:6871 __do_sys_io_uring_enter+0x6d1/0x1e70 fs/io_uring.c:9192 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 the dependencies between the lock to be acquired and HARDIRQ-irq-unsafe lock: -> (&new->fa_lock){.+.+}-{2:2} { HARDIRQ-ON-R at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 pipe_write+0xb7a/0x1ac0 fs/pipe.c:558 call_write_iter include/linux/fs.h:1901 [inline] new_sync_write+0x426/0x650 fs/read_write.c:518 vfs_write+0x791/0xa30 fs/read_write.c:605 ksys_write+0x1ee/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 SOFTIRQ-ON-R at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 pipe_write+0xb7a/0x1ac0 fs/pipe.c:558 call_write_iter include/linux/fs.h:1901 [inline] new_sync_write+0x426/0x650 fs/read_write.c:518 vfs_write+0x791/0xa30 fs/read_write.c:605 ksys_write+0x1ee/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 INITIAL USE at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_write_lock_irq include/linux/rwlock_api_smp.h:196 [inline] _raw_write_lock_irq+0x32/0x50 kernel/locking/spinlock.c:311 fasync_insert_entry+0x1d8/0x2b0 fs/fcntl.c:929 lease_setup+0x9d/0x160 fs/locks.c:600 generic_add_lease fs/locks.c:1942 [inline] generic_setlease+0x10b7/0x1a20 fs/locks.c:2021 vfs_setlease+0xfd/0x120 fs/locks.c:2111 do_fcntl_add_lease fs/locks.c:2132 [inline] fcntl_setlease+0x134/0x2c0 fs/locks.c:2154 do_fcntl+0x2b6/0x1070 fs/fcntl.c:410 __do_sys_fcntl fs/fcntl.c:463 [inline] __se_sys_fcntl fs/fcntl.c:448 [inline] __x64_sys_fcntl+0x165/0x1e0 fs/fcntl.c:448 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 INITIAL READ USE at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 pipe_write+0xb7a/0x1ac0 fs/pipe.c:558 call_write_iter include/linux/fs.h:1901 [inline] new_sync_write+0x426/0x650 fs/read_write.c:518 vfs_write+0x791/0xa30 fs/read_write.c:605 ksys_write+0x1ee/0x250 fs/read_write.c:658 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 } ... key at: [] __key.0+0x0/0x40 ... acquired at: lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 __io_commit_cqring fs/io_uring.c:1344 [inline] io_commit_cqring+0x34e/0xa90 fs/io_uring.c:1654 io_submit_flush_completions+0x269/0x3a0 fs/io_uring.c:1851 __io_req_complete+0x209/0x310 fs/io_uring.c:1870 io_nop fs/io_uring.c:3893 [inline] io_issue_sqe+0x1234/0x4490 fs/io_uring.c:6180 __io_queue_sqe+0x228/0x10c0 fs/io_uring.c:6484 io_queue_sqe+0x631/0x10d0 fs/io_uring.c:6550 io_submit_sqe fs/io_uring.c:6623 [inline] io_submit_sqes+0x1495/0x2720 fs/io_uring.c:6871 __do_sys_io_uring_enter+0x6d1/0x1e70 fs/io_uring.c:9192 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 stack backtrace: CPU: 0 PID: 6133 Comm: syz-executor.2 Not tainted 5.11.0-rc1-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:79 [inline] dump_stack+0x107/0x163 lib/dump_stack.c:120 print_bad_irq_dependency kernel/locking/lockdep.c:2452 [inline] check_irq_usage.cold+0x4f5/0x6c8 kernel/locking/lockdep.c:2681 check_prev_add kernel/locking/lockdep.c:2872 [inline] check_prevs_add kernel/locking/lockdep.c:2993 [inline] validate_chain kernel/locking/lockdep.c:3608 [inline] __lock_acquire+0x2af6/0x5500 kernel/locking/lockdep.c:4832 lock_acquire kernel/locking/lockdep.c:5437 [inline] lock_acquire+0x29d/0x740 kernel/locking/lockdep.c:5402 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1004 [inline] kill_fasync fs/fcntl.c:1025 [inline] kill_fasync+0x14b/0x460 fs/fcntl.c:1018 __io_commit_cqring fs/io_uring.c:1344 [inline] io_commit_cqring+0x34e/0xa90 fs/io_uring.c:1654 io_submit_flush_completions+0x269/0x3a0 fs/io_uring.c:1851 __io_req_complete+0x209/0x310 fs/io_uring.c:1870 io_nop fs/io_uring.c:3893 [inline] io_issue_sqe+0x1234/0x4490 fs/io_uring.c:6180 __io_queue_sqe+0x228/0x10c0 fs/io_uring.c:6484 io_queue_sqe+0x631/0x10d0 fs/io_uring.c:6550 io_submit_sqe fs/io_uring.c:6623 [inline] io_submit_sqes+0x1495/0x2720 fs/io_uring.c:6871 __do_sys_io_uring_enter+0x6d1/0x1e70 fs/io_uring.c:9192 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x45e219 Code: 0d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f3ebf1e9c68 EFLAGS: 00000246 ORIG_RAX: 00000000000001aa RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 000000000045e219 RDX: 0000000000000000 RSI: 000000000000450c RDI: 0000000000000003 RBP: 000000000119c080 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000119c034 R13: 00000000016afb5f R14: 00007f3ebf1ea9c0 R15: 000000000119c034