====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc7-syzkaller-00123-g3a568e3a961b #0 Not tainted ------------------------------------------------------ syz-executor.5/14269 is trying to acquire lock: ffff88807bd148f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff8880314db048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2da/0xb40 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x476/0xff0 fs/buffer.c:2400 filemap_read_folio+0x19c/0x770 mm/filemap.c:2382 do_read_cache_folio+0x134/0x810 mm/filemap.c:3742 do_read_cache_page+0x30/0x210 mm/filemap.c:3808 read_mapping_page include/linux/pagemap.h:860 [inline] hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x54d/0x1ac0 fs/buffer.c:2120 __block_write_begin fs/buffer.c:2169 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2228 cont_write_begin+0x643/0x880 fs/buffer.c:2585 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52 cont_expand_zero fs/buffer.c:2512 [inline] cont_write_begin+0x316/0x880 fs/buffer.c:2575 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52 generic_cont_expand_simple+0x18b/0x2a0 fs/buffer.c:2476 hfsplus_setattr+0x15f/0x260 fs/hfsplus/inode.c:263 notify_change+0xb99/0xe60 fs/attr.c:499 do_truncate+0x220/0x300 fs/open.c:66 do_sys_ftruncate+0x2f3/0x390 fs/open.c:194 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7d0/0xb40 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1b9/0x260 fs/hfsplus/inode.c:269 notify_change+0xb99/0xe60 fs/attr.c:499 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3299 [inline] do_open fs/namei.c:3644 [inline] path_openat+0x2959/0x3180 fs/namei.c:3797 do_filp_open+0x234/0x490 fs/namei.c:3824 do_sys_openat2+0x13e/0x1d0 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_creat fs/open.c:1513 [inline] __se_sys_creat fs/open.c:1507 [inline] __x64_sys_creat+0x123/0x160 fs/open.c:1507 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz-executor.5/14269: #0: ffff88803113e410 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:403 #1: ffff8880314db240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff8880314db240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: do_truncate+0x20c/0x300 fs/open.c:64 #2: ffff8880314db048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2da/0xb40 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 14269 Comm: syz-executor.5 Not tainted 6.6.0-rc7-syzkaller-00123-g3a568e3a961b #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7d0/0xb40 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1b9/0x260 fs/hfsplus/inode.c:269 notify_change+0xb99/0xe60 fs/attr.c:499 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3299 [inline] do_open fs/namei.c:3644 [inline] path_openat+0x2959/0x3180 fs/namei.c:3797 do_filp_open+0x234/0x490 fs/namei.c:3824 do_sys_openat2+0x13e/0x1d0 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_creat fs/open.c:1513 [inline] __se_sys_creat fs/open.c:1507 [inline] __x64_sys_creat+0x123/0x160 fs/open.c:1507 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fd12ca7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd12d7670c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 00007fd12cb9bf80 RCX: 00007fd12ca7cae9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000100 RBP: 00007fd12cac847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fd12cb9bf80 R15: 00007ffd3dbece98