====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.666/6508 is trying to acquire lock: ffff0000d3d42a58 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 but task is already holding lock: ffff0000f08b2208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5e4 fs/quota/dquot.c:463 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6192 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474 ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4974 mount_bdev+0x274/0x370 fs/super.c:1398 ext4_mount+0x44/0x58 fs/ext4/super.c:6602 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1528 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6172 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6232 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_free_space+0x878/0xce8 fs/quota/dquot.c:1940 dquot_free_space_nodirty include/linux/quotaops.h:376 [inline] dquot_free_space include/linux/quotaops.h:381 [inline] dquot_free_block include/linux/quotaops.h:392 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline] ext4_free_blocks+0x1c0c/0x2bf0 fs/ext4/mballoc.c:6288 ext4_remove_blocks fs/ext4/extents.c:2519 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline] ext4_ext_remove_space+0x1c48/0x4254 fs/ext4/extents.c:2933 ext4_ext_truncate+0x188/0x250 fs/ext4/extents.c:4450 ext4_truncate+0x9c4/0x1058 fs/ext4/inode.c:4249 ext4_evict_inode+0xc30/0x124c fs/ext4/inode.c:289 evict+0x418/0x894 fs/inode.c:622 iput_final fs/inode.c:1740 [inline] iput+0x744/0x824 fs/inode.c:1766 ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360 ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474 ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4974 mount_bdev+0x274/0x370 fs/super.c:1398 ext4_mount+0x44/0x58 fs/ext4/super.c:6602 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1528 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6192 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_create+0xb4/0x480 fs/ext4/namei.c:2874 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0xf18/0x26cc fs/namei.c:3739 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 4 locks held by syz.0.666/6508: #0: ffff0000f08b2460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #1: ffff0000cfd4dda8 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000cfd4dda8 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: open_last_lookups fs/namei.c:3529 [inline] #1: ffff0000cfd4dda8 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: path_openat+0x640/0x26cc fs/namei.c:3739 #2: ffff0000e5db2b28 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x5e4 fs/quota/dquot.c:460 #3: ffff0000f08b2208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 stack backtrace: CPU: 0 PID: 6508 Comm: syz.0.666 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6192 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_create+0xb4/0x480 fs/ext4/namei.c:2874 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0xf18/0x26cc fs/namei.c:3739 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 EXT4-fs error (device loop0): ext4_add_entry:2484: inode #2: comm syz.0.666: Directory hole found for htree leaf block 0