(syz.4.1483,10138,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xc2d589a7, computed 0x6a4501d0. Applying ECC. ====================================================== WARNING: possible circular locking dependency detected 6.1.119-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.1483/10138 is trying to acquire lock: ffff0000e1700660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 but task is already holding lock: ffff0000e17009c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff0000e17009c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0x1044/0x1b5c fs/ocfs2/file.c:1243 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5727 ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4339 ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:889 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:945 ext4_append+0x260/0x4cc fs/ext4/namei.c:83 ext4_init_new_dir+0x294/0x8e4 fs/ext4/namei.c:3030 ext4_mkdir+0x3d4/0xa64 fs/ext4/namei.c:3076 vfs_mkdir+0x334/0x4e4 fs/namei.c:4106 do_mkdirat+0x220/0x510 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #4 (&ei->i_data_sem){++++}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283 ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5601 notify_change+0xb58/0xe1c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:65 do_sys_ftruncate+0x288/0x31c fs/open.c:193 __do_sys_ftruncate fs/open.c:204 [inline] __se_sys_ftruncate fs/open.c:202 [inline] __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #3 ( jbd2_handle ){++++}-{0:0} : start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2468 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2505 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3aa4/0x48c4 fs/ocfs2/super.c:1139 mount_bdev+0x274/0x370 fs/super.c:1443 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x278/0x8fc fs/namespace.c:3056 path_mount+0x590/0xe5c fs/namespace.c:3386 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount fs/namespace.c:3584 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2468 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2505 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3aa4/0x48c4 fs/ocfs2/super.c:1139 mount_bdev+0x274/0x370 fs/super.c:1443 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x278/0x8fc fs/namespace.c:3056 path_mount+0x590/0xe5c fs/namespace.c:3386 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount fs/namespace.c:3584 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (sb_internal#3){.+.+}-{0:0}: __lock_release kernel/locking/lockdep.c:5376 [inline] lock_release+0x364/0xa50 kernel/locking/lockdep.c:5682 up_write+0x94/0x76c kernel/locking/rwsem.c:1625 inode_unlock include/linux/fs.h:763 [inline] ocfs2_free_ac_resource fs/ocfs2/suballoc.c:126 [inline] ocfs2_free_alloc_context+0x94/0x188 fs/ocfs2/suballoc.c:140 ocfs2_write_begin_nolock+0x3ec0/0x3f6c fs/ocfs2/aops.c:1825 ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1904 generic_perform_write+0x278/0x55c mm/filemap.c:3845 __generic_file_write_iter+0x168/0x388 mm/filemap.c:3973 ocfs2_file_write_iter+0x15ac/0x1fbc fs/ocfs2/file.c:2467 do_iter_write+0x534/0x964 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x1ec/0x334 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0x1044/0x1b5c fs/ocfs2/file.c:1243 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&dquot->dq_lock); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); *** DEADLOCK *** 4 locks held by syz.4.1483/10138: #0: ffff0000c3c0e460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437 #1: ffff0000e1706d88 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000e1706d88 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: chown_common+0x358/0x7d8 fs/open.c:726 #2: ffff0000e16040a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806 #3: ffff0000e17009c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff0000e17009c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 stack backtrace: CPU: 1 PID: 10138 Comm: syz.4.1483 Not tainted 6.1.119-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0x1044/0x1b5c fs/ocfs2/file.c:1243 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585